Add register API for PHY Rank Pair registers

Fix access_delay_regs ut by choosing rank based on given rank pair
Put rank functions into a rank namespace

Change-Id: I57e0dc54e78c7b72df346fb902d5188330503919
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29372
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29374
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/sim.C b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/sim.C
index c85bee5fd..50d79b40b 100644
--- a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/sim.C
+++ b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/sim.C
@@ -84,7 +84,7 @@ fapi2::ReturnCode sf_init( const fapi2::Target<TARGET_TYPE_MCBIST>& i_target,
         // ranks. Therefore, we only need to clean up the primary ranks. And because there's 4 max, we can do it
         // all using the 4 address range registers of tne MCBIST (broadcast currently not considered.)
         // So we can write 0's to those to get their ECC fixed up.
-        FAPI_TRY( mss::primary_ranks(p, l_pr) );
+        FAPI_TRY( mss::rank::primary_ranks(p, l_pr) );
         fapi2::Assert( l_pr.size() <= mss::MAX_RANK_PER_DIMM );
 
         for (auto r = l_pr.begin(); r != l_pr.end(); ++l_rank_address_pair, ++r)
@@ -110,9 +110,9 @@ fapi2::ReturnCode sf_init( const fapi2::Target<TARGET_TYPE_MCBIST>& i_target,
 
                 l_fw_subtest.enable_port(mss::relative_pos<TARGET_TYPE_MCBIST>(p));
                 l_fw_subtest.change_addr_sel(l_rank_address_pair);
-                l_fw_subtest.enable_dimm(mss::get_dimm_from_rank(*r));
+                l_fw_subtest.enable_dimm(mss::rank::get_dimm_from_rank(*r));
                 l_program.iv_subtests.push_back(l_fw_subtest);
-                FAPI_DBG("adding superfast write for %s rank %d (dimm %d)", mss::c_str(p), *r, mss::get_dimm_from_rank(*r));
+                FAPI_DBG("adding superfast write for %s rank %d (dimm %d)", mss::c_str(p), *r, mss::rank::get_dimm_from_rank(*r));
             }
 
             // Read - we do a read here as verification can use this as a tool as we do the write and then the read.
@@ -125,9 +125,9 @@ fapi2::ReturnCode sf_init( const fapi2::Target<TARGET_TYPE_MCBIST>& i_target,
 
                 l_fr_subtest.enable_port(mss::relative_pos<TARGET_TYPE_MCBIST>(p));
                 l_fr_subtest.change_addr_sel(l_rank_address_pair);
-                l_fr_subtest.enable_dimm(mss::get_dimm_from_rank(*r));
+                l_fr_subtest.enable_dimm(mss::rank::get_dimm_from_rank(*r));
                 l_program.iv_subtests.push_back(l_fr_subtest);
-                FAPI_DBG("adding superfast read for %s rank %d (dimm %d)", mss::c_str(p), *r, mss::get_dimm_from_rank(*r));
+                FAPI_DBG("adding superfast read for %s rank %d (dimm %d)", mss::c_str(p), *r, mss::rank::get_dimm_from_rank(*r));
             }
         }