diff options
author | Brian Silver <bsilver@us.ibm.com> | 2016-11-07 14:41:01 -0600 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2016-11-11 17:08:35 -0500 |
commit | 320f69ffe7909dc71c71be968fa6b4bf557ed539 (patch) | |
tree | fbca3bf9d5fddad13e2788816bf1d02ee8f4db21 /src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H | |
parent | 23101c4bbf971f9c028aa135e88473903f86c0c1 (diff) | |
download | talos-hostboot-320f69ffe7909dc71c71be968fa6b4bf557ed539.tar.gz talos-hostboot-320f69ffe7909dc71c71be968fa6b4bf557ed539.zip |
Change memdiags interfaces for PRD
Both of the current sf_read() APIs can now be combined into one API:
The i_end parameter is no longer needed. The command should always stop
at the end of the slave rank on error, unless the workaround is place.
In which case, the command should stop immediately on error.
The i_address parameter will be optional. By default the start address
will be the first address of the first port (or all port in broadcast
mode). Otherwise, start on the address given.
For the targeted_scrub() API:
A new parameter will be added to specify if the command should be run
on a slave rank boundary or a master rank boundary.
The i_end parameter will need to default to not stop on error. Otherwise,
PRD will input to stop immediately when necessary.
Change-Id: If5d87af93aed8732277f8f769ae4d090b2bfea4f
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32335
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32339
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H')
-rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H index 64d49945d..d2c3fe44d 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mcbist/settings.H @@ -755,16 +755,21 @@ struct constraints /// /// @brief constraints constructor /// @param[in] i_stop stop conditions + /// @param[in] i_speed the speed at which to run + /// @param[in] i_end_boundary the place to stop on error /// @param[in] i_start_address address to start from + /// @param[in] i_end_address address to end at (optional, run to end) /// constraints( const stop_conditions& i_stop, const speed i_speed, const end_boundary i_end_boundary, - const address& i_start_address ): + const address& i_start_address, + const address& i_end_address = mcbist::address(0) ): constraints(i_stop, i_start_address) { iv_end_boundary = i_end_boundary; iv_speed = i_speed; + iv_end_address = i_end_address; FAPI_INF("setting up constraints with end boundary %d and speed 0x%x", i_end_boundary, i_speed); } |