Modify spd decoder API to hold its own SPD data, fix dependicies

Change-Id: I35f3c5ea70c8bea367ce2c260cd0ef0d8349f9c4
Original-Change-Id: Ida15c44455c0599deea3b455945ea78cf0ba0a5c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/23355
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Tested-by: Jenkins Server
Tested-by: Hostboot CI
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/24841
Tested-by: FSP CI Jenkins
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 21 insertions, 9 deletions

diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/timing.C b/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/timing.C
index 44fc46e88..08f716af6 100644
--- a/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/timing.C
+++ b/src/import/chips/p9/procedures/hwp/memory/lib/eff_config/timing.C
@@ -24,18 +24,27 @@
 namespace mss
 {
 
-// { density in GBs, tREFI(base) in picoseconds }
+// Proposed DDR4 Full spec update(79-4A)
+// Item No. 1716.78C
+// pg.46
+// Table 24 - tREFI and tRFC parameters
 static const std::vector<std::pair<uint8_t, uint64_t> > TREFI_BASE =
 {
+    // { density in GBs, tREFI(base) in nanoseconds }
     {2, 7800},
     {4, 7800},
     {8, 7800},
     // 16Gb - TBD
 };
 
-// { density in GBs, tRFC1(min) in picoseconds }
+
+// Proposed DDR4 Full spec update(79-4A)
+// Item No. 1716.78C
+// pg.46
+// Table 24 - tREFI and tRFC parameters
 static const std::vector<std::pair<uint8_t, uint64_t> > TRFC1_MIN =
 {
+    // { density in GBs, tRFC1(min) in nanoseconds }
     {2, 160},
     {4, 260},
     {8, 350},
@@ -43,9 +52,13 @@ static const std::vector<std::pair<uint8_t, uint64_t> > TRFC1_MIN =
 };
 
 
-// { density in GBs, tRFC2(min) in picoseconds }
+// Proposed DDR4 Full spec update(79-4A)
+// Item No. 1716.78C
+// pg.46
+// Table 24 - tREFI and tRFC parameters
 static const std::vector<std::pair<uint8_t, uint64_t> > TRFC2_MIN =
 {
+    // { density in GBs, tRFC2(min) in nanoseconds }
     {2, 110},
     {4, 160},
     {8, 260},
@@ -53,20 +66,19 @@ static const std::vector<std::pair<uint8_t, uint64_t> > TRFC2_MIN =
 };
 
 
-// { density in GBs, tRFC4(min) in picoseconds }
+// Proposed DDR4 Full spec update(79-4A)
+// Item No. 1716.78C
+// pg.46
+// Table 24 - tREFI and tRFC parameters
 static const std::vector<std::pair<uint8_t, uint64_t> > TRFC4_MIN =
 {
+    // { density in GBs, tRFC4(min) in nanoseconds }
     {2, 90},
     {4, 110},
     {8, 160},
     // 16Gb - TBD
 };
 
-
-//
-// The following are only used in eff_config
-//
-
 /// @brief Calculates refresh interval time 1 (tREFI 1)
 /// @param[in] i_target FAPI2 target
 /// @param[out] o_value timing val in ps