diff options
| author | Andre Marin <aamarin@us.ibm.com> | 2018-07-24 00:02:23 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-08-06 09:32:54 -0500 |
| commit | 6a03e838d00c6fb01525019c9b8c1cc3c667c7d3 (patch) | |
| tree | b2d8639f14c4e910c5a5b6efc60f17f34cde096f /src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C | |
| parent | 95b925b6af0e553da06f61d89d2a0c1616882e29 (diff) | |
| download | talos-hostboot-6a03e838d00c6fb01525019c9b8c1cc3c667c7d3.tar.gz talos-hostboot-6a03e838d00c6fb01525019c9b8c1cc3c667c7d3.zip | |
Generalize byte reading from SPD reading, for exp i2c reuse
Change-Id: I388e5abd6639464514fb9ca2d555362e431b753c
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63209
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63538
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C | 25 |
1 files changed, 15 insertions, 10 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C index 4e52d5083..2e2a49540 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C @@ -937,6 +937,7 @@ fapi_try_exit: /// fapi2::ReturnCode eff_dimm::primary_stack_type() { + constexpr size_t BYTE = 6; uint8_t l_stack_type = 0; uint8_t l_package_type = 0; @@ -952,22 +953,26 @@ fapi2::ReturnCode eff_dimm::primary_stack_type() // JEDEC standard says if the SPD says monolithic in A[7], // stack type must be 00 or "SDP" which is what our enum is set to FAPI_ASSERT( (l_stack_type == fapi2::ENUM_ATTR_EFF_PRIM_STACK_TYPE_SDP), - fapi2::MSS_BAD_SPD() - .set_VALUE(l_stack_type) - .set_BYTE(6) - .set_DIMM_TARGET(iv_dimm), - "Invalid SPD for calculating ATTR_EFF_PRIM_STACK_TYPE"); + fapi2::MSS_FAILED_DATA_INTEGRITY_CHECK(). + set_VALUE(l_stack_type). + set_BYTE(BYTE). + set_TARGET(iv_dimm). + set_FFDC_CODE(PRIMARY_STACK_TYPE), + "Invalid SPD for calculating ATTR_EFF_PRIM_STACK_TYPE for %s", + mss::c_str(iv_dimm) ); break; case mss::spd::NON_MONOLITHIC: FAPI_ASSERT( (l_stack_type == fapi2::ENUM_ATTR_EFF_PRIM_STACK_TYPE_DDP_QDP) || (l_stack_type == fapi2::ENUM_ATTR_EFF_PRIM_STACK_TYPE_3DS), - fapi2::MSS_BAD_SPD() - .set_VALUE(l_stack_type) - .set_BYTE(6) - .set_DIMM_TARGET(iv_dimm), - "Invalid SPD for calculating ATTR_EFF_PRIM_STACK_TYPE"); + fapi2::MSS_FAILED_DATA_INTEGRITY_CHECK(). + set_VALUE(l_stack_type). + set_BYTE(BYTE). + set_TARGET(iv_dimm). + set_FFDC_CODE(PRIMARY_STACK_TYPE), + "Invalid SPD for calculating ATTR_EFF_PRIM_STACK_TYPE for %s", + mss::c_str(iv_dimm) ); break; default: |
