summaryrefslogtreecommitdiffstats
path: root/src/import/chips/p9/procedures/hwp/io
diff options
context:
space:
mode:
authorChris Steffen <cwsteffen@us.ibm.com>2016-06-29 14:28:00 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2016-08-24 23:51:57 -0400
commitc635eea80f96c8fdf078605d9533ba783c209db6 (patch)
tree21b0962b2aa8ec19e3ffa209138512fbca35137b /src/import/chips/p9/procedures/hwp/io
parent78e583e5644c34bc9cfce5c2e1a49c44a65b1a60 (diff)
downloadtalos-hostboot-c635eea80f96c8fdf078605d9533ba783c209db6.tar.gz
talos-hostboot-c635eea80f96c8fdf078605d9533ba783c209db6.zip
P9 Xbus Scominit Check HWP Return Codes
Change-Id: I994c1e82b945c8438f38568e1ae6e6970235f4ee Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/26628 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Gary A. Peterson <garyp@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/26631 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/io')
-rw-r--r--src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.C32
-rw-r--r--src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.H6
2 files changed, 34 insertions, 4 deletions
diff --git a/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.C b/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.C
index 707172719..ee67c77b8 100644
--- a/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.C
+++ b/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.C
@@ -31,7 +31,7 @@
// *HWP HWP Backup Owner: Gary Peterson <garyp@us.ibm.com>
// *HWP FW Owner : Sumit Kumar <sumit_kumar@in.ibm.com>
// *HWP Team : IO
-// *HWP Level : 2
+// *HWP Level : 3
// *HWP Consumed by : FSP:HB
//----------------------------------------------------------------------------
//
@@ -159,16 +159,46 @@ fapi2::ReturnCode p9_io_xbus_scominit(
FAPI_INF("Group 0:Invoke FAPI procedure core: input_target");
FAPI_EXEC_HWP(rc, p9_xbus_g0_scom, i_target, l_system_target);
+ if( rc )
+ {
+ FAPI_ERR( "P9 Xbus G0 Main Target Scominit Failed" );
+ fapi2::current_err = rc;
+ break;
+ }
+
FAPI_INF("Group 0:Invoke FAPI procedure core: connected_target");
FAPI_EXEC_HWP(rc, p9_xbus_g0_scom, i_connected_target, l_system_target);
+
+ if( rc )
+ {
+ FAPI_ERR( "P9 Xbus G0 Connected Target Scominit Failed" );
+ fapi2::current_err = rc;
+ break;
+ }
+
break;
case ENUM_ATTR_XBUS_GROUP_1:
FAPI_INF("Group 1:Invoke FAPI procedure core: input_target");
FAPI_EXEC_HWP(rc, p9_xbus_g1_scom, i_target, l_system_target);
+ if( rc )
+ {
+ FAPI_ERR( "P9 Xbus G1 Main Target Scominit Failed" );
+ fapi2::current_err = rc;
+ break;
+ }
+
FAPI_INF("Group 1:Invoke FAPI procedure core: connected_target");
FAPI_EXEC_HWP(rc, p9_xbus_g1_scom, i_connected_target, l_system_target);
+
+ if( rc )
+ {
+ FAPI_ERR( "P9 Xbus G1 Connected Target Scominit Failed" );
+ fapi2::current_err = rc;
+ break;
+ }
+
break;
}
diff --git a/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.H b/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.H
index 2a35ce644..64b08ba9c 100644
--- a/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.H
+++ b/src/import/chips/p9/procedures/hwp/io/p9_io_xbus_scominit.H
@@ -31,7 +31,7 @@
// *HWP HWP Backup Owner: Gary Peterson <garyp@us.ibm.com>
// *HWP FW Owner : Sumit Kumar <sumit_kumar@in.ibm.com>
// *HWP Team : IO
-// *HWP Level : 2
+// *HWP Level : 3
// *HWP Consumed by : FSP:HB
//----------------------------------------------------------------------------
@@ -66,10 +66,10 @@ extern "C" {
* Should be called for all valid/connected XBUS endpoints
*
* @param[in] i_target Reference to XBUS chiplet target
- * i_connected_target Reference to connected XBUS chiplet target
+ * @param[in] i_connected_target Reference to connected XBUS chiplet target
* - p9.xbus.g0.scom.initfile
* - p9.xbus.g1.scom.initfile
- * i_group Reference to XBUS group-0/1
+ * @param[in] i_group Reference to XBUS group-0/1
*
* @return FAPI2_RC_SUCCESS on success, error otherwise
*/
OpenPOWER on IntegriCloud