diff options
| author | Joe McGill <jmcgill@us.ibm.com> | 2017-07-27 09:58:26 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-08-04 09:46:39 -0400 |
| commit | 842ef4363d9821d61803358c0f9f57e560728806 (patch) | |
| tree | 68669695f857e11888d8050731df2891abe27cff /src/import/chips/p9/procedures/hwp/io | |
| parent | c252560d78ef1fbbf9b902d0238a4218e8af4642 (diff) | |
| download | talos-hostboot-842ef4363d9821d61803358c0f9f57e560728806.tar.gz talos-hostboot-842ef4363d9821d61803358c0f9f57e560728806.zip | |
p9_io_obus_scominit -- use unit target to apply FIR settings
initial logic would incorrectly attempt to program absolute
address for OB0 chiplet instance for any invocation, which
would cause a SCOM failure if OB0 is partial good
Change-Id: I974741930285f9a8db001538562a81f6849be355
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43749
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43752
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/io')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/io/p9_io_obus_scominit.C | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/src/import/chips/p9/procedures/hwp/io/p9_io_obus_scominit.C b/src/import/chips/p9/procedures/hwp/io/p9_io_obus_scominit.C index 57d196582..dcaedad88 100644 --- a/src/import/chips/p9/procedures/hwp/io/p9_io_obus_scominit.C +++ b/src/import/chips/p9/procedures/hwp/io/p9_io_obus_scominit.C @@ -94,27 +94,17 @@ fapi2::ReturnCode p9_io_obus_scominit( const fapi2::Target<fapi2::TARGET_TYPE_OB FAPI_INF("Invoke FAPI procedure core: input_target"); FAPI_EXEC_HWP(rc, p9_obus_scom, i_target, l_system_target, l_proc_target); - // configure FIR, use OBUS unit number to form fully qualified SCOM address + // configure FIR { - uint8_t l_unit_pos; - uint64_t l_addr_offset; - FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_UNIT_POS, - i_target, - l_unit_pos), - "Error from FAPI_ATTR_GET (ATTR_CHIP_UNIT_POS)"); - - l_addr_offset = l_unit_pos; - l_addr_offset = l_addr_offset << 24; - - FAPI_TRY(fapi2::putScom(l_proc_target, + FAPI_TRY(fapi2::putScom(i_target, OBUS_FIR_ACTION0_REG, FIR_ACTION0), "Error from putScom (OBUS_FIR_ACTION0_REG)"); - FAPI_TRY(fapi2::putScom(l_proc_target, + FAPI_TRY(fapi2::putScom(i_target, OBUS_FIR_ACTION1_REG, FIR_ACTION1), "Error from putScom (OBUS_FIR_ACTION1_REG)"); - FAPI_TRY(fapi2::putScom(l_proc_target, + FAPI_TRY(fapi2::putScom(i_target, OBUS_FIR_MASK_REG, FIR_MASK), "Error from putScom (OBUS_FIR_MASK_REG)"); |
