diff options
| author | Christian Geddes <crgeddes@us.ibm.com> | 2018-05-22 14:15:56 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-05-28 14:54:44 -0400 |
| commit | fd269e881530ad008e696e4c5571a8a9d0e92d43 (patch) | |
| tree | 00827824651db34dcfbdacd2e32f684d88a578d9 /src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H | |
| parent | 2b37fd25aed152cf46acb314a54dfdcd018abd9f (diff) | |
| download | talos-hostboot-fd269e881530ad008e696e4c5571a8a9d0e92d43.tar.gz talos-hostboot-fd269e881530ad008e696e4c5571a8a9d0e92d43.zip | |
Clear obus fir mask attrs after restoring obus firmasks
After we have restored the values of the OBUS related fir masks,
we need to make sure that the attributes where the values are stored
are set back to 0. This will ensure that any future calls to the
p9_io_obus_firmask_save_restore HWP with the RESTORE flag set will
be no-ops until the HWP has been called with the SAVE flag
Change-Id: I3b853ed269cfb3ca9cec1b19f1fc4604dca80589
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59222
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59256
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H b/src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H index 8eaf80539..8873fe11a 100644 --- a/src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H +++ b/src/import/chips/p9/procedures/hwp/io/p9_io_obus_firmask_save_restore.H @@ -84,7 +84,8 @@ extern "C" * the SAVE paramter after istep 10.6. Once we reach runtime HBRT will call this HWP again with * the RESTORE OP_TYPE and the masks will be restored to their initial values. We expect the * HWP to be called with the RESTORE_OP_TYPE during the HBRT initialzation after the target service - * has been initialized in HBRT. + * has been initialized in HBRT. There should only be one single HWP call with the RESTORE flag for + * every call there is with the SAVE flag. * * Note: If this HWP is called with the SAVE op then after we read and store the firmasks * into attributes, we will set additional bits in the mask. |
