Change p9_mss_freq_system to write attributes, errors for Cronus

  Honor the maximum support frequencies based on rank configs
  Remove the MEMVPD_FREQ attribute
  Fixup VPD tooling and accessors for new freq attrs
  Fix test case handling of master ranks
  Fix handling of empty MCS in Cronus

Change-Id: I669ad0e81454f12368b484e826461ee76f7b9079
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29878
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29907
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>

2 files changed, 3 insertions, 8 deletions

diff --git a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.C b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.C
index 9ef8237b3..af72417c1 100644
--- a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.C
+++ b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.C
@@ -129,7 +129,7 @@ extern "C"
         uint8_t  l_rankShift = 0;
         uint8_t  l_freqMask  = 0;
         uint32_t l_freqTableIndex = 0;
-        fapi2::ATTR_MEMVPD_FREQS_MHZ_Type l_freqTable = {0};
+        constexpr uint32_t l_freqTable[] = {1866, 2133, 2400, 2666};
         uint32_t l_freqTableCnt = sizeof(l_freqTable) / sizeof(l_freqTable[0]);
         uint32_t l_index = 0; //start with first criteria row
         uint32_t l_indexMax = MAPPING_LAYOUT_MAXROWS;
@@ -267,11 +267,6 @@ extern "C"
         else
         {
             // Get the frequency index and calculate mask
-            FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_MEMVPD_FREQS_MHZ,
-                                   fapi2::Target<TARGET_TYPE_SYSTEM>(),
-                                   l_freqTable),
-                     "p9_get_mem_vpd_keyword: get ATTR_MEMVPD_FREQS_MHZ failed");
-
             for (; l_freqTableIndex < l_freqTableCnt; l_freqTableIndex++)
             {
                 if (i_vpd_info.iv_freq_mhz == l_freqTable[l_freqTableIndex])
@@ -289,7 +284,7 @@ extern "C"
                         set_MEMVPDFREQ3(uint32_t(l_freqTable[3])).
                         set_TARGET(i_target).
                         set_VPDTYPE(i_vpd_info.iv_vpd_type),
-                        "Frequency %d not in ATTR_MEMVPD_FREQS_MHZ",
+                        "Frequency %d not supported by Nimbus",
                         i_vpd_info.iv_freq_mhz);
             l_freqMask = (MAPPING_LAYOUT_FREQ_0 >> l_freqTableIndex); //zero based
             FAPI_DBG ("p9_get_mem_vpd_keyword: frequency index = %d mask=0x%02x",
diff --git a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.H b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.H
index 4baff3fa9..6bdaf6dbb 100644
--- a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.H
+++ b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mem_vpd_keyword.H
@@ -92,7 +92,7 @@ extern "C"
     ///             ... through ..
     ///             0x0002 dimm0 rank count 4, dimm1 rank count 2
     ///             0x0001 dimm0 rank count 4, dimm1 rank count 4
-    /// ffff        frequency index from ATTR_MEMVPD_FREQS_MHZ
+    /// ffff        frequency index from ATTR_MSS_MRW_SUPPORTED_FREQ
     ///             0x80 index 0
     ///             ... through ..
     ///             0x10 index 3