TOR space reductions

These changes avoid some waste of valuable memory used to store
TOR and rings contained in TOR. This is mostly needed as a SEEPROM relief.

Contains:
- 12 byte ring header (former 31551 commit)
- less zero padding at the end of compressed ring (former 31524 commit)
- removed an additional ring meta data structure (former 31524 commit)

In addition, it contains these fixes:
- fixed a bunch of scan addresses (former 33969 commit)
- increased size of ring decompression buffer (former 32796 commit)
- zero byte ring padding up to 4 byte boundaries for SBE (former 33969
  commit)
- added dbgl control of error trace after call to get_ring_from_sbe_image
- added enumerated ringId to the RS4v3 header
- fixed incorrect scan address masks for even/odd EX RS4 v3 ring handling
  in MVPD accessor functions
- fixed incorrect scan address region bits for odd EX rings translated from
  RS4 v2 to RS4 v3 in MVPD accessor functions

Change-Id: I8fd00760e6ac2b3760994d1ca819fffbf35188ca
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/33993
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34058
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.H b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.H
index 622c11687..8007a0d71 100644
--- a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.H
+++ b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.H
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2016                             */
+/* Contributors Listed Below - COPYRIGHT 2016,2017                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -65,7 +65,7 @@ extern "C"
      *                   MVPD_RECORD_CP00 - MVPD_KEYWORD_PDG
      * @param i_fapiTarget      -   cpu target
      * @param i_chipletId       -   Chiplet ID
-     * @param i_evenOddMask     -   Mask to choose even or odd EX. O for all other chiplets
+     * @param i_evenOdd         -   Even (0) or odd (1) EX. Disregarded for other chiplets.
      * @param i_ringId          -   Ring ID
      * @param i_pRingBuf        -   pointer to a buffer allocated by the caller
      *                              to receive the ring header and data.
@@ -86,7 +86,7 @@ extern "C"
      *                              caller does compression and decompression.
      *  Buffer:   io_rRingBufsize returns xNN.
      *    byte x0  CompressedScanData structure (rs4 header)
-     *    byte x18 compressed data (sizeof CompressedScanData is 0x18)
+     *    byte x0C compressed data (sizeof CompressedScanData is 0x0C)
      *    byte xNN last byte of compressed data
      *
      * @return fapi2::ReturnCode -   FAPI_RC_SUCCESS if success,
@@ -97,7 +97,7 @@ extern "C"
                             const Target<TARGET_TYPE_PROC_CHIP>&
                             i_fapiTarget,
                             const uint8_t  i_chipletId,
-                            const uint64_t i_evenOddMask,
+                            const uint8_t  i_evenOdd,
                             const uint8_t  i_ringId,
                             uint8_t*       io_pRingBuf,
                             uint32_t&      io_rRingBufsize );