L3 review and update to p9_mvpd_ring_funcs_errors.xml and

associated files.

Included in this commit:
- Greatly improved FFDC capturing and renaming of RC variables.
- Addition of fapiTarget as parm to several functions.
- Minor cleanup of APIs.

Change-Id: Icb2a2677ddb5c7faa56092542a127d8415066765
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44200
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44201
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>

1 files changed, 22 insertions, 16 deletions

diff --git a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.C b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.C
index d4a1cd30c..b98a7cb30 100644
--- a/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.C
+++ b/src/import/chips/p9/procedures/hwp/accessors/p9_get_mvpd_ring.C
@@ -22,13 +22,18 @@
 /* permissions and limitations under the License.                         */
 /*                                                                        */
 /* IBM_PROLOG_END_TAG                                                     */
-// $Id: p9_get_mvpd_ring.C,v 1.1 2012/07/19 22:00:40 mjjones Exp $
-/**
- *  @file p9_get_mvpd_ring.C
- *
- *  @brief fetch repair rings from MVPD  records
- *
- */
+//
+//  @file p9_get_mvpd_ring.C
+//
+//  @brief fetch repair rings from MVPD  records
+//
+//  *HWP HWP Owner: Mike Olsen <cmolsen@us.ibm.com>
+//  *HWP HWP Backup Owner: Sumit Kumar <sumit_kumar@in.ibm.com>
+//  *HWP Team: Infrastructure
+//  *HWP Level: 3
+//  *HWP Consumed by: HOSTBOOT, CRONUS
+//
+//
 
 #include    <stdint.h>
 
@@ -40,17 +45,18 @@
 
 extern "C"
 {
+
     using   namespace   fapi2;
 
-    // getMvpdRing: Wrapper to call common function mvpdRingFunc
-    fapi2::ReturnCode getMvpdRing( fapi2::MvpdRecord   i_record,
-                                   fapi2::MvpdKeyword  i_keyword,
-                                   const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>
+// getMvpdRing: Wrapper to call common function mvpdRingFunc
+    fapi2::ReturnCode getMvpdRing( const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>
                                    & i_fapiTarget,
+                                   fapi2::MvpdRecord   i_record,
+                                   fapi2::MvpdKeyword  i_keyword,
                                    const uint8_t       i_chipletId,
                                    const uint8_t       i_evenOdd,
                                    const uint8_t       i_ringId,
-                                   uint8_t*            i_pRingBuf,
+                                   uint8_t*            o_pRingBuf,
                                    uint32_t&           io_rRingBufsize )
     {
         fapi2::ReturnCode        l_fapirc;
@@ -62,14 +68,14 @@ extern "C"
                  io_rRingBufsize  );
 
         // common get and set processing
-        l_fapirc = mvpdRingFunc( MVPD_RING_GET,
+        l_fapirc = mvpdRingFunc( i_fapiTarget,
+                                 MVPD_RING_GET,
                                  i_record,
                                  i_keyword,
-                                 i_fapiTarget,
                                  i_chipletId,
                                  i_evenOdd,
                                  i_ringId,
-                                 i_pRingBuf,
+                                 o_pRingBuf,
                                  io_rRingBufsize );
 
 
@@ -79,4 +85,4 @@ extern "C"
         return  l_fapirc;
     }
 
-}   // extern "C"
+} // Extern C