diff options
author | Mark Pizzutillo <Mark.Pizzutillo@ibm.com> | 2019-08-06 18:23:07 -0400 |
---|---|---|
committer | Christian R Geddes <crgeddes@us.ibm.com> | 2019-08-13 14:35:15 -0500 |
commit | 24762ab00d2ac17a7b48002fb312e3c41e56c32a (patch) | |
tree | 5ea48499ba3cdef1026964782a8e8263c39d35fc /src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C | |
parent | 08db2d6a3a0bafa6d76a0f281541a6aa2b4d2156 (diff) | |
download | talos-hostboot-24762ab00d2ac17a7b48002fb312e3c41e56c32a.tar.gz talos-hostboot-24762ab00d2ac17a7b48002fb312e3c41e56c32a.zip |
Fix issue in pmic_enable where VR_ENABLE did not kick off
Also fixing a small issue/oversight. The PMIC requires enabled startup sequences
to "enable" the rails of previous sequences.
Change-Id: Id8a5baf54f7aef0c7e6aa97539fc78196c011dbf
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81828
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Dev-Ready: Steven B Janssen <janssens@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Devon A Baughen <devon.baughen1@ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81860
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C')
-rw-r--r-- | src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C b/src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C index 1318bab0c..d13574ac8 100644 --- a/src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C +++ b/src/import/chips/ocmb/common/procedures/hwp/pmic/pmic_enable.C @@ -57,6 +57,13 @@ extern "C" auto l_dimms = mss::find_targets<fapi2::TARGET_TYPE_DIMM>(i_ocmb_target); auto l_pmics = mss::find_targets<fapi2::TARGET_TYPE_PMIC>(i_ocmb_target); + // Check that we have PMICs (we wouldn't on gemini, for example) + if (l_pmics.empty()) + { + FAPI_INF("No PMICs to enable on %s, exiting.", mss::c_str(i_ocmb_target)); + return fapi2::FAPI2_RC_SUCCESS; + } + // Sort by index (low to high) since find_targets may not return the correct order std::sort(l_dimms.begin(), l_dimms.end(), [] (const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& l_first_dimm, |