diff options
author | Mark Pizzutillo <Mark.Pizzutillo@ibm.com> | 2019-12-02 17:58:25 -0500 |
---|---|---|
committer | Christian R Geddes <crgeddes@us.ibm.com> | 2019-12-03 15:27:41 -0600 |
commit | 29176896830047abfc63248ff8d38ab65672fd34 (patch) | |
tree | e69f287d77f612f3a454c0d48e380115496d1049 /src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils | |
parent | d277b5e5d4edbd3085cea728d0743e186f2b8059 (diff) | |
download | talos-hostboot-29176896830047abfc63248ff8d38ab65672fd34.tar.gz talos-hostboot-29176896830047abfc63248ff8d38ab65672fd34.zip |
Remove vin_bulk check before status clears in pmic_enable
The VIN_BULK bit of R08 used to update live, either that
or it just never updated at all. Either way, the bit gets stuck
in a stale error state now, and since it's checked before the
error bits are cleared, the clears never actually occur,
leaving stale errors that are killing isteps
Change-Id: Ib10de516554fd3e95cf9c09f5e6a0ab62fdd340f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87958
Dev-Ready: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87964
Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Christian R Geddes <crgeddes@us.ibm.com>
Diffstat (limited to 'src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils')
-rw-r--r-- | src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_enable_utils.C | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_enable_utils.C b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_enable_utils.C index 70951fb89..26ea9e7ef 100644 --- a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_enable_utils.C +++ b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_enable_utils.C @@ -533,9 +533,6 @@ fapi2::ReturnCode disable_and_reset_pmics(const std::vector<fapi2::Target<fapi2: for (const auto& l_pmic : i_pmics) { - // Make sure PMIC is alive - FAPI_TRY(mss::pmic::poll_for_pbulk_good(l_pmic)); - // First, disable { fapi2::buffer<uint8_t> l_reg_contents; |