diff options
| author | Claus Michael Olsen <cmolsen@us.ibm.com> | 2017-04-05 05:16:51 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-12-10 16:02:46 -0500 |
| commit | b78b33c5a32ac5c12ca0fd980f054a86258eec00 (patch) | |
| tree | 10cb7d12bd76545fa9245973ffee12f9c4b61903 /src/import/chips/centaur/utils/imageProcs/cen_ringId.H | |
| parent | fabc7bd251908585f097d37fcc0cadd29a2ee635 (diff) | |
| download | talos-hostboot-b78b33c5a32ac5c12ca0fd980f054a86258eec00.tar.gz talos-hostboot-b78b33c5a32ac5c12ca0fd980f054a86258eec00.zip | |
Code restruct: TOR API
Key_Cronus_Test=XIP_REGRESS
Code restructuring aiming at:
- utilizing TOR magic header info
- enforce a common approach for
- extracting metadata for all image,chipType combinations
- traversing images for all image,chipType combinations
- shrinking code size by reusing common code segments
- improve readability by
- separating more clearly metadata extraction and image traversal
- slight rearrange of certain code segments
- remove leftover hardcoded assumptions about ring/TOR data and structs
- variables appropriately renamed and now all using camel style
Change-Id: I50ace8b2fdb340a97ce6d74ce545c5e1acd21c40
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38863
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: GIRISANKAR PAULRAJ <gpaulraj@in.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43251
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/centaur/utils/imageProcs/cen_ringId.H')
| -rw-r--r-- | src/import/chips/centaur/utils/imageProcs/cen_ringId.H | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/import/chips/centaur/utils/imageProcs/cen_ringId.H b/src/import/chips/centaur/utils/imageProcs/cen_ringId.H index 134c3268a..fb58b76ee 100644 --- a/src/import/chips/centaur/utils/imageProcs/cen_ringId.H +++ b/src/import/chips/centaur/utils/imageProcs/cen_ringId.H @@ -380,8 +380,7 @@ static const RingProperties_t RING_PROPERTIES[NUM_RING_IDS] = // returns our own chiplet enum value for this ringId ChipletType_t -ringid_get_chiplet( - RingId_t i_ringId); +ringid_get_chiplet(RingId_t i_ringId); // returns data structures defined for chiplet type // as determined by ringId @@ -396,8 +395,7 @@ ringid_get_chiplet_properties( // returns properties of a ring as determined by ringId GenRingIdList* -ringid_get_ring_properties( - RingId_t i_ringId); +ringid_get_ring_list(RingId_t i_ringId); #endif // _CEN_RINGID_H_ |
