diff options
| author | Artem Senichev <a.senichev@yadro.com> | 2018-10-17 18:01:43 +0300 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-10-29 11:28:24 -0500 |
| commit | 61fb23dd2828ab3ccf3857a28204f7250c696100 (patch) | |
| tree | 24fe8ce4b8a3d10745ed2c1de519fffc33f4ed73 /src/build/tools | |
| parent | 0c5edba986eb543bc94ecb3514c40ca151dafc61 (diff) | |
| download | talos-hostboot-61fb23dd2828ab3ccf3857a28204f7250c696100.tar.gz talos-hostboot-61fb23dd2828ab3ccf3857a28204f7250c696100.zip | |
Fix incorrect syntax in addimgid shell script
Construction '>&' is a bash specific redirection.
Make-based build system uses posix shell (sh), not bash.
As a result, during the call to addimgid from Makefile we got
'Syntax error: Bad fd number' and empty image name.
Anyway, it is a bad idea to hide build logs.
Resolves #149
Signed-off-by: Artem Senichev <a.senichev@yadro.com>
Change-Id: I77102484f41e4198cca8906a6698fc42b7574380
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67624
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/build/tools')
| -rwxr-xr-x | src/build/tools/addimgid | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/build/tools/addimgid b/src/build/tools/addimgid index 69a2f1b2a..d217578ba 100755 --- a/src/build/tools/addimgid +++ b/src/build/tools/addimgid @@ -6,7 +6,7 @@ # # OpenPOWER HostBoot Project # -# Contributors Listed Below - COPYRIGHT 2011,2017 +# Contributors Listed Below - COPYRIGHT 2011,2018 # [+] Google Inc. # [+] International Business Machines Corp. # @@ -58,5 +58,5 @@ if (($imageId =~ m/Unknown-Image/) || # Couldn't find git describe tag. $imageId = $imageId."/".$ENV{"USER"}; } -system("echo -n $imageId | dd of=$img conv=notrunc bs=1 seek=$address count=127 >& /dev/null"); +system("echo -n $imageId | dd of=$img conv=notrunc bs=1 seek=$address count=127"); exit $? |
