linker: fix compiler warnings

In Fedora 28 (x86_64) the linker binary, produced by GCC 8.1.1, always
ended in an infinite loop in which it repeatedly appended some text to
*.lnkout.bz2 file and *.bin.modinfo file.

Example :  .hbicore.lnkout.bz2:  Error writing to output.
                                Success

           hbicore.bin.modinfo:  hbicore.elf,0x0

The GCC was also displaying warnings about missing return statements
(-Wreturn-type). When these warnings were fixed, the problem with
infinite loop disappeared. This problem also never appeared when the
-O0 flag was used.

While being there, also fix some warnings that happen with the -Wall
flag.

Resolves #143
Change-Id: Ia1ddfa07d3b22b151922de2df1db91ffc2aad2ca
Signed-off-by: Jan Hlavac <jhlavac@redhat.com>
Signed-off-by: Joel Stanley <joel.stanley@au1.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61862
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/62830
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>

0 files changed, 0 insertions, 0 deletions