diff options
| author | Ilya Smirnov <ismirno@us.ibm.com> | 2018-11-12 16:01:12 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-11-19 12:01:45 -0600 |
| commit | c8511398e857a9b03ccf1d1b2cb24209f494084c (patch) | |
| tree | 21a6001305e3b01a68cf8963d00965b199b246ed /src/build/citest | |
| parent | cd754bf0b11117790f5d926844f7a8b7f595230d (diff) | |
| download | talos-hostboot-c8511398e857a9b03ccf1d1b2cb24209f494084c.tar.gz talos-hostboot-c8511398e857a9b03ccf1d1b2cb24209f494084c.zip | |
Serialize the Check For Prologs in CI
Prolog checks are performed in parallel with build in hostboot
CI process, and the return code from the prolog checking
script is checked after the build job completes, which
introduces significant delays before the developer is informed
of incorrect prologs. This change serializes the check for
prolog correctness and forces the check to run before the build
process, so that the developer is informed about bad prologs
as soon as possible.
Change-Id: Ib84802f14022712268db1b0b539396e59d25792f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68678
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/build/citest')
| -rwxr-xr-x | src/build/citest/build-script | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/src/build/citest/build-script b/src/build/citest/build-script index b88482eca..caf718eaa 100755 --- a/src/build/citest/build-script +++ b/src/build/citest/build-script @@ -41,8 +41,16 @@ echo "#--------------------------------" export SECURITY_HW_POLICY="1" # Check copyright. -check-copyright > copyright.log 2>&1 & -COPYRIGHT_PID=$! +check-copyright > copyright.log 2>&1 +if [ $? -eq 0 ]; then + echo "----Copyright check succeeded." + cat copyright.log +else + echo "----Copyright check failed." + cat copyright.log + exit -1 +fi + # Create simics sandbox. create-sandbox > create-sandbox.log 2>&1 & @@ -57,16 +65,6 @@ make -j32 || exit -1 echo "#--------------------------------" printf "\n\nrc=$?: $(date): FINISHED running (\"make -j32\" was started at $my_date)\n\n" echo "#--------------------------------" -# Check copyright completion. -wait $COPYRIGHT_PID -if [ $? -eq 0 ]; then - echo "----Copyright check succeeded." - cat copyright.log -else - echo "----Copyright check failed." - cat copyright.log - exit -1 -fi # Check sandbox create completion. wait $CREATESANDBOX_PID |
