diff options
| author | Nick Bofferding <bofferdn@us.ibm.com> | 2018-07-06 13:46:35 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-02-22 19:45:39 -0600 |
| commit | ee1cd5b0adfaf133abe846ccbaebe48d7dbded0f (patch) | |
| tree | c0510a903e3b2ff3eebec4995a59e9fa665897d0 /src/bootloader | |
| parent | acd134ba521f26ba69b1911c8f293fd52df2a2b6 (diff) | |
| download | talos-hostboot-ee1cd5b0adfaf133abe846ccbaebe48d7dbded0f.tar.gz talos-hostboot-ee1cd5b0adfaf133abe846ccbaebe48d7dbded0f.zip | |
Enhance RAS for case where boot firmware image is too big to load
Provides a better fail indicator when the boot firmware image
is too big to load
Change-Id: Ibb8765dec430b4e38de1d82e74e144c7ea8f3959
CQ: SW437090
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/61989
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/bootloader')
| -rw-r--r-- | src/bootloader/bootloader.C | 35 |
1 files changed, 33 insertions, 2 deletions
diff --git a/src/bootloader/bootloader.C b/src/bootloader/bootloader.C index 6cb1642dd..69058b18b 100644 --- a/src/bootloader/bootloader.C +++ b/src/bootloader/bootloader.C @@ -456,11 +456,42 @@ namespace Bootloader{ bool l_hbbEcc = ( g_blData->bl_hbbSection.integrity == FFS_INTEG_ECC_PROTECT); + uint32_t workingLength= (l_hbbEcc) ? + (l_hbbLength * LENGTH_W_ECC)/LENGTH_WO_ECC : l_hbbLength; + + // handleMMIO below always moves WORDSIZE chunks at a time, even + // if there is just one byte left, so subtract WORDSIZE from the + // limit to compensate + if(workingLength > (MEGABYTE-WORDSIZE)) + { + BOOTLOADER_TRACE(BTLDR_TRC_BAD_WORK_LEN); + /*@ + * @errortype + * @moduleid Bootloader::MOD_BOOTLOADER_MAIN + * @reasoncode Bootloader::RC_BAD_WORK_LEN + * @userdata1[0:15] TI_WITH_SRC + * @userdata1[16:31] TI_BOOTLOADER + * @userdata1[32:63] Failing address = 0 + * @userdata2[0:31] Length of data from TOC (bytes) + * @userdata2[32:63] Working length (bytes) + * @errorInfo[0:31] Max space available (bytes) + * @devdesc Not enough memory to load boot firmware + * @custdesc Failed to load boot firmware + */ + bl_terminate( + MOD_BOOTLOADER_MAIN, + RC_BAD_WORK_LEN, + l_hbbLength, + workingLength, + true, + 0, + (MEGABYTE-WORDSIZE)); + } + // Copy HB base code from PNOR to working location handleMMIO(l_pnorStart + l_hbbFlashOffset, (l_hbbEcc) ? HBB_ECC_WORKING_ADDR : HBB_WORKING_ADDR, - (l_hbbEcc) ? (l_hbbLength * LENGTH_W_ECC)/LENGTH_WO_ECC - : l_hbbLength, + workingLength, WORDSIZE); BOOTLOADER_TRACE(BTLDR_TRC_MAIN_WORKING_HANDLEMMIO_RTN); |
