diff options
author | Zane Shelley <zshelle@us.ibm.com> | 2014-03-12 14:43:28 -0500 |
---|---|---|
committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2014-04-02 16:00:13 -0500 |
commit | cec376b563bafb0c9f7fe4babacdeaa6aed31986 (patch) | |
tree | 11044862389fb668126573165421fba88b065567 | |
parent | 1afe8d7e76c8b3b00524b8e9c7b47a27183fe00b (diff) | |
download | talos-hostboot-cec376b563bafb0c9f7fe4babacdeaa6aed31986.tar.gz talos-hostboot-cec376b563bafb0c9f7fe4babacdeaa6aed31986.zip |
PRD: Beam errors in Hostboot
Change-Id: Ie49304ea26f136616151a8315b09f505a92a6de8
CQ: SW253080
Backport: release-fips810
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/9569
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/9866
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
7 files changed, 67 insertions, 24 deletions
diff --git a/src/build/beam/prdf/prdfBitKey.C b/src/build/beam/prdf/prdfBitKey.C new file mode 100644 index 000000000..657618c42 --- /dev/null +++ b/src/build/beam/prdf/prdfBitKey.C @@ -0,0 +1,24 @@ +/* IBM_PROLOG_BEGIN_TAG */ +/* This is an automatically generated prolog. */ +/* */ +/* $Source: src/build/beam/prdf/prdfBitKey.C $ */ +/* */ +/* IBM CONFIDENTIAL */ +/* */ +/* COPYRIGHT International Business Machines Corp. 2014 */ +/* */ +/* p1 */ +/* */ +/* Object Code Only (OCO) source materials */ +/* Licensed Internal Code Source Materials */ +/* IBM HostBoot Licensed Internal Code */ +/* */ +/* The source code for this program is not published or otherwise */ +/* divested of its trade secrets, irrespective of what has been */ +/* deposited with the U.S. Copyright Office. */ +/* */ +/* Origin: 30 */ +/* */ +/* IBM_PROLOG_END_TAG */ +>>>MISTAKE17_operator==_f7028aed1505 +>>>MISTAKE17_operator==_70cd34271505 diff --git a/src/build/beam/prdf/prdfPegasusConfigurator.C b/src/build/beam/prdf/prdfPegasusConfigurator.C new file mode 100644 index 000000000..770c81143 --- /dev/null +++ b/src/build/beam/prdf/prdfPegasusConfigurator.C @@ -0,0 +1,24 @@ +/* IBM_PROLOG_BEGIN_TAG */ +/* This is an automatically generated prolog. */ +/* */ +/* $Source: src/build/beam/prdf/prdfPegasusConfigurator.C $ */ +/* */ +/* IBM CONFIDENTIAL */ +/* */ +/* COPYRIGHT International Business Machines Corp. 2014 */ +/* */ +/* p1 */ +/* */ +/* Object Code Only (OCO) source materials */ +/* Licensed Internal Code Source Materials */ +/* IBM HostBoot Licensed Internal Code */ +/* */ +/* The source code for this program is not published or otherwise */ +/* divested of its trade secrets, irrespective of what has been */ +/* deposited with the U.S. Copyright Office. */ +/* */ +/* Origin: 30 */ +/* */ +/* IBM_PROLOG_END_TAG */ +>>>MISTAKE17_addPllDomainsToSystem_954f5e401505 +>>>MISTAKE17_addPllDomainsToSystem_c01c04751505 diff --git a/src/usr/diag/prdf/common/framework/register/prdfScanFacility.C b/src/usr/diag/prdf/common/framework/register/prdfScanFacility.C index 8eed62ca6..5534943ee 100755 --- a/src/usr/diag/prdf/common/framework/register/prdfScanFacility.C +++ b/src/usr/diag/prdf/common/framework/register/prdfScanFacility.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2002,2013 */ +/* COPYRIGHT International Business Machines Corp. 2002,2014 */ /* */ /* p1 */ /* */ @@ -161,12 +161,12 @@ SCAN_COMM_REGISTER_CLASS & ScanFacility::GetOrRegister( //----------------------------------------------------------------------------- SCAN_COMM_REGISTER_CLASS & ScanFacility::GetAttnTypeRegister( - SCAN_COMM_REGISTER_CLASS & i_check, - SCAN_COMM_REGISTER_CLASS & i_recov, - SCAN_COMM_REGISTER_CLASS & i_special, - SCAN_COMM_REGISTER_CLASS & i_proccs ) + SCAN_COMM_REGISTER_CLASS * i_check, + SCAN_COMM_REGISTER_CLASS * i_recov, + SCAN_COMM_REGISTER_CLASS * i_special, + SCAN_COMM_REGISTER_CLASS * i_proccs ) { - AttnTypeRegister r(i_check,i_recov,i_special,i_proccs); + AttnTypeRegister r(*i_check, *i_recov, *i_special, *i_proccs); return iv_attnRegFw.get(r); } diff --git a/src/usr/diag/prdf/common/framework/register/prdfScanFacility.H b/src/usr/diag/prdf/common/framework/register/prdfScanFacility.H index 22cc41a42..2fb539cdb 100755 --- a/src/usr/diag/prdf/common/framework/register/prdfScanFacility.H +++ b/src/usr/diag/prdf/common/framework/register/prdfScanFacility.H @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2002,2013 */ +/* COPYRIGHT International Business Machines Corp. 2002,2014 */ /* */ /* p1 */ /* */ @@ -162,14 +162,14 @@ public: /** * @brief Get a AttnTypeRegister - * @params 3 scr Registers + * @params 4 pointers to scr Registers * @post only one instance of the register with these SCR's will exist */ SCAN_COMM_REGISTER_CLASS & GetAttnTypeRegister( - SCAN_COMM_REGISTER_CLASS & i_check, - SCAN_COMM_REGISTER_CLASS & i_recov, - SCAN_COMM_REGISTER_CLASS & i_special, - SCAN_COMM_REGISTER_CLASS & i_proccs); + SCAN_COMM_REGISTER_CLASS * i_check, + SCAN_COMM_REGISTER_CLASS * i_recov, + SCAN_COMM_REGISTER_CLASS * i_special, + SCAN_COMM_REGISTER_CLASS * i_proccs); /** * @brief Get a PrdfConstantRegister diff --git a/src/usr/diag/prdf/common/framework/rule/prdfRuleMetaData.C b/src/usr/diag/prdf/common/framework/rule/prdfRuleMetaData.C index c93cdccb6..88ee7bf43 100644 --- a/src/usr/diag/prdf/common/framework/rule/prdfRuleMetaData.C +++ b/src/usr/diag/prdf/common/framework/rule/prdfRuleMetaData.C @@ -682,11 +682,11 @@ SCAN_COMM_REGISTER_CLASS * RuleMetaData::createVirtualRegister( l_arg[3] = createVirtualRegister(i_vReg->cv_value[3].p, i_data); } - // passing NULL objects in l_arg[x] - l_rc = &i_data.cv_scanFactory.GetAttnTypeRegister(*l_arg[0], - *l_arg[1], - *l_arg[2], - *l_arg[3]); + // passing NULL objects in *l_arg[x] + l_rc = &i_data.cv_scanFactory.GetAttnTypeRegister(l_arg[0], + l_arg[1], + l_arg[2], + l_arg[3]); break; case Prdr::BIT_STR: diff --git a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaRceTable.C b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaRceTable.C index 0f02d466c..72543769c 100644 --- a/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaRceTable.C +++ b/src/usr/diag/prdf/common/plat/pegasus/prdfCenMbaRceTable.C @@ -63,7 +63,7 @@ bool CenMbaRceTable::addEntry( const CenRank & i_rank , { // Insert all entries even if threshold is crossed // for better FFDC. - o_doTps |= it->second.addAddress( 0, i_sc ); + o_doTps = o_doTps || it->second.addAddress( 0, i_sc ); } return o_doTps; diff --git a/src/usr/diag/prdf/plat/pegasus/prdfDramRepairs.C b/src/usr/diag/prdf/plat/pegasus/prdfDramRepairs.C index c479460a6..c15c402fe 100644 --- a/src/usr/diag/prdf/plat/pegasus/prdfDramRepairs.C +++ b/src/usr/diag/prdf/plat/pegasus/prdfDramRepairs.C @@ -5,7 +5,7 @@ /* */ /* IBM CONFIDENTIAL */ /* */ -/* COPYRIGHT International Business Machines Corp. 2012,2013 */ +/* COPYRIGHT International Business Machines Corp. 2012,2014 */ /* */ /* p1 */ /* */ @@ -255,8 +255,6 @@ bool screenBadDqs( TargetHandle_t i_mba, const std::vector<CenRank> & i_ranks ) bool o_calloutMade = false; bool analysisErrors = false; - errlHndl_t errl = NULL; // Initially NULL, will create if needed. - for ( std::vector<CenRank>::const_iterator rank = i_ranks.begin(); rank != i_ranks.end(); rank++ ) { @@ -275,9 +273,6 @@ bool screenBadDqs( TargetHandle_t i_mba, const std::vector<CenRank> & i_ranks ) } } - // Commit the error log, if needed. - commitErrl( errl, i_mba ); - // Commit an additional error log indicating something failed in the // analysis, if needed. commitSoftError( PRDF_DETECTED_FAIL_SOFTWARE, i_mba, |