summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarty Gloff <mgloff@us.ibm.com>2015-07-28 16:23:33 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2015-10-05 13:13:20 -0500
commitca310bd494ea072ded3dddca21f3fe303b928bf8 (patch)
tree385228aed1bb522a68d814330a483b6fc0844f0c
parent597ebc37c6c4b16a62b0f693cc18d9f371e9bbb5 (diff)
downloadtalos-hostboot-ca310bd494ea072ded3dddca21f3fe303b928bf8.tar.gz
talos-hostboot-ca310bd494ea072ded3dddca21f3fe303b928bf8.zip
getecid being called on deconfigured parts
Change-Id: Ib7429e73a739ef3d4508249b1f5aaff54d131663 RTC:129813 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/19403 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
-rw-r--r--src/usr/hwpf/hwp/slave_sbe/slave_sbe.C30
1 files changed, 21 insertions, 9 deletions
diff --git a/src/usr/hwpf/hwp/slave_sbe/slave_sbe.C b/src/usr/hwpf/hwp/slave_sbe/slave_sbe.C
index 949314433..1634d6c06 100644
--- a/src/usr/hwpf/hwp/slave_sbe/slave_sbe.C
+++ b/src/usr/hwpf/hwp/slave_sbe/slave_sbe.C
@@ -591,18 +591,30 @@ void* call_proc_check_slave_sbe_seeprom_complete( void *io_pArgs )
if (l_errl)
{
- TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
- "ERROR : proc_getecid",
- " failed, returning errorlog" );
+ if (l_pProcTarget->getAttr<ATTR_HWAS_STATE>().functional)
+ {
+ TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
+ "ERROR : proc_getecid",
+ " failed, returning errorlog" );
- // capture the target data in the elog
- ErrlUserDetailsTarget(l_pProcTarget).addToLog( l_errl );
+ // capture the target data in the elog
+ ErrlUserDetailsTarget(l_pProcTarget).addToLog( l_errl );
- // Create IStep error log and cross reference error that occurred
- l_stepError.addErrorDetails( l_errl );
+ // Create IStep error log, cross reference error that occurred
+ l_stepError.addErrorDetails( l_errl );
- // Commit error log
- errlCommit( l_errl, HWPF_COMP_ID );
+ // Commit error log
+ errlCommit( l_errl, HWPF_COMP_ID );
+ }
+ else // Not functional, proc deconfigured, don't report error
+ {
+ TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
+ "ERROR : proc_getecid",
+ " failed, proc target deconfigured" );
+
+ delete l_errl;
+ l_errl = NULL;
+ }
}
else
{
OpenPOWER on IntegriCloud