diff options
author | Stephen Cprek <smcprek@us.ibm.com> | 2017-07-12 09:18:13 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-07-20 15:54:53 -0400 |
commit | c30be2b5469301e7269dc5689a70428e592f369f (patch) | |
tree | 21408e5fdd3bb0458e888999bf320e446938cace | |
parent | 781d316517240e869cc76ceff5cde3eb1fe6bc48 (diff) | |
download | talos-hostboot-c30be2b5469301e7269dc5689a70428e592f369f.tar.gz talos-hostboot-c30be2b5469301e7269dc5689a70428e592f369f.zip |
Address minor comments from Story 175114
Done separately in order to not restart CI on other commits
Change-Id: I02c91d15c7a58673ba9e3da67a61aee66a647915
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43034
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
-rwxr-xr-x | src/build/debug/Hostboot/Dump.pm | 2 | ||||
-rwxr-xr-x | src/build/debug/fsp-memdump.sh | 4 | ||||
-rw-r--r-- | src/usr/secureboot/base/service.C | 1 |
3 files changed, 3 insertions, 4 deletions
diff --git a/src/build/debug/Hostboot/Dump.pm b/src/build/debug/Hostboot/Dump.pm index 0966e2187..e7c1c78de 100755 --- a/src/build/debug/Hostboot/Dump.pm +++ b/src/build/debug/Hostboot/Dump.pm @@ -41,7 +41,7 @@ use constant MEMSTATE_MS_32MEG => 0x20; use constant _KB => 1024; use constant _MB => 1024 * 1024; -# Size of HBB PNOR partition without ECC, page algined down, minus 4K header +# Size of HBB PNOR partition without ECC, page aligned down, minus 4K header use constant MAX_HBB_SIZE => (904 * _KB); # Map the available memory at each state. diff --git a/src/build/debug/fsp-memdump.sh b/src/build/debug/fsp-memdump.sh index d4313d671..49e57fa9a 100755 --- a/src/build/debug/fsp-memdump.sh +++ b/src/build/debug/fsp-memdump.sh @@ -117,14 +117,14 @@ HB_BASE_HRMOR=`expr 32 \* 1024 \* 1024 \* 1024 \* 1024` HRMOR=`expr ${HB_BASE_HRMOR} \* ${NODE} + ${HB_OFFSET}` echo "NODE: ${NODE} - HRMOR is: ${HRMOR}" -# Using initial STATE, iterate through all the included states dumping each's +# Using initial STATE, iterate through all the included states dumping each # appropriate memory sections. while [[ ${STATE} != BREAK ]] do # *** NOTE: Keep in sync with Dump.pm and bootloaderif.H (MAX_HBB_SIZE) case ${STATE} in 00|0) - # Size of HBB PNOR partition without ECC, page algined down, minus 4K header + # Size of HBB PNOR partition without ECC, page aligned down, minus 4K header dump 0 925696 STATE=BREAK ;; diff --git a/src/usr/secureboot/base/service.C b/src/usr/secureboot/base/service.C index 2674005c0..fc4498908 100644 --- a/src/usr/secureboot/base/service.C +++ b/src/usr/secureboot/base/service.C @@ -98,7 +98,6 @@ void* initializeBase(void* unused) Singleton<Header>::instance().loadSecurely(); } - // Don't extend more than 1/2 cache in VPO as fake PNOR is there // Don't enable SecureRomManager in VPO #ifndef CONFIG_P9_VPO_COMPILE |