summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndre Marin <aamarin@us.ibm.com>2017-09-13 11:55:38 -0500
committerDaniel M. Crowell <dcrowell@us.ibm.com>2018-03-02 09:05:21 -0500
commitb6de6f7655dfbdb3f76ae9eec5060b62becb1e5b (patch)
treed9f989a531e228ecc4c942871b38c1295d22c912
parente1e78b687d15a2ead6890a30e7a3f54c2ceb51a3 (diff)
downloadtalos-hostboot-b6de6f7655dfbdb3f76ae9eec5060b62becb1e5b.tar.gz
talos-hostboot-b6de6f7655dfbdb3f76ae9eec5060b62becb1e5b.zip
Split SPD Connector to SDRAM fields, add unit tests
Change-Id: Ifcaa44886781c34fe56a7a4ff05268c682e95c59 Original-Change-Id: Ifaa79b70368c41789a199db78de2fa4e40768922 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46217 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54761 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
-rw-r--r--src/import/generic/memory/lib/spd/common/spd_decoder_base.H19
1 files changed, 15 insertions, 4 deletions
diff --git a/src/import/generic/memory/lib/spd/common/spd_decoder_base.H b/src/import/generic/memory/lib/spd/common/spd_decoder_base.H
index 34caf840a..38949efce 100644
--- a/src/import/generic/memory/lib/spd/common/spd_decoder_base.H
+++ b/src/import/generic/memory/lib/spd/common/spd_decoder_base.H
@@ -674,11 +674,22 @@ class decoder
}
///
- /// @brief Decodes connector to SDRAM bit mapping
- /// @param[out] o_value vector of bit nibble maps for SPD bytes 60 - 77
- /// @return FAPI2_RC_SUCCESS if okay
+ /// @brief Decodes Package Rank Map
+ /// @param[out] o_value vector of package rank maps for SPD bytes 60 - 77
+ /// @return FAPI2_RC_SUCCESS iff okay
+ ///
+ virtual fapi2::ReturnCode package_rank_map( std::vector<uint8_t>& o_value ) const
+ {
+ o_value.clear();
+ return fapi2::FAPI2_RC_SUCCESS;
+ }
+
+ ///
+ /// @brief Decodes Nibble Map
+ /// @param[out] o_value vector of nibble map encoding for SPD bytes 60 - 77
+ /// @return FAPI2_RC_SUCCESS iff okay
///
- virtual fapi2::ReturnCode connector_to_sdram( std::vector<uint8_t>& o_value ) const
+ virtual fapi2::ReturnCode nibble_map( std::vector<uint8_t>& o_value ) const
{
o_value.clear();
return fapi2::FAPI2_RC_SUCCESS;
OpenPOWER on IntegriCloud