Fixing a bunch of orphaned TODO comments

Change-Id: Ia7c4dfcc947bebfc26952a9788ef0443372c9c23
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/32203
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <v2cibmd@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

9 files changed, 21 insertions, 65 deletions

diff --git a/src/usr/isteps/istep06/thread_activate/thread_activate.C b/src/usr/isteps/istep06/thread_activate/thread_activate.C
index df2b63ea0..9a722a7ce 100644
--- a/src/usr/isteps/istep06/thread_activate/thread_activate.C
+++ b/src/usr/isteps/istep06/thread_activate/thread_activate.C
@@ -198,11 +198,6 @@ bool getCacheDeconfig(uint64_t i_masterCoreId)
 
     if(NULL != l_errl)
     {
-        // We may not be able to run with only 4MB
-        // in the long run so need to revist this after
-        // we no longer have to deal with parital good
-        // bringup chips.  TODO: RTC: 60620
-
         //Not worth taking the system down, just assume
         //we only have half the cache available.
         errlCommit(l_errl,ISTEP_COMP_ID);
diff --git a/src/usr/isteps/istep11/call_host_prd_hwreconfig.C b/src/usr/isteps/istep11/call_host_prd_hwreconfig.C
index 0cdc9a056..13d6c5e1f 100644
--- a/src/usr/isteps/istep11/call_host_prd_hwreconfig.C
+++ b/src/usr/isteps/istep11/call_host_prd_hwreconfig.C
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2015                             */
+/* Contributors Listed Below - COPYRIGHT 2015,2016                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -31,8 +31,8 @@ namespace ISTEP_11
 void* call_host_prd_hwreconfig (void *io_pArgs)
 {
     errlHndl_t l_err = NULL;
-    //@TODO call p9_switch_cfsim.C HWP
-    //@TODO call p9_enable_reconfig.C
+    //@TODO-RTC:158411 call p9_switch_cfsim.C HWP
+    //@TODO-RTC:158411 call p9_enable_reconfig.C
     return l_err;
 }
 
diff --git a/src/usr/isteps/istep12/call_mss_getecid.C b/src/usr/isteps/istep12/call_mss_getecid.C
index 2ec3db40b..02cd08b27 100644
--- a/src/usr/isteps/istep12/call_mss_getecid.C
+++ b/src/usr/isteps/istep12/call_mss_getecid.C
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2015                             */
+/* Contributors Listed Below - COPYRIGHT 2015,2016                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -45,7 +45,7 @@ void* call_mss_getecid (void *io_pArgs)
 {
     IStepError l_StepError;
     /*
-    //@TODO RTC:133831
+    //@TODO RTC:144076-Centaur L1 HWP support
     errlHndl_t l_err = NULL;
     uint8_t    l_ddr_port_status = 0;
     uint8_t    l_cache_enable = 0;
diff --git a/src/usr/isteps/istep13/call_mss_draminit_trainadv.C b/src/usr/isteps/istep13/call_mss_draminit_trainadv.C
index 27256a7af..9e3d5bb28 100644
--- a/src/usr/isteps/istep13/call_mss_draminit_trainadv.C
+++ b/src/usr/isteps/istep13/call_mss_draminit_trainadv.C
@@ -66,7 +66,7 @@ void* call_mss_draminit_trainadv (void *io_pArgs)
         const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>
           l_fapi_mbcbist_target( l_mcbist_target);
 
-//@TODO RTC:152210 Enable Istep 13 HWPs that are waiting on mirrored files
+        // PLACEHOLDER - HWP may not actually be required
         //  call the HWP with each fapi::Target
 //         FAPI_INVOKE_HWP(l_err, mss_draminit_training_advanced,
 //                        l_fapi_mbcbist_target);
diff --git a/src/usr/isteps/istep14/call_mss_power_cleanup.C b/src/usr/isteps/istep14/call_mss_power_cleanup.C
index 562f71fc5..daa6cff06 100644
--- a/src/usr/isteps/istep14/call_mss_power_cleanup.C
+++ b/src/usr/isteps/istep14/call_mss_power_cleanup.C
@@ -144,7 +144,7 @@ void* call_mss_power_cleanup (void *io_pArgs)
                         l_currMBA0Huid, l_currMBA1Huid);
 
         // Create FAPI Targets.
-        // @TODO RTC:133831
+        // @TODO RTC:155020
         /*const fapi::Target l_fapiCentaurTarget(TARGET_TYPE_MEMBUF_CHIP,
                 (const_cast<TARGETING::Target*>(l_pCentaur)));
         const fapi::Target l_fapiMba0Target(TARGET_TYPE_MBA_CHIPLET,
diff --git a/src/usr/isteps/istep14/call_proc_exit_cache_contained.C b/src/usr/isteps/istep14/call_proc_exit_cache_contained.C
index 9ba289ecb..e44c0732e 100644
--- a/src/usr/isteps/istep14/call_proc_exit_cache_contained.C
+++ b/src/usr/isteps/istep14/call_proc_exit_cache_contained.C
@@ -46,14 +46,9 @@
 #include <sys/mm.h>
 #include <arch/pirformat.H>
 #include <isteps/hwpf_reasoncodes.H>
-
-// @TODO RTC:134082 remove below block
-// Add P9 - Fake trigger for memory expansion
-#include <kernel/console.H>                  // printk status
 #include <devicefw/userif.H>
 #include <config.h>
 #include <util/misc.H>
-// @TODO RTC:134082 remove above block
 
 using   namespace   ISTEP;
 using   namespace   ISTEP_ERROR;
diff --git a/src/usr/isteps/istep15/makefile b/src/usr/isteps/istep15/makefile
index 2c2d5f9bf..0079231db 100644
--- a/src/usr/isteps/istep15/makefile
+++ b/src/usr/isteps/istep15/makefile
@@ -44,9 +44,6 @@ OBJS += proc_set_pba_homer_bar.o
 OBJS += host_establish_ex_chiplet.o
 OBJS += host_start_stop_engine.o
 
-#@TODO RTC:147621 Pull p9_stop_util into a seperate library
-OBJS += p9_stop_util.o
-
 
 include ${ROOTPATH}/procedure.rules.mk
 include $(PROCEDURES_PATH)/hwp/pm/p9_pm_pfet_init.mk
diff --git a/src/usr/isteps/istep21/call_host_runtime_setup.C b/src/usr/isteps/istep21/call_host_runtime_setup.C
index 7ec5f883e..66497d94b 100644
--- a/src/usr/isteps/istep21/call_host_runtime_setup.C
+++ b/src/usr/isteps/istep21/call_host_runtime_setup.C
@@ -35,7 +35,7 @@
 #include <devtree/devtreeif.H>
 #include <runtime/customize_attrs_for_payload.H>
 #include <targeting/common/util.H>
-
+#include <vpd/vpd_if.H>
 
 #include <hbotcompid.H>
 
@@ -106,15 +106,14 @@ void* call_host_runtime_setup (void *io_pArgs)
         } // end if phyp load
 
 
-        //@TODO RTC:133848
-/*
-        bool l_activateOCC = is_avp_load();
+        bool l_activateOCC = TARGETING::is_avp_load();
 
 #ifdef CONFIG_START_OCC_DURING_BOOT
         l_activateOCC = true;
 #endif
         if(l_activateOCC)
         {
+#if 0 //@TODO-RTC:159931-Start OCC during boot
             l_err = HBOCC::activateOCCs();
             if (l_err)
             {
@@ -122,7 +121,10 @@ void* call_host_runtime_setup (void *io_pArgs)
                        "activateOCCs failed");
                 break;
             }
+#endif
         }
+
+#if 0 //@TODO-RTC:164022-Support max pstate without OCC
 #ifdef CONFIG_SET_NOMINAL_PSTATE
         // Speed up processors.
         l_err = setMaxPstate();
@@ -132,8 +134,10 @@ void* call_host_runtime_setup (void *io_pArgs)
             ERRORLOG::errlCommit(l_err, ISTEP_COMP_ID);
         }
 #endif
+#endif
 
-        if( is_sapphire_load() && (!INITSERVICE::spBaseServicesEnabled()) )
+        if( TARGETING::is_sapphire_load()
+            && (!INITSERVICE::spBaseServicesEnabled()) )
         {
             // Update the VPD switches for golden side boot
             // Must do this before building the devtree
@@ -164,7 +168,7 @@ void* call_host_runtime_setup (void *io_pArgs)
             }
 
         }
-        else if( is_sapphire_load() )
+        else if( TARGETING::is_sapphire_load() )
         {
             // Find area in HDAT to load devtree.
             uint64_t l_dtAddr = 0;
@@ -189,15 +193,8 @@ void* call_host_runtime_setup (void *io_pArgs)
             }
 
         }
-        else if( is_phyp_load() )
+        else if( TARGETING::is_phyp_load() )
         {
-            //If PHYP then clear out the PORE BARs
-            l_err = clearPoreBars();
-            if( l_err )
-            {
-                break;
-            }
-
             //Update the MDRT value (for MS Dump)
             l_err = RUNTIME::writeActualCount(RUNTIME::MS_DUMP_RESULTS_TBL);
             if(l_err != NULL)
@@ -206,31 +203,9 @@ void* call_host_runtime_setup (void *io_pArgs)
                            "write_MDRT_Count failed" );
                 break;
             }
-
-            // Write the HostServices attributes into mainstore
-            l_err = RUNTIME::populate_attributes();
-            if ( l_err )
-            {
-                TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-                           "Could not populate attributes" );
-                // break from do loop if error occured
-                break;
-            }
-        }
-        else if( !is_avp_load() )
-        {
-            // Write the HostServices attributes into mainstore
-            //  for our testcases
-            l_err = RUNTIME::populate_attributes();
-            if ( l_err )
-            {
-                TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
-                           "Could not populate attributes" );
-                // break from do loop if error occured
-                break;
-            }
         }
 
+#if 0 //@TODO-RTC:147565-Core checkstop escalation
         // Revert back to standard runtime mode where core checkstops
         //  do not escalate to system checkstops
         // Workaround for HW286670
@@ -239,9 +214,8 @@ void* call_host_runtime_setup (void *io_pArgs)
         {
             break;
         }
+#endif
 
-        //  - Update HDAT/DEVTREE with tpmd logs
-*/
     } while(0);
 
     if( l_err )
diff --git a/src/usr/isteps/istep21/call_host_verify_hdat.C b/src/usr/isteps/istep21/call_host_verify_hdat.C
index 6a14ce794..0945f241b 100644
--- a/src/usr/isteps/istep21/call_host_verify_hdat.C
+++ b/src/usr/isteps/istep21/call_host_verify_hdat.C
@@ -46,12 +46,7 @@ void* call_host_verify_hdat (void *io_pArgs)
 
     errlHndl_t l_err = NULL;
 
-    // Host Start Payload procedure, per documentation from Patrick.
-    //  - Verify target image
-    //      - TODO - Done via call to Secure Boot ROM.
-    //      - Will be done in future sprints
-
-    // stub for now..
+    //@TODO-RTC:125313-Audit HDAT Contents
 
     TRACDCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
                "call_host_verify_hdat exit" );