diff options
| author | Brian Bakke <bbakke@us.ibm.com> | 2018-04-23 13:40:06 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-05-02 16:01:47 -0400 |
| commit | 9add45f9ebcec629c99d462cca1d755090ff4157 (patch) | |
| tree | a0f4b1479c251c20ee372692021abaad1f8c7115 | |
| parent | 02e6f289e1f8b16e1d7fcc6bb5424662e9a3c951 (diff) | |
| download | talos-hostboot-9add45f9ebcec629c99d462cca1d755090ff4157.tar.gz talos-hostboot-9add45f9ebcec629c99d462cca1d755090ff4157.zip | |
Log an error when FAPI Attribute Overrides are attempted
Attribute Overrides from FAPI tank are ignored as the Target Type
is defaulted in the call tree and thus Attributes for FAPI
Targets are never extracted.
Add a error log if FAPI Attributes are ingested so there
is an indication that these are not supported rather than
throwing them silently on the floor.
Change-Id: I595e07b03df4d093d7f91b0a8513a8d94c9844dc
RTC:177224
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57683
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian E. Bakke <bbakke@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/include/usr/targeting/common/targreasoncodes.H | 1 | ||||
| -rw-r--r-- | src/usr/targeting/attrPlatOverride.C | 35 |
2 files changed, 36 insertions, 0 deletions
diff --git a/src/include/usr/targeting/common/targreasoncodes.H b/src/include/usr/targeting/common/targreasoncodes.H index fb2f9026c..411d686cb 100644 --- a/src/include/usr/targeting/common/targreasoncodes.H +++ b/src/include/usr/targeting/common/targreasoncodes.H @@ -78,6 +78,7 @@ enum TargetingReasonCode TARG_RC_ATTRIBUTE_ENUM_CHECK_FAIL = TARG_COMP_ID | 0x16, TARG_RC_ATTRIBUTE_RANGE_CHECK_FAIL = TARG_COMP_ID | 0x17, TARG_RC_CONCURRENT_CODE_UPDATE_FAIL = TARG_COMP_ID | 0x18, + TARG_RC_ATTR_OVER_FAPI_TANK_NOT_SUPPORTED = TARG_COMP_ID | 0x19, }; }; // End TARGETING namespace diff --git a/src/usr/targeting/attrPlatOverride.C b/src/usr/targeting/attrPlatOverride.C index 3347cf60c..7e1025d40 100644 --- a/src/usr/targeting/attrPlatOverride.C +++ b/src/usr/targeting/attrPlatOverride.C @@ -237,6 +237,41 @@ errlHndl_t getAttrOverrides(PNOR::SectionInfo_t &i_sectionInfo, // Deserialize the data with the approriate AttributeTank l_ptank->deserializeAttributes(l_chunk, true); + + // The extraction of FAPI Tank Override Attributes is + // not supported. Note it here at ingestion so no + // silent fail later + if ( l_pAttrOverSec->iv_layer == + AttributeTank::TANK_LAYER_FAPI ) + { + TRACFCOMP(g_trac_targeting, + "getAttrOverrides: " + "FAPI Tank Layer Not Supported"); + /*@ + * @errortype + * @moduleid TARG_GET_ATTR_OVER + * @reasoncode TARG_RC_ATTR_OVER_FAPI_TANK_NOT_SUPPORTED + * @userdata1 Tank Layer of attribute + * @userdata2 PNOR Section specified + * @devdesc Attribute override is in the FAPI Tank + * which is not supported + * @custdesc Unsupported override configuration data + */ + l_err = + new ERRORLOG::ErrlEntry + (ERRORLOG::ERRL_SEV_UNRECOVERABLE, + TARG_GET_ATTR_OVER, + TARG_RC_ATTR_OVER_FAPI_TANK_NOT_SUPPORTED, + l_pAttrOverSec->iv_layer, + i_sectionInfo.id); + l_err->collectTrace("TARG",256); + l_err->addProcedureCallout(HWAS::EPUB_PRC_SP_CODE, + HWAS::SRCI_PRIORITY_HIGH); + ERRORLOG::errlCommit(l_err, TARG_COMP_ID); + } + + + } l_index += l_pAttrOverSec->iv_size; } |
