diff options
| author | Caleb Palmer <cnpalmer@us.ibm.com> | 2019-03-15 12:05:15 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-03-20 09:06:27 -0500 |
| commit | 6d28e5b524f23fb473a6eff52b37f08fbafaf641 (patch) | |
| tree | 0abe6bae9f1dc10370a02149302a7a72960af566 | |
| parent | 86b0576b22dcb146241d377b9f861a8c09031172 (diff) | |
| download | talos-hostboot-6d28e5b524f23fb473a6eff52b37f08fbafaf641.tar.gz talos-hostboot-6d28e5b524f23fb473a6eff52b37f08fbafaf641.zip | |
PRD: Remove EccSp from errl when not avail
Change-Id: Ib57dc550fc71ba12e4cf98a7e3eaae5745ec3594
CQ: SW458138
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/73427
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamen G. Tyner <ben.tyner@ibm.com>
Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/74683
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/usr/diag/prdf/common/plat/mem/prdfMemCaptureData.C | 3 | ||||
| -rwxr-xr-x | src/usr/diag/prdf/common/plugins/prdfDramRepairUsrData.H | 8 | ||||
| -rw-r--r-- | src/usr/diag/prdf/common/plugins/prdfMemLogParse.C | 2 |
3 files changed, 7 insertions, 6 deletions
diff --git a/src/usr/diag/prdf/common/plat/mem/prdfMemCaptureData.C b/src/usr/diag/prdf/common/plat/mem/prdfMemCaptureData.C index c193cf1f2..7ca8c1e86 100644 --- a/src/usr/diag/prdf/common/plat/mem/prdfMemCaptureData.C +++ b/src/usr/diag/prdf/common/plat/mem/prdfMemCaptureData.C @@ -216,7 +216,8 @@ void captureDramRepairsData( TARGETING::TargetHandle_t i_trgt, if ( data.rankDataList.size() > 0 ) { data.header.rankCount = data.rankDataList.size(); - data.header.isX4Dram = isDramWidthX4( i_trgt ); + data.header.isEccSp = (isDramWidthX4( i_trgt ) && + !(TYPE_MCA != getTargetType(i_trgt))); UtilMem dramStream; dramStream << data; diff --git a/src/usr/diag/prdf/common/plugins/prdfDramRepairUsrData.H b/src/usr/diag/prdf/common/plugins/prdfDramRepairUsrData.H index 6d80a9a87..9bb135e95 100755 --- a/src/usr/diag/prdf/common/plugins/prdfDramRepairUsrData.H +++ b/src/usr/diag/prdf/common/plugins/prdfDramRepairUsrData.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2013,2017 */ +/* Contributors Listed Below - COPYRIGHT 2013,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -50,7 +50,7 @@ namespace FSP struct DramRepairDataHdr { uint8_t rankCount : 4; // Number of ranks with DRAM Repair data - uint8_t isX4Dram : 1; // Is this mba connected in x4 mode + uint8_t isEccSp : 1; // Is ecc spare available for use. uint8_t isSpareDram : 1; // Is spare DRAM supported on DIMMS attached // to this MBA. uint8_t reserved : 2; // Future use @@ -67,7 +67,7 @@ struct DramRepairDataHdr DramRepairDataHdr& i_right ) { i_left << ( uint8_t )(i_right.rankCount << 4 - | i_right.isX4Dram << 3 + | i_right.isEccSp << 3 | i_right.isSpareDram << 2 | i_right.reserved ) << i_right.wiringType; @@ -87,7 +87,7 @@ struct DramRepairDataHdr i_left >> temp >> i_right.wiringType; i_right.rankCount = temp >> 4; - i_right.isX4Dram = temp >> 3; + i_right.isEccSp = temp >> 3; i_right.isSpareDram = temp >> 2; i_right.reserved = temp; diff --git a/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C b/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C index 014788a11..390178f6e 100644 --- a/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C +++ b/src/usr/diag/prdf/common/plugins/prdfMemLogParse.C @@ -3330,7 +3330,7 @@ bool parseDramRepairsData( uint8_t * i_buffer, uint32_t i_buflen, } // Display ECC spare information for X4 DRAMs - if ( usrData.header.isX4Dram ) + if ( usrData.header.isEccSp ) { getDramRepairSymbolStr( rankEntry.eccSpare, symbolStr, 10 ); snprintf(temp, 64, "%s EccSp: %s", data, symbolStr); |
