diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2018-07-10 12:03:14 -0500 |
|---|---|---|
| committer | William G. Hoffa <wghoffa@us.ibm.com> | 2018-07-18 10:21:45 -0400 |
| commit | 5b97e1cba5e1343aa0778f523037eedfd67fdc8f (patch) | |
| tree | 3275a50c5a44297ea6f09a1f442b4c2b4a4a6f61 | |
| parent | 5be875d40b41d212d02a03643cb4be8fedd6ba5e (diff) | |
| download | talos-hostboot-5b97e1cba5e1343aa0778f523037eedfd67fdc8f.tar.gz talos-hostboot-5b97e1cba5e1343aa0778f523037eedfd67fdc8f.zip | |
Re-enable p9c_mss_draminit_training_advanced
VPD updates should be in place so we are enabling the function
call again.
Removing the security check for Centaur reg 030106DB.
Change-Id: I2a67de4844e29ffb79e083bbcd800db62c096ccd
CMVC-Prereq: 1059608
CMVC-Prereq: 1062188
CQ: SW437498
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62544
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
| -rw-r--r-- | src/import/chips/p9/security/Centaur_Register_List.csv | 1 | ||||
| -rw-r--r-- | src/usr/isteps/istep13/call_mss_draminit_trainadv.C | 17 |
2 files changed, 10 insertions, 8 deletions
diff --git a/src/import/chips/p9/security/Centaur_Register_List.csv b/src/import/chips/p9/security/Centaur_Register_List.csv index 0e8f96a40..dbaf282cd 100644 --- a/src/import/chips/p9/security/Centaur_Register_List.csv +++ b/src/import/chips/p9/security/Centaur_Register_List.csv @@ -109,7 +109,6 @@ 30106C5,,,,, 30106C6,,,,, 30106C7,,,,, -30106DB,,,,, 3012300,,,0000A00000000000,, 301230B,,,,, 3030000,,,,, diff --git a/src/usr/isteps/istep13/call_mss_draminit_trainadv.C b/src/usr/isteps/istep13/call_mss_draminit_trainadv.C index 6ba7c4bf3..dc75e728b 100644 --- a/src/usr/isteps/istep13/call_mss_draminit_trainadv.C +++ b/src/usr/isteps/istep13/call_mss_draminit_trainadv.C @@ -33,6 +33,7 @@ #include <targeting/common/util.H> #include <targeting/common/utilFilter.H> #include "istep13consts.H" +#include <util/misc.H> #include <fapi2.H> #include <fapi2/plat_hwp_invoker.H> @@ -91,7 +92,14 @@ void* call_mss_draminit_trainadv (void *io_pArgs) "SUCCESS : p9_mss_draminit_trainingadv HWP( )" ); } - if(l_stepError.getErrorHandle() == NULL) + // This step takes an obscene amount of time to run in Simics, + // going to skip it for now + if( Util::isSimicsRunning() ) + { + TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, + "Skipping p9c_mss_draminit_training_advanced HWP in Simics"); + } + else if(l_stepError.getErrorHandle() == NULL) { // Get all Centaur targets TARGETING::TargetHandleList l_membufTargetList; @@ -118,7 +126,6 @@ void* call_mss_draminit_trainadv (void *io_pArgs) // Make a local copy of the target for ease of use TARGETING::Target* l_mbaTarget = *l_mba_iter; -#if 0 //TODO CQ:SW430659 re-enable when VPD supports // Dump current run on target TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, "Running p9c_mss_draminit_training_advanced HWP on " @@ -128,11 +135,7 @@ void* call_mss_draminit_trainadv (void *io_pArgs) fapi2::Target <fapi2::TARGET_TYPE_MBA_CHIPLET> l_fapi_mba_target(l_mbaTarget); FAPI_INVOKE_HWP(l_err, p9c_mss_draminit_training_advanced, l_fapi_mba_target); -#else - TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace, - "SKIPPING p9c_mss_draminit_training_advanced HWP on " - "target HUID %.8X till VPD ready", TARGETING::get_huid(l_mbaTarget)); -#endif + // process return code. if ( l_err ) { |
