diff options
author | Dan Crowell <dcrowell@us.ibm.com> | 2018-07-23 11:32:57 -0500 |
---|---|---|
committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-07-24 11:20:40 -0500 |
commit | 53d16c247e6762cc7a48ffe31b73b394ef052923 (patch) | |
tree | 798f569c81fd1bfd043e967f8efb65757a388924 | |
parent | 331b4bff6cb94d3578243089c2adcf3908058d63 (diff) | |
download | talos-hostboot-53d16c247e6762cc7a48ffe31b73b394ef052923.tar.gz talos-hostboot-53d16c247e6762cc7a48ffe31b73b394ef052923.zip |
Fix symsmode check to allow in-memory lookup
Switched the default value from empty string to 'default' and
fix the associated checks.
Change-Id: If8379ad02854fd46b800e5dbfdfef41558ee745e
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63154
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
-rwxr-xr-x | src/build/debug/Hostboot/_DebugFramework.pm | 5 | ||||
-rwxr-xr-x | src/build/debug/ecmd-debug-framework.pl | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/src/build/debug/Hostboot/_DebugFramework.pm b/src/build/debug/Hostboot/_DebugFramework.pm index 4977eedeb..46261f6e0 100755 --- a/src/build/debug/Hostboot/_DebugFramework.pm +++ b/src/build/debug/Hostboot/_DebugFramework.pm @@ -502,12 +502,13 @@ sub findPointer my $size; my $symsmode = ::getSymsMode(); - if( ($symsmode =~ "") || ($symsmode =~ "usemem") ) + + if( ($symsmode =~ "default") || ($symsmode =~ "usemem") ) { ($addr, $size ) = findDebugPointer( $dbgptrstr ); } - if( (($symsmode =~ "") && (not defined $addr)) + if( (($symsmode =~ "default") && (not defined $addr)) || ($symsmode =~ "usefile") ) { #::userDisplay( "*Using Symbol File*\n" ); diff --git a/src/build/debug/ecmd-debug-framework.pl b/src/build/debug/ecmd-debug-framework.pl index cbdbbad83..791d8fcd0 100755 --- a/src/build/debug/ecmd-debug-framework.pl +++ b/src/build/debug/ecmd-debug-framework.pl @@ -70,7 +70,7 @@ if (not $self) # "" : Default - Try to use memory, fall-back to symbol files # "usefile" : Only use the symbol files # "usemem" : Only use the data from memory -my $useSymsMode = ""; +my $useSymsMode = "default"; GetOptions("tool:s" => \$tool, "tool-options:s" => \$toolOptions, |