diff options
| author | Ilya Smirnov <ismirno@us.ibm.com> | 2019-04-12 14:14:18 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-04-16 14:45:44 -0500 |
| commit | 4f0694a7bc3f529b6746e3b824def8c48e2af4b4 (patch) | |
| tree | 94f43161819ca1bd4c509da88d91e779c51c5867 | |
| parent | 8578705fa8a20463a44b36059b66083db12f5d5d (diff) | |
| download | talos-hostboot-4f0694a7bc3f529b6746e3b824def8c48e2af4b4.tar.gz talos-hostboot-4f0694a7bc3f529b6746e3b824def8c48e2af4b4.zip | |
Remove Redundant LPC Bus Check
Current implementation of lpcWrite contains a check for errors
on LPC bus before the attempt to writeLPC, and writeLPC is not
attempted if an error is found on the bus. However, the error
check performs bus reset, and the same check is performed in
writeLPC with the difference that the lpcWrite is still attempted
after the bus reset, and only if the write fails is the error
returned.
This commit removes the first check for LPC errors to give lpcWrite
a chance to run after the LPC bus reset due to errors.
Change-Id: I6375e6575f771e33bd3b866534eb3cd8656d38d8
CQ: SW455075
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75931
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/usr/lpc/lpcdd.C | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/src/usr/lpc/lpcdd.C b/src/usr/lpc/lpcdd.C index a661bb7f0..c5691d7b9 100644 --- a/src/usr/lpc/lpcdd.C +++ b/src/usr/lpc/lpcdd.C @@ -200,15 +200,10 @@ errlHndl_t lpcWrite(DeviceFW::OperationType i_opType, // then we have to use our special side copy of the driver if( i_target == TARGETING::MASTER_PROCESSOR_CHIP_TARGET_SENTINEL ) { - //First check/clear the LPC bus of errors and commit any errors found - l_err = Singleton<LpcDD>::instance().checkForLpcErrors(); - if (!l_err) - { - l_err = Singleton<LpcDD>::instance().writeLPC( l_type, - l_addr, - io_buffer, - io_buflen ); - } + l_err = Singleton<LpcDD>::instance().writeLPC(l_type, + l_addr, + io_buffer, + io_buflen); } else { |
