diff options
| author | Rick Ward <rward15@us.ibm.com> | 2018-07-06 10:58:47 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-01-14 10:20:29 -0600 |
| commit | 2d410b67952a0a4e0f09fc8e25a746edf3b0cbb1 (patch) | |
| tree | b5880c033921a442dadf76852a711b785f6d075c | |
| parent | 37132b70227cde9f5896268a264b13e74703cf3d (diff) | |
| download | talos-hostboot-2d410b67952a0a4e0f09fc8e25a746edf3b0cbb1.tar.gz talos-hostboot-2d410b67952a0a4e0f09fc8e25a746edf3b0cbb1.zip | |
Cleanup minor code review nits from SW433868.
Change-Id: I595fdcecaa08830514dacd81255bc0e9af222b40
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/61964
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/include/usr/sbeio/sbe_psudd.H | 2 | ||||
| -rw-r--r-- | src/usr/sbeio/sbe_psudd.C | 10 |
2 files changed, 3 insertions, 9 deletions
diff --git a/src/include/usr/sbeio/sbe_psudd.H b/src/include/usr/sbeio/sbe_psudd.H index 03b07951c..8c56b2a8d 100644 --- a/src/include/usr/sbeio/sbe_psudd.H +++ b/src/include/usr/sbeio/sbe_psudd.H @@ -649,7 +649,7 @@ class SbePsu * function will record the error state so it can be reported later. * * - * @param[in] i_plid Program log id for the error + * @param[in] i_plid Platform log id for the error * @param[in] i_target Proc target for PSU Request that caused an error */ void saveEarlyError(uint32_t i_plid,TARGETING::TargetHandle_t i_target); diff --git a/src/usr/sbeio/sbe_psudd.C b/src/usr/sbeio/sbe_psudd.C index eb693c957..7538f3517 100644 --- a/src/usr/sbeio/sbe_psudd.C +++ b/src/usr/sbeio/sbe_psudd.C @@ -59,7 +59,7 @@ trace_desc_t* g_trac_sbeio; TRAC_INIT(&g_trac_sbeio, SBEIO_COMP_NAME, 6*KILOBYTE, TRACE::BUFFER_SLOW); -// used to uniquley identify the SBE PSU message queue +// used to uniquely identify the SBE PSU message queue const char* SBE_PSU_MSG_Q = "sbepsuq"; #define SBE_TRACF(printf_string,args...) \ @@ -332,12 +332,6 @@ errlHndl_t SbePsu::performPsuChipOp(TARGETING::Target * i_target, /** * @brief record info from an "early" error so it can be reported later - * - * If an error occurs before the fapi2 library is loaded, this function - * can be used to record the details for later reporting. - * - * @param[in] i_plid Program log id for the error - * @param[in] i_target Proc target for PSU Request that caused error */ void SbePsu::saveEarlyError(uint32_t i_plid, TARGETING::TargetHandle_t i_target) { @@ -347,7 +341,7 @@ void SbePsu::saveEarlyError(uint32_t i_plid, TARGETING::TargetHandle_t i_target) iv_earlyErrorPlid = i_plid; iv_earlyErrorTarget = i_target; - SBE_TRACD(ENTER_MRK "saveEarlyError"); + SBE_TRACD(EXIT_MRK "saveEarlyError"); } /** |
