diff options
| author | Dan Crowell <dcrowell@us.ibm.com> | 2016-06-06 11:40:29 -0500 |
|---|---|---|
| committer | Matthew A. Ploetz <maploetz@us.ibm.com> | 2016-06-15 09:22:51 -0400 |
| commit | 2be22a7dde9786eeb01f2f86b7b8ad1279423be5 (patch) | |
| tree | cfa90eed54dfc5ddacf98bb370c73f9e27272582 | |
| parent | 1107721b8a869ce5f1b93ac0b20296209a99ef85 (diff) | |
| download | talos-hostboot-2be22a7dde9786eeb01f2f86b7b8ad1279423be5.tar.gz talos-hostboot-2be22a7dde9786eeb01f2f86b7b8ad1279423be5.zip | |
Collect FAPI traces for all FAPI_INVOKE_HWP calls
Automatically add the FAPI and FAPI_I traces to all error logs
that result from a HWP invocation.
Change-Id: Id91df9ca29574669410d0a5b8053cacf3a9ec754
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/25411
Tested-by: Jenkins Server
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Tested-by: FSP CI Jenkins
Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com>
Reviewed-by: Matthew A. Ploetz <maploetz@us.ibm.com>
| -rw-r--r-- | src/include/usr/fapi2/plat_hwp_invoker.H | 10 | ||||
| -rw-r--r-- | src/usr/isteps/istep06/thread_activate/thread_activate.C | 6 |
2 files changed, 7 insertions, 9 deletions
diff --git a/src/include/usr/fapi2/plat_hwp_invoker.H b/src/include/usr/fapi2/plat_hwp_invoker.H index 0d55c3e01..25ef6ccfe 100644 --- a/src/include/usr/fapi2/plat_hwp_invoker.H +++ b/src/include/usr/fapi2/plat_hwp_invoker.H @@ -59,9 +59,13 @@ #define FAPI_INVOKE_HWP(ERRHNDL, FUNC, _args_...) \ {\ - fapi2::ReturnCode l_rc; \ - FAPI_EXEC_HWP(l_rc, FUNC, ##_args_); \ - ERRHNDL = fapi2::rcToErrl(l_rc);\ + fapi2::ReturnCode l_rc; \ + FAPI_EXEC_HWP(l_rc, FUNC, ##_args_); \ + ERRHNDL = fapi2::rcToErrl(l_rc);\ + if( ERRHNDL ) {\ + ERRHNDL->collectTrace(FAPI_IMP_TRACE_NAME,256);\ + ERRHNDL->collectTrace(FAPI_TRACE_NAME,384);\ + }\ } #endif // PLATHWPINVOKER_H_ diff --git a/src/usr/isteps/istep06/thread_activate/thread_activate.C b/src/usr/isteps/istep06/thread_activate/thread_activate.C index 2edd3f71d..1d5d2de14 100644 --- a/src/usr/isteps/istep06/thread_activate/thread_activate.C +++ b/src/usr/isteps/istep06/thread_activate/thread_activate.C @@ -323,9 +323,6 @@ void activate_threads( errlHndl_t& io_rtaskRetErrl ) "ERROR: 0x%.8X : p9_cpu_special_wakeup set HWP(cpu %d)", l_errl->reasonCode(), l_masterCoreID); - - l_errl->collectTrace(FAPI_TRACE_NAME,256); - l_errl->collectTrace(FAPI_IMP_TRACE_NAME,256); break; } @@ -401,9 +398,6 @@ void activate_threads( errlHndl_t& io_rtaskRetErrl ) l_masterCoreID, thread_bitset, l_rasStatus ); - - l_errl->collectTrace(FAPI_TRACE_NAME,256); - l_errl->collectTrace(FAPI_IMP_TRACE_NAME,256); } else { |
