diff options
| author | Brian Silver <bsilver@us.ibm.com> | 2017-01-17 08:52:53 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-01-24 11:09:56 -0500 |
| commit | 2508661759672d71b3a12eccdd2836c192139627 (patch) | |
| tree | 6dba434b48292eea13d3ee0a0ad196cb83439bb2 | |
| parent | faac790c009c1b008772ab9535fa0e57e3b954e4 (diff) | |
| download | talos-hostboot-2508661759672d71b3a12eccdd2836c192139627.tar.gz talos-hostboot-2508661759672d71b3a12eccdd2836c192139627.zip | |
Change MCBIST 1R work around to actually check the pause bits
Change-Id: If74067133ab901ab08860a26f7dc234a2c351c79
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34986
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Dev-Ready: Brian R. Silver <bsilver@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34995
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C b/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C index ff8277d45..81cd342ed 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2016 */ +/* Contributors Listed Below - COPYRIGHT 2016,2017 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -123,7 +123,14 @@ fapi2::ReturnCode end_of_rank( const fapi2::Target<TARGET_TYPE_MCBIST>& i_target return FAPI2_RC_SUCCESS; } - if( ! io_program.iv_config.getBit<TT::MCBIST_CFG_PAUSE_AFTER_RANK>() ) + // Keep in mind that pause-on-error-mode is two bits and it doesn't encode master/slave. The + // end_boundary enums are constructed such that STOP_AFTER_MASTER_RANK is really stop on + // either master or slave for the purposes of this field. So, checking stop-after-master-rank + // will catch both master and slave pauses which is correct for this work-around. + uint64_t l_pause_mode = 0; + io_program.iv_config.extractToRight<TT::CFG_PAUSE_ON_ERROR_MODE, TT::CFG_PAUSE_ON_ERROR_MODE_LEN>(l_pause_mode); + + if( l_pause_mode != mss::mcbist::end_boundary::STOP_AFTER_MASTER_RANK ) { FAPI_INF("not checking rank boundaries on this MCBIST (%s), we're ok", mss::c_str(i_target)); return FAPI2_RC_SUCCESS; |
