Trace message if unable to understand its contents of eeprom cache

While checking if PN/SN has changed for a given part we will lookup
those PN/SN in the eeprom cache. If we are unable to understand the
contents of the eeprom cache then we want to make sure some sort of
message gets out to the user. This would likely happen in bringup or
lab scenario, and there are other logs generated that would lead you
to this code so this trace should suffice.

Change-Id: Id45c6de42ee6792e8d4bbfdc460da371a5bcb99e
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/78504
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

2 files changed, 11 insertions, 1 deletions

diff --git a/src/usr/vpd/ipvpd.C b/src/usr/vpd/ipvpd.C
index 3348c7a54..4459fbfd2 100644
--- a/src/usr/vpd/ipvpd.C
+++ b/src/usr/vpd/ipvpd.C
@@ -356,6 +356,8 @@ errlHndl_t IpVpdFacade::cmpEecacheToEeprom(TARGETING::Target * i_target,
 
         if( l_err || (l_sizeCache == 0) )
         {
+            TRACFCOMP(g_trac_vpd,
+                      "cmpEecacheToEeprom() an error occurred reading the keyword size in cache");
             break;
         }
 
@@ -368,6 +370,8 @@ errlHndl_t IpVpdFacade::cmpEecacheToEeprom(TARGETING::Target * i_target,
 
         if( l_err )
         {
+            TRACFCOMP(g_trac_vpd,
+                      "cmpEecacheToEeprom() an error occurred reading the keyword in cache");
             break;
         }
 
@@ -380,6 +384,8 @@ errlHndl_t IpVpdFacade::cmpEecacheToEeprom(TARGETING::Target * i_target,
 
         if( l_err || (l_sizeHardware == 0) )
         {
+            TRACFCOMP(g_trac_vpd,
+                      "cmpEecacheToEeprom() an error occurred reading the keyword size in hardware");
             break;
         }
 
@@ -392,6 +398,8 @@ errlHndl_t IpVpdFacade::cmpEecacheToEeprom(TARGETING::Target * i_target,
 
         if( l_err )
         {
+            TRACFCOMP(g_trac_vpd,
+                      "cmpEecacheToEeprom() an error occurred reading the keyword in hardware");
             break;
         }
 
diff --git a/src/usr/vpd/spd.C b/src/usr/vpd/spd.C
index 692af5828..afa7417a6 100644
--- a/src/usr/vpd/spd.C
+++ b/src/usr/vpd/spd.C
@@ -2396,7 +2396,9 @@ errlHndl_t cmpEecacheToEeprom(TARGETING::Target * i_target,
 
         if (!isValidDimmType(memTypeCache, i_eepromType))
         {
-            TRACFCOMP(g_trac_spd, ERR_MRK"cmpEecacheToEeprom() Invalid DIMM type found in cache copy of eeprom");
+            TRACFCOMP(g_trac_spd, ERR_MRK
+                     "cmpEecacheToEeprom() Invalid DIMM type found in cache copy of eeprom,"
+                     " we will not be able to understand contents");
             break;
         }