diff options
| author | Claus Michael Olsen <cmolsen@us.ibm.com> | 2017-04-05 05:16:51 -0500 |
|---|---|---|
| committer | Joshua Hunsberger <jahunsbe@us.ibm.com> | 2018-02-01 16:15:29 -0600 |
| commit | 98fe04d0d6524aa02ac5e3132aabcd05dcefe6c5 (patch) | |
| tree | 23385e8f3deabdcc8c879614060a4264f27f153c /import/chips/centaur/utils | |
| parent | b435efadcf4479761807f11e056fa40aeeb807e1 (diff) | |
| download | talos-hcode-98fe04d0d6524aa02ac5e3132aabcd05dcefe6c5.tar.gz talos-hcode-98fe04d0d6524aa02ac5e3132aabcd05dcefe6c5.zip | |
Code restruct: TOR API
Key_Cronus_Test=XIP_REGRESS
Code restructuring aiming at:
- utilizing TOR magic header info
- enforce a common approach for
- extracting metadata for all image,chipType combinations
- traversing images for all image,chipType combinations
- shrinking code size by reusing common code segments
- improve readability by
- separating more clearly metadata extraction and image traversal
- slight rearrange of certain code segments
- remove leftover hardcoded assumptions about ring/TOR data and structs
- variables appropriately renamed and now all using camel style
Change-Id: I50ace8b2fdb340a97ce6d74ce545c5e1acd21c40
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38863
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: GIRISANKAR PAULRAJ <gpaulraj@in.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Diffstat (limited to 'import/chips/centaur/utils')
| -rw-r--r-- | import/chips/centaur/utils/imageProcs/cen_ringId.C | 4 | ||||
| -rw-r--r-- | import/chips/centaur/utils/imageProcs/cen_ringId.H | 8 |
2 files changed, 5 insertions, 7 deletions
diff --git a/import/chips/centaur/utils/imageProcs/cen_ringId.C b/import/chips/centaur/utils/imageProcs/cen_ringId.C index 83b9fd5c..739598c9 100644 --- a/import/chips/centaur/utils/imageProcs/cen_ringId.C +++ b/import/chips/centaur/utils/imageProcs/cen_ringId.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HCODE Project */ /* */ -/* COPYRIGHT 2016,2017 */ +/* COPYRIGHT 2016,2018 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -181,7 +181,7 @@ void CEN_RID::ringid_get_chiplet_properties( } } -GenRingIdList* CEN_RID::ringid_get_ring_properties(RingId_t i_ringId) +GenRingIdList* CEN_RID::ringid_get_ring_list(RingId_t i_ringId) { ChipletData_t* l_cpltData; GenRingIdList* l_ringList[2]; // 0: common, 1: instance diff --git a/import/chips/centaur/utils/imageProcs/cen_ringId.H b/import/chips/centaur/utils/imageProcs/cen_ringId.H index ac1c84de..2bede9cf 100644 --- a/import/chips/centaur/utils/imageProcs/cen_ringId.H +++ b/import/chips/centaur/utils/imageProcs/cen_ringId.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HCODE Project */ /* */ -/* COPYRIGHT 2016,2017 */ +/* COPYRIGHT 2016,2018 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -380,8 +380,7 @@ static const RingProperties_t RING_PROPERTIES[NUM_RING_IDS] = // returns our own chiplet enum value for this ringId ChipletType_t -ringid_get_chiplet( - RingId_t i_ringId); +ringid_get_chiplet(RingId_t i_ringId); // returns data structures defined for chiplet type // as determined by ringId @@ -396,8 +395,7 @@ ringid_get_chiplet_properties( // returns properties of a ring as determined by ringId GenRingIdList* -ringid_get_ring_properties( - RingId_t i_ringId); +ringid_get_ring_list(RingId_t i_ringId); #endif // _CEN_RINGID_H_ |
