diff options
| author | Yue Du <daviddu@us.ibm.com> | 2017-02-16 16:49:55 -0600 |
|---|---|---|
| committer | Joshua Hunsberger <jahunsbe@us.ibm.com> | 2017-10-23 17:09:28 -0500 |
| commit | f3107eab4e66527f69ff3e40c2e0fd922bb41fe0 (patch) | |
| tree | aab5efcd8eb303e73f451f39522a913df527b49f | |
| parent | b20515f2a07cd6818ed859575d7e8796d6606489 (diff) | |
| download | talos-hcode-f3107eab4e66527f69ff3e40c2e0fd922bb41fe0.tar.gz talos-hcode-f3107eab4e66527f69ff3e40c2e0fd922bb41fe0.zip | |
STOP: Fix L2 purge abort by pc interrupt on core handoff to sgpe
Change-Id: I81973d4de46f134f72dc9582aae7e6b6ea749e42
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36602
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: JAMES DEZELLE <jdezelle@us.ibm.com>
Reviewed-by: ASHISH A. MORE <ashish.more@in.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
| -rwxr-xr-x | import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_entry.c | 28 |
1 files changed, 19 insertions, 9 deletions
diff --git a/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_entry.c b/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_entry.c index aa6f67a2..4fcb0c3d 100755 --- a/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_entry.c +++ b/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_entry.c @@ -806,12 +806,15 @@ p9_cme_stop_entry() core_aborted |= CME_MASK_C1; } - //======================================= - MARK_TAG(SE_PURGE_L2_ABORT, core_aborted) - //======================================= + if (core_aborted) + { + //======================================= + MARK_TAG(SE_PURGE_L2_ABORT, core_aborted) + //======================================= - PK_TRACE_DBG("Abort: L2+NCU purge aborted by core[%d]", core_aborted); - out32(CME_LCL_SICR_OR, BIT32(19) | BIT32(23)); + PK_TRACE_DBG("Abort: L2+NCU purge aborted by core[%d]", core_aborted); + out32(CME_LCL_SICR_OR, BIT32(19) | BIT32(23)); + } } #endif @@ -828,10 +831,17 @@ p9_cme_stop_entry() MARK_TAG(SE_PURGE_L2_DONE, core_aborted ? core_aborted : CME_MASK_BC) //=================================================================== - // if core = 3 aborted = 1, core = 2(sgpe handoff) aborted (cme wakeup) - // if core = 1 aborted = 2, core = 1(sgpe handoff) aborted (sgpe wakeup) - // if core = 1 aborted = 1, core = 0(break) aborted (cme wakeup) - // if core = 2 aborted = 3, core = 0(break) aborted (cme wakeup) + // 1) if core = 3 aborted = 1, core = 2(sgpe handoff) aborted (cme wakeup) + // 2) if core = 1 aborted = 1, core = 0(break) aborted (cme wakeup) + // 3) if core = 2 aborted = 3, core = 0(break) aborted (cme/sgpe wakeup) + // 4) if core = 1 aborted = 2, core = 1(sgpe handoff) aborted (sgpe wakeup) + // for case 3) and 4) on the other core already handoff to sgpe + // if rgwu or spwu, fine because it will be sgpe wakeup + // if pc, there wont be sgpe wakeup due to notify bug, + // so ignore this case for abortion. otherwise, + // for case 3) core is waking up by tag along with another core + // but leave stop8 record at sgpe + // for case 4) l2 is not purged and sgpe will do stop8 if (core != (core_aborted & core)) { core &= ~core_aborted; |
