summaryrefslogtreecommitdiffstats
path: root/libgo/go/database
diff options
context:
space:
mode:
authorian <ian@138bc75d-0d04-0410-961f-82ee72b054a4>2014-03-03 20:14:52 +0000
committerian <ian@138bc75d-0d04-0410-961f-82ee72b054a4>2014-03-03 20:14:52 +0000
commit2f501e2420760a9e62838d39fa7738e7d3284231 (patch)
treefb0eb29cec9de27ca80e274d703ef63dd94e37c3 /libgo/go/database
parentd7f5615e21e38f5c85175b3cf2a1a6525d9d9558 (diff)
downloadppe42-gcc-2f501e2420760a9e62838d39fa7738e7d3284231.tar.gz
ppe42-gcc-2f501e2420760a9e62838d39fa7738e7d3284231.zip
libgo: Update to Go 1.2.1 release.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@208286 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'libgo/go/database')
-rw-r--r--libgo/go/database/sql/sql.go4
-rw-r--r--libgo/go/database/sql/sql_test.go23
2 files changed, 25 insertions, 2 deletions
diff --git a/libgo/go/database/sql/sql.go b/libgo/go/database/sql/sql.go
index dddf5a3f257..84a09651322 100644
--- a/libgo/go/database/sql/sql.go
+++ b/libgo/go/database/sql/sql.go
@@ -620,8 +620,8 @@ func (db *DB) conn() (*driverConn, error) {
}
// If db.maxOpen > 0 and the number of open connections is over the limit
- // or there are no free connection, then make a request and wait.
- if db.maxOpen > 0 && (db.numOpen >= db.maxOpen || db.freeConn.Len() == 0) {
+ // and there are no free connection, make a request and wait.
+ if db.maxOpen > 0 && db.numOpen >= db.maxOpen && db.freeConn.Len() == 0 {
// Make the connRequest channel. It's buffered so that the
// connectionOpener doesn't block while waiting for the req to be read.
ch := make(chan interface{}, 1)
diff --git a/libgo/go/database/sql/sql_test.go b/libgo/go/database/sql/sql_test.go
index 093c0d64cac..787a5c9f744 100644
--- a/libgo/go/database/sql/sql_test.go
+++ b/libgo/go/database/sql/sql_test.go
@@ -1005,6 +1005,29 @@ func TestMaxOpenConns(t *testing.T) {
}
}
+func TestSingleOpenConn(t *testing.T) {
+ db := newTestDB(t, "people")
+ defer closeDB(t, db)
+
+ db.SetMaxOpenConns(1)
+
+ rows, err := db.Query("SELECT|people|name|")
+ if err != nil {
+ t.Fatal(err)
+ }
+ if err = rows.Close(); err != nil {
+ t.Fatal(err)
+ }
+ // shouldn't deadlock
+ rows, err = db.Query("SELECT|people|name|")
+ if err != nil {
+ t.Fatal(err)
+ }
+ if err = rows.Close(); err != nil {
+ t.Fatal(err)
+ }
+}
+
// golang.org/issue/5323
func TestStmtCloseDeps(t *testing.T) {
if testing.Short() {
OpenPOWER on IntegriCloud