| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Made height and width changes to icons on app header
and system overview to properly align icons in IE11.
Removes additional space in system overview quick
links.
Tested in Chrome, IE11, Safari, Edge.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I7ae24df3fe73ea3502565ed3ee2ccabb2506e098
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use page, section, list-pair to establish
consistent layout
- Update header and overview page to use new
caret icon
- Reordered Server and BMC information to
accomodate small screen views
- Added chevron icons to create consistency
between header and server overview page
quick links
- Changed edit hostname text to use the
standard icon
- Added OR operator to short circuit the server
model, server serial number, and server manufacturer
to display N/A if the information is not available
Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds text to indicate the current state of the toggle button to meet
accessibility guidelines
- Update size, color, and focus of toggle component to fix
DAP violations
- Add page, section, and list-pair layout patterns established
on the power usage page to begin a pattern for consistent
page layout
- Add form__field and form__actions to help with form layout
consistency.
Tested: Verified toggle functions in the GUI and tested with screen reader. Passes DAP.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Iaa8646b1179cc307971065c455f4b9448095d1ec
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss. Any usage of CSS color properties should
refer to the mapped color variables in colors.scss.
- Removed tags.scss file since tag components no longer used
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remote logging enables the user to configure a remote
server to stream out local logs. This feature will be
available on the Event Log page. The user can add a
remote server, edit/change an existing server
configuration and remove/disable the remote server.
Resolves openbmc/phosphor-webui#68
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make sure our event log content is properly aligned
on tablet and desktop views. It will also make the date/time value
on the server overview page always display underneath the 'BMC time'
label in a destkop view–currently the date value will wrap to a
new line if the string is too long.
- Update markup to use Foundation grid layout classes on the
server overview event log table
Tested: Event log tables on server overview page and event
log page
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I7d765ebbe679f954e606d1d25e2182d983a7b3f3
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add pattern for no spaces
- Fix character count
- Prepopulate hostname in input field
- Show error for invalid input
- Improve form accessibility
- Correct global disabled primary button style
Resolves openbmc/phosphor-webui#71
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ia0601ac7c52229d0606dc5b13397b468fa81426d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">
Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.
Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added "localeDate" filter to present date and time in preferred format:
- the date will be displayed as: 'Dec 3, 2018'
- the time will be displayed in locale preferred format.
- the timezone will be displayed as abbrev or GMT+/-offset.
At the 'Date and Time setting' the time zone name will displayed in long
format if it is possible.
All text parts of date/time representation will be in English.
Resolves: openbmc/phosphor-webui#42
Change-Id: I2fdbb47c62dfc5000039b0c00a20f64a9a389fc6
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurable options via SCSS variables
(e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer
getting inherited.
Moved a few elements and adjusted styles to get the same look as
before.
See https://getbootstrap.com/docs/4.0/migration/ for more
information.
Tested: Manually on a Witherspoon.
Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows user to display events in their timezone or in UTC.
Previously allowed either ETC or UTC, but listed ETC as
'user timezone'. Updates date time page from GMT offset to
UTC offset for overall consistency. Also updates overview
page to list critical events in user timezone
Resolves openbmc/phosphor-webui#36
Tested: changed timezone settings locally and validated
that correct timezone and UTC offset was presented in
the UI.
Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Format on event log page and overview
page of date and time should match the
format of 'data last refreshed' with the
exception of the timezone being listed
with the event log.
Resolves openbmc/phosphor-webui#21
Change-Id: I21d43e45f45d2f9eebc7c08f4345201bef354a06
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
| |
To match other links, capitalize the first letter of "Edit".
Resolves openbmc/phosphor-webui#25
Change-Id: I6da98358c68223b7a70e5500f3a83a6cd57a5f32
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.
Don't use tabs or mix tabs and spaces for indentation."
Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
| |
The docker image moved from clang-format-5.0 to clang-format-6.0.
Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created toggle button to enable power cap and a text field to set
it. This form is similar to the set network form.
Moved logic for displaying the power cap as disabled to the
overview controller.
Resolves openbmc/openbmc#3221
Tested: Set the power cap on a Witherspoon
Change-Id: I62346fe3ed123b9df58d159cee2584937d46213c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
The menu item is called "Server LED".
The title is called "Server LED".
The route is server-control/server-led.
Tested: Verified server LED still works.
Change-Id: I1c70cfb6cd36868a191aa51363437dcdcc6d9a6b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All the constants are defined here:
https://github.com/openbmc/phosphor-webui/blob/master/app/common/services/constants.js
Constants are injected as part of app.common.services.
This environment-constants.js or environment-constants.json could
be repurposed to configure features but going with something else,
https://gerrit.openbmc-project.xyz/#/c/11311/.
Tested: Quick manual regression test on the pages.
Change-Id: I59ba4f47fe8a927cb5f68a2657dfea9c61cd5f28
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The error logs were ordered "81, 80, 8, 79 ..."
sortAscending was causing this, remove it and switch "+Id" to "-Id"
which is the correct way to do descending ordering.
http://www.tutorialspark.com/AngularJS/AngularJS_Filter_orderBy.php
Resolves openbmc/openbmc#3233
Tested: Server Overview page and event log page both show correct
order now.
Change-Id: Ie1aee542cec8a6157c538838037ce82fc2525e46
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the Event ID and Description event log properties
are present, display the error log title as <ID>: <Desc>
and move the Message property down into the box with the
other additional data fields.
If they aren't present, or not filled in (which in the case of
the event ID is a value of 'None'), leave the title as it
currently is, which is the Message property.
Tested: Verify UI fields when the event ID is valid, when
it's still in the event data but not valid, and when it isn't
in the event data at all.
Resolves openbmc/openbmc#3056
Change-Id: I455fc257b7d3713aceee2975d5240fb226cfa87e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restrict the number of high priority event logs to the 5 newest on
the server overview page. All the event logs can still be viewed on
the event log page. The server overview page should just show a
summary and not show all the high priority event logs, which could
number as high as 200.
Resolves openbmc/openbmc#3160
Tested: Running GUI locally and verified the number of high priority
events as 4, 5, 6 and 10.
Change-Id: I3fc22c8d13eb66a6b045d46180f1d195d74e67c3
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.
Change-Id: I96a05972665f9c67625c6850c3da25edc540be06
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494
End goal is to get the code formatted well enough that
clang format will run correctly against it.
Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
| |
Before this text was "edit server name". On the Network page we call
it "hostname" and the rest call is "Hostname". To be consistent
change to "edit hostname".
Change-Id: I0042f56cc77180dbb0cc51f7e955762f1eeafb4d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
High should not be capitalized.
This follows the other options in the box: "Turn on server LED",
"Edit network settings", and "Serial over LAN console"
Before: "View x High priority events"
After: "View x high priority events"
Change-Id: I11b8487881cff9da4e6de58871204125045bbea8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to load as much data as possible on the
'Server overview' page. In original code, multiple promises are
executed in parallel using $q.all() to get data for the page.
When any of the promises fails, the remaining promises are
aborted. The fix is to write a method to resolve the promise
returned from each of the APIUtils calls, which would set the scope
variables, and pass the promise returned by it to $q.all instead.
Resolves openbmc/openbmc#3151
Change-Id: I361c80ddd2665dbe43f8a635eda42ef2b5c0788c
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reversed the event log order to show the newest event first
Resolves openbmc/openbmc#3161
Tested: Running GUI locally and verified the order in both Server
overview page and in Server health -> Event log page
Change-Id: I1f1265332bb426d3f2a13932cfd5445740c3f49b
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Testing: Verified edit button correctly updates hostname on BMC and
it is correctly refreshed in the web interface.
Resolves openbmc/openbmc#3104
Change-Id: I28eb6366bde7c01b84d2fab54317aaf69ec2dba8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
This reverts commit 7a3928da6aecfa20d6676150d978bca8eba62ab5.
Commits coming on top of this to add the required function in.
Change-Id: I5fe903f33de66577a807a391227dabaea0ddd69d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
|
|
| |
We ran several customers through usability testing of the GUI last
week. There was some confusion about "Serial over LAN". Adding
console should help clear up this confusion.
Renamed on both the overview page and the menu. This now matches with
the SOL console page title.
Change-Id: I73fc6964f4269a5332832af703c7198015be6a49
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Added the verb "View" to the front.
This wording watches with other clickable links in the gray box
(e.g. "Turn on server LED", "Edit network settings")
Change-Id: I5696f92aedc2d83bcb261ff8f849415d5b66d336
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
BMC Host/IP Address is already displayed in the header.
So in the 'BMC information' section, just display the
BMC's ip addresses. There could be multiple ip addresses.
Resolves openbmc/openbmc#3148
Change-Id: I4efdf4f1df2fc70d32dd659ae57b6bb7ba0fa0f4
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Get the BMC time from xyz/openbmc_project/time/bmc.
This time is in epoch time so convert.
Before the time and date hardcoded.
From https://docs.angularjs.org/api/ng/filter/date:
"'medium': equivalent to 'MMM d, y h:mm:ss a' for en_US locale
(e.g. Sep 3, 2010 12:05:08 PM)"
This is a similar format as to what was present on the GUI
before for en_US.
Letting the browser choose the format, is important.
Displayed in user's timezone.
Resolves openbmc/openbmc#3116
Tested: Now see correct date and time, "4/19/2018, 20:31:18 UTC"
Change-Id: Ie30c65b038b58afc8c4c77ca5b70667e80e76cc6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We ran several customers through usability testing of the GUI this
week.
One area that caused confusion is the "Turn on server indicator".
We had a customer think it was a button to power on the server.
Other customers were also confused about what it does.
After discussing and getting customer feedback,
"Turn on server LED" is better understood.
This also matches what is on the Server LED page.
Change-Id: I1b55a377c85ee6e649e27e2a6923b5e17fd23a30
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
It is capitalized as "Serial over LAN" everywhere else on the GUI
(the SOL page and in the sub-menu).
This also follows with the capitalization of the other items in
the gray box: "BMC time", "Turn on server indicator", and
"Edit network settings".
Change-Id: I9e94f8ef1ebf65d0038b33c7fb1e11576f0a3f61
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Already have a Web UI version, no need to track the version
of each file. These have not been getting updated.
Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The overview page before displayed the "Severity" of the event log
in the name field. It now displays the type. Type is from the
"Message" field in the event log. An example of the type is:
"xyz.openbmc_project.Software.Version.Error.ManifestFileFailure".
This is much more useful than the "Severity" ( e.g.
"xyz.openbmc_project.Logging.Entry.Level.Error"). Severity is
still displayed in the event log, above the type.
A similar change for the "event logs" page was made here:
https://gerrit.openbmc-project.xyz/#/c/8916
Change-Id: Iddf1f99e0ccde5a4f27d709dc280de628eb909ce
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Editing the hostname does not work. We need a rest call to do
this. Comment this 'edit' button out until the code is added to do
this.
Tested: Don't see this edit button the server overview page.
Change-Id: I957a3df99810a206c67e95dd4d53dc5d6833387c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Before setting the BMC firmware was in displayServerInfo
Tested: Verified the BMC firmware still displays correctly.
Change-Id: Ic6323bc9eec700ff5956868899ccda398a841274
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Look at /xyz/openbmc_project/inventory/system for the server
information. Before the "server overview" page looked at the
BMC information for things like Server SerialNumber.
Resolves openbmc/openbmc#3095
Tested: Verified I see the correct server information now.
Change-Id: I562b28353d79fbf4a84e4c9a01db57d757a102a1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 23217dae2bdc8e9bd6b3f20a395d1892382b0682.
https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all
pages so individual refresh functions are no longer needed
Change-Id: I52151ba0e356f000324538e4b5eac6c9846c2eb3
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
|
|
|
|
|
|
|
|
| |
Current values are hard coded to '000 W'.
This fix is to do REST calls and display the correct values.
Resolves openbmc/openbmc#2735
Change-Id: I2f6766f1685a2bd52da62cda19998794f80270ec
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
|
|
|
|
|
|
| |
Partially resolves openbmc/openbmc#2927
Change-Id: I7f449c41ef645b67253c5d3c2ed6c8b1984f0408
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2894
Tested: Running GUI locally and verified the new texts. Also made sure that
value truncation is not happening.
Change-Id: Ic3947b36ef83fe5cb37190a848c85156cc072afd
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
|
|
|
|
|
|
| |
Tested: Manually tested GUI for any regressions
Change-Id: I8c0922b7bd67b03b07e8880bc4dba3b862220b33
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requires, not hardcoded paths. This was
required to make the packaging work correctly.
3. Add babel config to do translation.
4. Update angularjs directive calls to use the angular 1.6 syntax for
promises intead of success and fail.
https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http
5. As a consequence of using NPM/webpack, the versions of angular and
associated modules that were checked in have been updated.
Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Updating images and styles after code merge conflicts
Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
|
|
|
|
| |
Change-Id: Iae10d39428b6ce6a228e775aa68fb7805dd61ecb
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|