| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When I originally wrote CSP into the webui files, I intended to drop it
into the HTML file so it could be removed from bmcweb. Unfortunately,
that plan doesn't fly, as the CSP headers in bmcweb need to remain for
non-html files.
This normally wouldn't matter, but a number of people utilize
BMCWEB_INSECURE_DISABLE_XSS_PREVENTION to run the webui locally and
debug a new webui patch from a working BMC. This causes the CSP headers
to conflict, and the browser to fail with a CSP error on connect-src
when debugging locally.
Removing the CSP section entirely from the webui resolves this, and
doesn't change functionality at all, as it's still covered in bmcweb.
Tested: Will verify on a real platform.
Verified that building the webui locally with the above bmcweb flag
allows the webui to launch correctly.
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I60e5011361ec3ce1930249a20cf34480beb48a7f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed errorModalDetails and displayErrorModal from
dataService since they are no longer used.
errors.html was only active when displayErrorModal was true.
displayErrorModal was only true when activateErrorModal was
called.
activateErrorModal was removed in a previous
commit. activateErrorModal's only use was removed here:
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a
Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Design team proposed that our error and success messages be
delivered as 'toast' messages on the right side of the screen.
This brings in ngToast and implements notifications on SNMP page.
Notifications will fade after 10 seconds or can be dismissed.
https://github.com/tameraydin/ngToast
Change-Id: I1053534cd1ab189ae5c2ac07e2a922acea231c70
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Webpack allows us to define a content security policy that utilizes
hashes to define what is, and isn't allowed to execute in the page
context. Because we're a single page application, this means that we
can effectively defend the whole page with a few extra lines of setup.
This does not utilitize _any_ of the unsafe-* calls that content
security policy has, which should meet security standards for all uses.
Tested By:
Launched GUI, observed no functional changes, and watched console for
CSP errors. Saw none.
Change-Id: I892df1f1b004384943be0ae6e51046054991fd45
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ngCSP allows angular to avoid using inline style and unsafe eval
mechanisms. Enabling this will allow us to update to a more stringent
content-security policy.
for more details, see documentation here:
https://docs.angularjs.org/api/ng/directive/ngCsp
Tested by:
Launching the GUI, and saw no ill effects.
Change-Id: I4db732e997c2901d1fe57eee99607007b5e3afec
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|
|
|
|
|
|
|
|
|
|
| |
This is the name that appears in the browser tab.
Fixed OpenBMC capitalization and removed "app".
This conforms to other websites (e.g. the browser tab for riot.im
is "Riot". For google.com it is "Google").
Change-Id: Ibd64ccd37d9f4b1fbea42c398e57abfad6efe357
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the cold reboot issue with the following steps
- It applies the command to shut off the chassis.
- Then verify the chassis is off. It checks for every 5 seconds.
During this time the spinner displays. A 5min timeout has been
added.
- Once the chassis is off, it turns on the host.
fixes openbmc/openbmc#2795
Change-Id: I119a1c95e57c10ccee27be1512a1fc38cde307fa
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
The current repo doesn't seem to produce a favicon, so having the
reference to it produces either a 404 error or a 401 error depending on
the server. Add a transparent favicon until someone can cobble
together a proper one from the openbmc SVG files
Change-Id: I5a79be5982e164a8ae0b28a69f673129c0a959ba
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requires, not hardcoded paths. This was
required to make the packaging work correctly.
3. Add babel config to do translation.
4. Update angularjs directive calls to use the angular 1.6 syntax for
promises intead of success and fail.
https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http
5. As a consequence of using NPM/webpack, the versions of angular and
associated modules that were checked in have been updated.
Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Updating images and styles after code merge conflicts
Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
|
|
|
|
| |
Change-Id: I7f70505fd25252223cac121fb74d21bed0e5a5c1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
|
|
|
| |
Change-Id: If624d4b1858abea7d15ecc54caf78ae1deb38232
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
|
|
|
|
| |
Change-Id: I1ecbe00160d802c5dce2496614717e255d3fe055
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
|
|
|
|
| |
Change-Id: Id8c890714d0a90ae913b6581cd655abcf6cd6781
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
|
|
|
| |
Change-Id: Ie89793ec9add1fc9e5241b422cfff64784f7b078
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I9579c85d7d9d7268d9e35637809fa26d623f0310
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
|
|
|
| |
Change-Id: I72026e5ea64c9fba3089b68dfd2b8198255dabb8
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
|
|
|
| |
Change-Id: I9dc891e0f1e30abe488d401c57e1cf4f5656c3af
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I735465dc2d6ab0583586ece23380ea8570f024fa
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
|
|
|
| |
Change-Id: I805828ce3cb80dbceb1dbba5d0e39fb31fbd6baf
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
|
|
|
| |
Change-Id: Ife37444dcede67b54d1f257ee99322b22ac6b78c
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
|
|
|
|
| |
Change-Id: I634cbc5c4c42150b54ac4f520ff7aed70b4243dc
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
|
* Split files into independent files based on functionality.
* Switch to bower/gulp for build.
Change-Id: Ibc775dd9b7f6a0a49f63c22162b7582e781e2d9c
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|