| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ie1ef89023a043a70a0126a21be57febb9afae19a
|
| |
|
|
|
|
|
|
|
| |
Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I86e526c59ac5c2e2c011aed0ce4bc3d82db63b5e
|
| |
|
|
|
|
|
|
|
|
|
|
| |
- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection name to Local User Management
Resolves: openbmc/phosphor-webui#619
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39
Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.
Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.
Marta Mazur did a similar file and route move here as part of
supporting multiple Virtual Media endpoints:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218
Tested: Built and loaded on a Witherspoon. The VM route is now:
#/server-control/virtual-media. Was able to use the VM
panel.
Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table
TODO:
- Remove critical icon background image in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2e10bc3f3432331b6dd9354dbcd0e32480894ece
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.
- Adds page, section, form field and actions styles
- Removes unused styles
Tested:
- Passes DAP
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I96bb4732fdf160b2cc9eff0ad3ed9309ab1b9ea4
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event
Tested:
- Input fields are editable and can be saved
- DAP violations and page layout consistency will be addressed
in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Converted both certificate expiration date and bmc date/time to EPOCH time to fix the bug
Tested: Go to Date and Time settings and change BMC time to be after or 30 days before a certificate expiration date.
Then either a warning or expiration icon and message will be displayed next to the date and message on top of the table.
To remove the expiration or warning date, upload a certificate that has an expiration date greater than 30 days after bmc time
set. The icon and warning message should now disappear.
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I9389fe3cce5a555945adf9c56180897a6be047bf
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will be able to either copy the
code or download the code in a txt file.
Tested: loaded onto Witherspoon and able to view on certificate
management page. Click on generate csr and type in necessary
(or any additional info), then click on generate CSR. The CSR
code is then visible and is able to be copied or downloaded. In
error state in which CSR code is unable to generate, the modal
closes and an error toast message appears. FYI: Sometimes you
have to reboot system in order for csr to successfully generate.y
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This commit introduce two new columns on certificate table.
It should help user to differentiate multiple mTLS certificates.
Date format was changed to 'medium' one to accommodate two new columns.
Small corrections were made to action button paddings to make the icon better centered.
Tested: GUI tests were done on Chromium v74.0.3729 browser. Desktop and mobile version.
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I660b74dd8b50f854ebbdad1890bbf99b3675f4cd
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss. Any usage of CSS color properties should
refer to the mapped color variables in colors.scss.
- Removed tags.scss file since tag components no longer used
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client cert
are implemented in this commit, with the ability to add
more types as needed by adding them to the constants.js
CERTIFICATE_TYPES array.
Also provides the ability to replace a certificate once
it is added.
Resolves openbmc/phosphor-webui#43
Tested: loaded onto a witherspoon and able to view and
replace both the HTTPS certificate and the
LDAP certificate. GUI only allows to upload an
LDAP certificate if one doesn't already exist.
The GUI limits the user to one file per type as
expected at this time and provides the
appropriate validation messages. Alert messages
appear above the table if the certificate is
expired or within 30 days of expiring.
Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will create more visual consistency between the components
in the GUI since there are elements, such as text fields and
dropdowns that are styled with straight corners.
- Removes border radius from buttons
- Removes some redundant styles
- Adds input types that aren't currently inheriting
defined styles
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds page to manage virtual media devices. User selects file
and pushes 'start' button to establish websocket connection.
nbdServerService added to provide ability for user to navigate
away from the page and return with the ability to see the current
active sessions.
Currently only supports 1 Virtual Media device.
Resolves openbmc/phosphor-webui#40
Tested: uploaded ubuntu image file, started the connection and
mounted virtual media device from host console. Able to see Ubuntu
image file. Also uploaded file and navigated away from the page,
checking that the websocket remained open and was sending /
recieving messages. Finally, tested that when connection
was stopped, 'USB disconnect' log was present in host console.
Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use background-image strategy to add caret to dropdowns
- Standardize implementation by including mixin to dropdown__button
class and removing styled pseudo element
Resolves ibm-openbmc/dev#478
Tested: Running locally on Chrome only. Ran into network request
errors for newly added svg assets when mounting overlay
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I714c2515282676f368eafb2560177d2935680e23
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds form validation to SNMP page. Also adds new icons to
page for edit and delete. Validation messages for inputs
appear after input has been touched or if the user attempts
to submit the form with validation errors.
Tested: Add, remove, and update SNMP was successful and
functionality unchanged. Form did not allow invalid or
empty values to submitted. Used Chrome, Safari, and Firefox
to verify that visual design looked as expected.
Resolves openbmc/phosphor-webui#37
Change-Id: I7a97d80724e56d2f22c74ac1251041270bbc35ad
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
| |
Replace error and success messages with toast notifications.
Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurable options via SCSS variables
(e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer
getting inherited.
Moved a few elements and adjusted styles to get the same look as
before.
See https://getbootstrap.com/docs/4.0/migration/ for more
information.
Tested: Manually on a Witherspoon.
Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Currently, the more info icon (...) is positioned too far
from the server version on the firmware page. This places the
icon 20 px to the right, so that it is clearly associated
with the version.
Resolves openbmc/phosphor-webui#23
Change-Id: I5d1dc6bf1446c9f10ee0181d9b9fa2eb3e53e498
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
| |
Allow the user to remove SNMP Managers.
If the SNMP Manager being removed exists in the backend, make a
call to remove it.
Tested: Removed SNMP Managers on a Witherspoon
Change-Id: Ib392cda30754adfaa58f6301592c2d666ff2c29e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
| |
This allows the user to add and edit SNMP managers.
Tested: Added SNMP managers on a Witherspoon.
Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
| |
Blue makes the text appear to be a link.
Updated text color to dark grey.
Resolves openbmc/phosphor-webui#22
Change-Id: I5950473844d2edfeaf5ede80b46984bc152d7483
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
| |
Tested: Able to remove existing IPV4
addresses.
Change-Id: I772bee6ad6b68bc0a69351f3e5386acc659241ef
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
| |
Change-Id: I58a3a894c192fafb551e07302b107bcd776e4901
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Added button to remove DNS server from
Nameservers list.
Resolves openbmc/phosphor-webui#11
Tested: Added and was able to remove DNS servers
from list. Page updated appropriately.
Change-Id: I64e9d2499465f1aa5f9f34c831961578abf32b2b
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.
Set time mode
Moved the selection of NTP vs Manual (time mode) to a radio
button.
Added code to allow the user set it.
Tested: Set the time mode on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Set time owner
The time owner is now a dropdown and is set when "Save settings"
is pressed.
Tested: Set the time owner on a Witherspoon
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Set the BMC and Host time
The BMC and host have the same time except when time mode is split.
Only need to set BMC or host time when time mode is not split.
When time mode is split, set both. Use time owner to determine
which to set.
https://github.com/openbmc/phosphor-time-manager#time-settings
Have date and time as two separate inputs, this is due to Firefox
not supporting "datetime-local". The "date" and "time" input
fields are more widely supported.
https://caniuse.com/#feat=input-datetime
The idea for 2 separate input fields came from:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local
Must set the time mode and time owner before setting the time,
this is due to permissions of who can set the time.
Tested: Set the date and time on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Add NTP Servers
The user can now view and set NTP Servers.
Moved setFocusOnNewInput to a common directive since it is used
on the NTP Servers and the DNS Servers on the network page.
Even though NTPServers is a network interface specific path
(e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts
like a global setting, openbmc/phosphor-time-manager#4.
Using eth0 for setting and getting the NTP Servers until
NTPServers is moved to a non-network interface specific path.
In Redfish, NTPServers is a non-network interface specific.
Tested: Set NTP Servers on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Add timezone
Added the timezone for the host and bmc date time.
The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)".
I got this from
https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript
and choose this formatting over something like "America/Chicago".
Tested: See the timezone on a Witherspoon
Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Created new page to display SNMP Managers.
Display the SNMP Manager's IP and port.
https://github.com/openbmc/phosphor-snmp/blob/master/docs/snmp-configuration.md
Future commits will allow the user to add and delete SNMP
managers.
Change-Id: Ia5d633c11728a580c06b25c412e8673925cdc597
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a Date and time page in the GUI. Enhanced it to
display the BMC time and added it to the menu so users
could navigate to it.
Future things planned for this page:
Setting the time, time mode, and time owner.
Adding a NTP server.
More information can be found in the time manager README:
https://github.com/openbmc/phosphor-time-manager/blob/master/README.md
Tested: See the BMC time.
Change-Id: Ia3ac2385cb45ec8009ed6df0899c3410fe18ef64
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
| |
This page was unused and unreachable from the menu.
Cleaning up the code base.
Change-Id: Id2529d95768d3885448efebb6d24833ffe35c3b6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
| |
This page was unused and haven't heard of any plans to implement it.
Cleaning up the code base.
Change-Id: Ie4fadc57e42f9b1c8fbc7f4c848f001ff062210f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
| |
Make a REST call to set the MAC address when the
"Save Settings" button is pressed.
Tested: Verified the MAC Address is set.
Change-Id: I39f6d4688842b3453fd219795d07f819ba4ba481
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix includes
- Polling the number of software objects for a new image. During
which time the 'Downloading in progress' status bar will be
displayed. A 2-minute timeout is used.
- Displaying a 'Download complete' message if the download succeeds
and refreshing the firmware page to show the new image once it is
downloaded.
- Displaying an error pop-up with reason for failure when the
download fails.
Resolves openbmc/openbmc#3054
Change-Id: I79a8b8c661c01474a12cef4af524cafdc2cee1fe
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.
Tested: Verified I see this error if either field is empty.
Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
Let the action table cell flex to fit 2 buttons, "Activate"
and "Delete". This happens on a "Ready" image.
Resolves openbmc/openbmc#2964
Tested: See both "Activate" and "Delete" on a "Ready" image.
Change-Id: I1a91ed83f2f99983795baea9f59bbc0dd4749c0e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
| |
Updating images and styles after code merge conflicts
Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: If4612da39126fbfbaaebc915c59b4404092f05e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I0b2ee399243f0bc3e5ed44bc578a0d153486ed55
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id97de89d646bc0c980fd4f0849109047906383e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
| |
- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency
Change-Id: I3f497b2707991f7f628892a05734eea183a0d01d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ia64dfd7ae7e1fb3081d0d5de680b9afa3cab669d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If3730f75e796f8f48fd036234711efa23e23f794
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If77d9119bc9335b5bd5e94ec1d201f6aa8969d0d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I13bae30e86330a8831d35f1d8a2f7da821324e37
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I2dd2cc6168d86676ab7ada9b389cb86cee9b3dae
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I2b5f24ca8421f5097c3733bc235e7cadf252d1fb
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ie89793ec9add1fc9e5241b422cfff64784f7b078
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
| |
|
|
|
| |
Change-Id: I3d9a2ec068e3542a848dada63a6bbebe9869bf2f
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|