summaryrefslogtreecommitdiffstats
path: root/app/configuration/controllers/snmp-controller.js
Commit message (Collapse)AuthorAgeFilesLines
* Fix SNMP multiple calls bugDerick Montague2019-10-161-10/+14
| | | | | | | | | | | | - Added a call to reload the route in the promise success callback. This assures that a newly added manager has a path. - Update the use of var in for blocks to scope the variable to the block rather than overwriting the i variable that is hoisted and scoped to the setSNMP function. - Change i variable name to managerLength to improve readability Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I18fe9ecc3ca7cca29781a5c24caca73bda71ee43
* SNMP page visual redesignbeccabroek2019-04-011-15/+10
| | | | | | | | | | | | | | | | | Adds form validation to SNMP page. Also adds new icons to page for edit and delete. Validation messages for inputs appear after input has been touched or if the user attempts to submit the form with validation errors. Tested: Add, remove, and update SNMP was successful and functionality unchanged. Form did not allow invalid or empty values to submitted. Used Chrome, Safari, and Firefox to verify that visual design looked as expected. Resolves openbmc/phosphor-webui#37 Change-Id: I7a97d80724e56d2f22c74ac1251041270bbc35ad Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add role alert to toastsbeccabroek2019-02-061-6/+6
| | | | | | | | | | For accessibility reasons, 'role="alert" is required for toast messages. This notifies screen readers that an error or success message has appeared. Adds a service layer for toast messages that adds the role attribute to the message. Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add toast notifications to SNMP pagebeccabroek2019-01-151-9/+6
| | | | | | | | | | | | Design team proposed that our error and success messages be delivered as 'toast' messages on the right side of the screen. This brings in ngToast and implements notifications on SNMP page. Notifications will fade after 10 seconds or can be dismissed. https://github.com/tameraydin/ngToast Change-Id: I1053534cd1ab189ae5c2ac07e2a922acea231c70 Signed-off-by: beccabroek <beccabroek@gmail.com>
* SNMP: Use lowerCamelCase for varsGunnar Mills2018-11-021-9/+9
| | | | | | | Following https://google.github.io/styleguide/jsguide.html. Change-Id: Ib7704018622571cf1701d3a525dc01297bed7243 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Only update SNMP fields if changedGunnar Mills2018-11-021-6/+11
| | | | | | | | | Use ng-change to determine if the SNMP fields, Address and Port, have changed and should be updated. Tested: Only see the rest calls when the fields have changed. Change-Id: I324c9c422a8b6dfb8816925167953e16099f8044 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add and modify SNMP ManagersGunnar Mills2018-10-291-4/+106
| | | | | | | | This allows the user to add and edit SNMP managers. Tested: Added SNMP managers on a Witherspoon. Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Create new SNMP Settings pageGunnar Mills2018-09-101-0/+31
Created new page to display SNMP Managers. Display the SNMP Manager's IP and port. https://github.com/openbmc/phosphor-snmp/blob/master/docs/snmp-configuration.md Future commits will allow the user to add and delete SNMP managers. Change-Id: Ia5d633c11728a580c06b25c412e8673925cdc597 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
OpenPOWER on IntegriCloud