summaryrefslogtreecommitdiffstats
path: root/app/configuration/controllers/snmp-controller.html
Commit message (Collapse)AuthorAgeFilesLines
* Update SNMP page layoutDixsie Wolmers2019-09-111-90/+90
| | | | | | | | | | | | | | | This change applies global styles to improve page layout consistency and removes unnecessary custom styling. - Adds page, section, form field and actions styles - Removes unused styles Tested: - Passes DAP Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I96bb4732fdf160b2cc9eff0ad3ed9309ab1b9ea4
* Fix IE11 SNMP edit bugDixsie Wolmers2019-09-111-8/+7
| | | | | | | | | | | | | | - Removes edit button from form - Removes focus-within (not compatible with IE11 and Edge) and pointer-event Tested: - Input fields are editable and can be saved - DAP violations and page layout consistency will be addressed in separate commit Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6
* Consolidate button stylesYoshie Muranaka2019-06-211-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
* Resolve accessibility isssuesDerick Montague2019-04-081-30/+35
| | | | | | | | | | | | | | | | | | - Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes. Resolves openbmc/phosphor-webui#76 Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
* SNMP page visual redesignbeccabroek2019-04-011-19/+79
| | | | | | | | | | | | | | | | | Adds form validation to SNMP page. Also adds new icons to page for edit and delete. Validation messages for inputs appear after input has been touched or if the user attempts to submit the form with validation errors. Tested: Add, remove, and update SNMP was successful and functionality unchanged. Form did not allow invalid or empty values to submitted. Used Chrome, Safari, and Firefox to verify that visual design looked as expected. Resolves openbmc/phosphor-webui#37 Change-Id: I7a97d80724e56d2f22c74ac1251041270bbc35ad Signed-off-by: beccabroek <beccabroek@gmail.com>
* Clean up headersbeccabroek2019-02-191-1/+1
| | | | | | | | | | | | | | Updates headers to match style guide and makes them consistent throughout pages in the GUI. Removes instances where a header element existed and a different header style was being applied. For example, <h2 class="h4"> Tested: Ran GUI locally and verified that headers look consistent and have the appropriate sizing while using Chrome, Firefox and Safari. Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add toast notifications to SNMP pagebeccabroek2019-01-151-2/+0
| | | | | | | | | | | | Design team proposed that our error and success messages be delivered as 'toast' messages on the right side of the screen. This brings in ngToast and implements notifications on SNMP page. Notifications will fade after 10 seconds or can be dismissed. https://github.com/tameraydin/ngToast Change-Id: I1053534cd1ab189ae5c2ac07e2a922acea231c70 Signed-off-by: beccabroek <beccabroek@gmail.com>
* SNMP: Use lowerCamelCase for varsGunnar Mills2018-11-021-2/+2
| | | | | | | Following https://google.github.io/styleguide/jsguide.html. Change-Id: Ib7704018622571cf1701d3a525dc01297bed7243 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Only update SNMP fields if changedGunnar Mills2018-11-021-2/+2
| | | | | | | | | Use ng-change to determine if the SNMP fields, Address and Port, have changed and should be updated. Tested: Only see the rest calls when the fields have changed. Change-Id: I324c9c422a8b6dfb8816925167953e16099f8044 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove SNMP ManagersGunnar Mills2018-10-291-5/+6
| | | | | | | | | | Allow the user to remove SNMP Managers. If the SNMP Manager being removed exists in the backend, make a call to remove it. Tested: Removed SNMP Managers on a Witherspoon Change-Id: Ib392cda30754adfaa58f6301592c2d666ff2c29e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add and modify SNMP ManagersGunnar Mills2018-10-291-6/+19
| | | | | | | | This allows the user to add and edit SNMP managers. Tested: Added SNMP managers on a Witherspoon. Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove tabs from HTML filesGunnar Mills2018-09-251-16/+16
| | | | | | | | | | | | From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time. Don't use tabs or mix tabs and spaces for indentation." Tested: Manual regression testing on a Witherspoon. Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Create new SNMP Settings pageGunnar Mills2018-09-101-0/+19
Created new page to display SNMP Managers. Display the SNMP Manager's IP and port. https://github.com/openbmc/phosphor-snmp/blob/master/docs/snmp-configuration.md Future commits will allow the user to add and delete SNMP managers. Change-Id: Ia5d633c11728a580c06b25c412e8673925cdc597 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
OpenPOWER on IntegriCloud