summaryrefslogtreecommitdiffstats
path: root/app/configuration/controllers/network-controller.html
Commit message (Collapse)AuthorAgeFilesLines
* Fix icon-warning syntax errorDerick Montague2019-10-091-1/+1
| | | | | | | | | There were a few instances of the icon-warning icon that didn't include the file extenstion needed to when adding the file attribute property in the icon directive. Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1
* Clean up iconsYoshie Muranaka2019-10-021-1/+1
| | | | | | | | | | | | | | | Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files. - Moved/removed on, off, critical, warning svg icons from assets directory - Updated background-image status icons to use <icon> or <status-icon> directive Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88
* Fix IE11 remove button on network settingsDixsie Wolmers2019-08-291-2/+2
| | | | | | | | | - Adds button type to buttons for IPv4 and DNS Tested: Verified remove button deletes IPv4 and DNS server Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I7827f49a910c14b9df0575f678d8f121258446f6
* Consolidate button stylesYoshie Muranaka2019-06-211-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
* Resolve accessibility isssuesDerick Montague2019-04-081-42/+52
| | | | | | | | | | | | | | | | | | - Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes. Resolves openbmc/phosphor-webui#76 Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
* Center modals and fix sizingbeccabroek2019-03-261-0/+1
| | | | | | | | | | | | | | | | | | Previously the modals were not centered on the screen and the size of the modal was set to 50% of the screen, leading to a lot of white space within modals with less content. This sizes the modal based on the amount of content within and centers the modal. Also adds the grey modal overlay to the 'confirm network settings' modal to be consistent with the other pages. Resolves openbmc/phosphor-webui#35 Tested: Viewed all modals currently in GUI (Firmware page, network page, and overview page) and modals were sized correctly and appeared with the modal overlay in the background. Change-Id: Ie35d179810d36b8bcbbf39dc1302e773387fa788 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Clean up headersbeccabroek2019-02-191-4/+4
| | | | | | | | | | | | | | Updates headers to match style guide and makes them consistent throughout pages in the GUI. Removes instances where a header element existed and a different header style was being applied. For example, <h2 class="h4"> Tested: Ran GUI locally and verified that headers look consistent and have the appropriate sizing while using Chrome, Firefox and Safari. Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add toast to Network Settings pagebeccabroek2019-01-231-2/+0
| | | | | | | | Displays error message if any settings fail to save and success if all succeed on the Network Settings page. Change-Id: Ifddf1822ba59753a217d1ec257b8d0ca870cceed Signed-off-by: beccabroek <beccabroek@gmail.com>
* Update code styling for network pagebeccabroek2018-10-091-9/+9
| | | | | | | | | | Now that the following style guide is being used: https://google.github.io/styleguide/jsguide.html#naming Some of the variable naming in this class needs to be updated. Change-Id: I6ca7a0ea7255ab2314bb4b5fc2d89cff9006039a Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add and Update IPV4 addressbeccabroek2018-10-091-7/+14
| | | | | | | | | | | | | | | | | | This allows user to add IPV4 addresses and updates logic for editing IPV4 addresses. Resolves openbmc/phosphor-webui#12 Tested: Added, removed and modified IPV4 addresses, called API to verify that addresses had been correctly modified. Verified that if address had not been modified, no change was made for that address. Change-Id: I3dd25565f4f610dce2023e23348f6eb8d00add3d Signed-off-by: beccabroek <beccabroek@gmail.com>
* Remove IPV4 addressesbeccabroek2018-10-041-18/+21
| | | | | | | | Tested: Able to remove existing IPV4 addresses. Change-Id: I772bee6ad6b68bc0a69351f3e5386acc659241ef Signed-off-by: beccabroek <beccabroek@gmail.com>
* Remove tabs from HTML filesGunnar Mills2018-09-251-108/+108
| | | | | | | | | | | | From https://google.github.io/styleguide/htmlcssguide.html "Indentation Indent by 2 spaces at a time. Don't use tabs or mix tabs and spaces for indentation." Tested: Manual regression testing on a Witherspoon. Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Button to remove DNS serverbeccabroek2018-09-181-7/+10
| | | | | | | | | | | | | Added button to remove DNS server from Nameservers list. Resolves openbmc/phosphor-webui#11 Tested: Added and was able to remove DNS servers from list. Page updated appropriately. Change-Id: I64e9d2499465f1aa5f9f34c831961578abf32b2b Signed-off-by: beccabroek <beccabroek@gmail.com>
* Set time fieldsGunnar Mills2018-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Squashed 5 commits to set the date-time fields: time mode, time owner, BMC time, and host time. Also included is a commit to display the timezone. Set time mode Moved the selection of NTP vs Manual (time mode) to a radio button. Added code to allow the user set it. Tested: Set the time mode on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Set time owner The time owner is now a dropdown and is set when "Save settings" is pressed. Tested: Set the time owner on a Witherspoon Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Set the BMC and Host time The BMC and host have the same time except when time mode is split. Only need to set BMC or host time when time mode is not split. When time mode is split, set both. Use time owner to determine which to set. https://github.com/openbmc/phosphor-time-manager#time-settings Have date and time as two separate inputs, this is due to Firefox not supporting "datetime-local". The "date" and "time" input fields are more widely supported. https://caniuse.com/#feat=input-datetime The idea for 2 separate input fields came from: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local Must set the time mode and time owner before setting the time, this is due to permissions of who can set the time. Tested: Set the date and time on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Add NTP Servers The user can now view and set NTP Servers. Moved setFocusOnNewInput to a common directive since it is used on the NTP Servers and the DNS Servers on the network page. Even though NTPServers is a network interface specific path (e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts like a global setting, openbmc/phosphor-time-manager#4. Using eth0 for setting and getting the NTP Servers until NTPServers is moved to a non-network interface specific path. In Redfish, NTPServers is a non-network interface specific. Tested: Set NTP Servers on a Witherspoon. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Add timezone Added the timezone for the host and bmc date time. The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)". I got this from https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript and choose this formatting over something like "America/Chicago". Tested: See the timezone on a Witherspoon Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove hack for 1/0 booleansGunnar Mills2018-09-041-3/+2
| | | | | | | | | | | | With https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c and https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd28792810aa718cdee merged, this is no longer needed. This code removed here was breaking displaying the DHCP value. Change-Id: I465908190b1254238da8699a324a31a51771dace Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Focus on newly created DNS server fieldGunnar Mills2018-08-071-3/+3
| | | | | | | | | | | | | | | | | | | Got feedback from IBM's design team that to help usability after adding a DNS Server field, focus on the newly created DNS server field. Decided to go with a directive instead of putting this in a controller after reading: https://stackoverflow.com/questions/22292832/angular-ng-init-pass-element-to-scope, https://github.com/angular/angular.js/issues/9031, https://groups.google.com/forum/#!topic/angular/6uxWl8Z0DPw Having dom manipulation code in the controller is frowned upon. Tested: Verified the field is in focus (i.e. the cursor is in the textbox). Change-Id: Ia548361e7ac47363e05ea2963807bca0c5bf51e2 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add "Add new DNS server" buttonGunnar Mills2018-06-141-0/+1
| | | | | | | | | | | Added a button which allows the user to add new DNS Servers. After pressing the button a new empty field appears. Resolves openbmc/openbmc#3089 Tested: Added several new DNS Servers on a Witherspoon. Change-Id: Ic6a6d2b798ad177b0e9aeb64ba3e4993af442305 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update DNS Servers on "Save settings"Gunnar Mills2018-06-141-6/+5
| | | | | | | | | | | | | | | "Nameservers" is called "DNS Servers" on the GUI. Update the property if it has changed when the user hits Save settings and confirms. Had difficulties getting the DNS input fields to update the interface.Nameservers array. The "ng-blur="interface.Nameservers[$index] = dns" solution is from: https://stackoverflow.com/questions/13714884/difficulty-with-ng-model-ng-repeat-and-inputs Tested: Changed some DNS Servers on a Witherspoon. Change-Id: Ib9c4be044d0725ac50e57e2733c3dc2ef8e29053 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add IPV4 properties parameter validationGunnar Mills2018-06-141-1/+2
| | | | | | | | | | | | | | | | | | | Added parameter validation for the IPV4 properties: IP Address, Gateway, and Netmask prefix length. This is important since we delete the IPV4 interface before adding the new one (i.e. if the add is unsuccessful we are down an IPV4 interface). This validation helps to prevent some of the unsuccessful adds. Took the logic from the network manager valid parameter checks: https://github.com/openbmc/phosphor-networkd/blob/master/util.cpp#L217 Moved "Netmask Prefix Length" to a "number" to do this. It should have been a number. Tested: A variety of good and bad values. Change-Id: Idf4486489097bc426164b9543ea8c05eb54a2bf8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add loading spinnerGunnar Mills2018-06-061-0/+1
| | | | | | | | | Added a loading spinner that appears when set network settings are confirmed. This fits with the other pages such as firmware update. Tested: See the spinner when Save settings are confirmed. Change-Id: Iec321e036ad7a81d960109397b3a60ffdf256062 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set DHCP on "Save settings"Gunnar Mills2018-06-061-2/+3
| | | | | | | | | | | | | Set the DHCP enabled field when the user selects "Save settings" and accepts the popup. Added a TODO for issue #3154, Rest server should return a proper JSON bool. Resolves openbmc/openbmc#3165 Tested: Set "Obtain an IP address automatically using DHCP" on a Witherspoon. Change-Id: I45c817e3ddd8bf9c4f582460b1f9230e38548ff8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set Hostname on "Save settings"Gunnar Mills2018-06-061-1/+1
| | | | | | | | | Set the Hostname field when the user selects "Save settings" and accepts the popup. Before Hostname was readonly. Tested: Set the Hostname on a Witherspoon Change-Id: I9de840ee9d52ec4a9ae1fd69d4ea27f62b0baf17 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Replace "Domain Name" with "Default Gateway"Gunnar Mills2018-05-251-2/+2
| | | | | | | | | | | "Domain Name" is not as important of a network settings as "Default Gateway". Remove it for now, later we will add fields for the other network settings but getting the basic network settings going for now. To setup the network, the user needs to configure the Default Gateway, MAC Address, IP, Gateway, and netmask. Change-Id: I27066dc188c3c30a01051b473a7ce10837d40fab Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Replace "Origin" with "Netmask Prefix Length"Gunnar Mills2018-05-251-2/+2
| | | | | | | | | | Origin is not an important network setting, remove it, and add "Netmask Prefix Length" which is an important network setting. "Netmask Prefix Length" is called PrefixLength in the REST API. To help clarify call this field "Netmask Prefix Length". Change-Id: I59d99e98dabf8b53e74c81abb24d96b4026c2247 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add confirm "Change network settings" popupGunnar Mills2018-05-251-1/+18
| | | | | | | | | A modal appears when the user clicks "Save settings". This modal warns the user of the dangers of changing network settings. Change-Id: I20e45e8a814d9c5e3d048a0ed2523025f55d0c4d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Reload the page on a CancelGunnar Mills2018-05-251-1/+1
| | | | | | | | | When the Cancel button is hit on the network settings page, reload the page, refreshing the network settings. Change-Id: Icc3d51e9b319bd70f7c7ab5b911b17728b5273b4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Set MAC address on "Save Settings"Gunnar Mills2018-05-251-3/+5
| | | | | | | | | Make a REST call to set the MAC address when the "Save Settings" button is pressed. Tested: Verified the MAC Address is set. Change-Id: I39f6d4688842b3453fd219795d07f819ba4ba481 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Updating network settingsIftekharul Islam2017-11-021-31/+24
| | | | | | | Adding display network settings info in network settings page Change-Id: I5ab3b399445b8d2d6422f907dc4c5a477bfc794d Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Updating images and stlesIftekharul Islam2017-11-021-4/+2
| | | | | | | Updating images and styles after code merge conflicts Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* added confirmation modalMichael Davis2017-10-091-2/+4
| | | | | Change-Id: If1bdfd21b34cba5944c1acc69e90ca35ea0189c0 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* cleaned up empty class attributesMichael Davis2017-10-091-3/+3
| | | | | Change-Id: Ic285c863194da08ebc7ae683fc4247527bed4db8 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Misc CSS fixesMichael Davis2017-09-201-33/+40
| | | | | | | | | | | | | | | * set max content width to 960px * created mixin for bold font * move app-header content to global header * minor global changes * changed input alignment for network config inputs * added pop-out button class * changed lightgrey color * fixed accordion header actions responsiveness * fixed input box border colors Change-Id: Iffe26d526439d7f2bb6808528a975ab7374ff1b2 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Create network settings templateMichael Davis2017-09-201-3/+87
| | | | | Change-Id: Id2f5a5ba3e13885c081bbd5b8e694793ecc49d93 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Change navigation structureIftekharul Islam2017-09-201-0/+5
Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18 Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
OpenPOWER on IntegriCloud