summaryrefslogtreecommitdiffstats
path: root/app/configuration/controllers/firmware-controller.js
Commit message (Collapse)AuthorAgeFilesLines
* Remove firmware reboot timeoutYoshie Muranaka2019-11-141-20/+8
| | | | | | | | | A 10 second timeout was used as a tempoary work-around before rebooting the BMC on the firmware page–removing the timeout since it is no longer needed. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I6a95d5f5bb377d3fd3cc0802f7fb3d6d0f177870
* Add error message when image fails to activateDixsie Wolmers2019-10-111-3/+9
| | | | | | | | | | | | | | If an image fails to activate a toast message is displayed. Tested on Witherspoon with master build image and field mode turned on. When image fails to activate, the failed activation status response returns a 200 ok and an error toast is displayed. Tested with field mode turned off to verify image activates and BMC reboots. Tested on all browsers. Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I517f184549673e7b807cc0a553a728d05d6dbba1
* Firmware: Remove unused interpolateGunnar Mills2019-05-231-3/+2
| | | | | | | | | | | | | Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/90ae95eb6f5f30e3863f24ad364b111258ea4ee4#diff-44385b1119c2cae41d7331ab4a5cd5fe moved to ngToast (later toastService) and removed the use of interpolate. Tested: Build this and the commits below and loaded onto a Witherspoon system. Uploaded an image and activated it. Change-Id: I161c7860cec006dc434bc00495b25b588f069775 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix activate image and reboot BMCDixsie Wolmers2019-05-131-3/+5
| | | | | | | | | | | | | - Change bmcReboot callback in apiutils.js to HTTP request that returns a promise that is resolved with response object - Remove emitted 'user-logged-in' as it is not needed to reboot BMC on firmware controller and bmc reboot controller - Add toast message for visual confirmation of successful BMC reboot Tested: On Server Configuration > Firmware page uploaded new image to activate and automatically reboot. After 2-3 minutes confirmed image activated and then BMC rebooted after image activation. Tested Server Control > Reboot BMC page by selecting Reboot BMC, confirmed BMC rebooted. Resolves openbmc/phosphor-webui#79 Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ied6809ad1ed6cc3c73ac5c818c7a06607810c396
* Firmware page upload not working in some casesbeccabroek2019-04-111-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | Upload was not working in some cases because of two separate issues. Inline onchange is no longer executed in Chrome. This removes the inline onchange event since it was updating a variable not being used anyway. This also updates the click-outside directive as it was missing [ ] brackets that were necessary and throwing an error in the console when loaded onto a witherspoon. see https://developer.chrome.com/extensions/contentSecurityPolicy and https://stackoverflow.com/questions/35126898/error-after-minifica tion-of-angular-js-error-injectorunpr-unknown-provider Resolves openbmc/phosphor-webui#77 Tested: Able to upload image onto Witherspoon. Click-outside directive worked when GUI was mounted on a Witherspoon Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add role alert to toastsbeccabroek2019-02-061-14/+16
| | | | | | | | | | For accessibility reasons, 'role="alert" is required for toast messages. This notifies screen readers that an error or success message has appeared. Adds a service layer for toast messages that adds the role attribute to the message. Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Add toast to Firmware pagebeccabroek2019-01-231-75/+24
| | | | | | | Replace error and success messages with toast notifications. Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Revert "Remove unused dataService"Gunnar Mills2018-09-261-4/+6
| | | | | | | | | This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b. dataService is used in powerOn(), warmReboot() and isServerOff(). Change-Id: I8635ac88f93b6354ea7d352f92c9a7f4281e21a5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused dataServiceGunnar Mills2018-09-261-6/+4
| | | | | Change-Id: I99e0d16a56908beb1397bb4c15390c72c3b2f3f5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Activate image and reboot hostbeccabroek2018-09-191-3/+57
| | | | | | | | | | | | | | | | | | | When activating a host image, gives the option to: a) Activate image without booting b) Activate image and boot host. If server is in 'off' status the option is to power on. If the server is in 'unavailable', 'on', or 'error' status the option is to reboot Also updated polling during boot and reboot to use /subscribe API. Resolves openbmc/openbmc#3323 Tested: The GUI displays the options and boots / reboots appropriately based on server status. Change-Id: I62c19e094ecc7112263c26844fcd30b2bf3c2b84 Signed-off-by: beccabroek <rebecca.shaw@ibm.com>
* Move to clang-format-6.0Gunnar Mills2018-09-041-1/+0
| | | | | | | The docker image moved from clang-format-5.0 to clang-format-6.0. Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Format code using clang-format-5.0Andrew Geissler2018-05-241-274/+284
| | | | | | | | Once merged, this repository will have CI enforce the coding guidelines in the .clang-format file. Change-Id: I96a05972665f9c67625c6850c3da25edc540be06 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Run js-beautify and fixjsstyle on codeAndrew Geissler2018-05-241-285/+288
| | | | | | | | | | | Found this pointer on stackoverflow: https://stackoverflow.com/a/31660434/5508494 End goal is to get the code formatted well enough that clang format will run correctly against it. Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Only reboot BMC if it is BMC image activationAndrew Geissler2018-05-231-1/+2
| | | | | | | | | | | | | | | | | | | Some internal testing found that when a server image is uploaded and activated, the BMC reboots. This is because the reboot variable defaults to true and it is not manipulated in the server image activate code path, but it shares the common activate image code path with the BMC which look at this variable to determine if it should reboot the BMC. Testing: Verified server image activate did not result in BMC rebooting. Verified when option to reboot BMC after BMC update, that BMC rebooted. Verified when option to not reboot BMC after BMC update, that BMC did not reboot. Resolves openbmc/openbmc#3188 Change-Id: Ib2f6b9cb6af27c11ad0f5c6fc33f161ac3ffa611 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Display success message after uploading imageCamVan Nguyen2018-05-141-2/+7
| | | | | | | | | | | Fix includes: - Displaying an 'Upload complete' message and clearing the image's file name if the upload succeeds. - Displaying an error pop-up with reason for failure when the upload fails. Change-Id: Id9474b62ed62e1b40ffa018eb273abbf19be26ce Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Refresh the firmware page after downloading imageCamVan Nguyen2018-05-131-11/+59
| | | | | | | | | | | | | | | | | Fix includes - Polling the number of software objects for a new image. During which time the 'Downloading in progress' status bar will be displayed. A 2-minute timeout is used. - Displaying a 'Download complete' message if the download succeeds and refreshing the firmware page to show the new image once it is downloaded. - Displaying an error pop-up with reason for failure when the download fails. Resolves openbmc/openbmc#3054 Change-Id: I79a8b8c661c01474a12cef4af524cafdc2cee1fe Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Remove the version from each fileGunnar Mills2018-04-301-1/+0
| | | | | | | | Already have a Web UI version, no need to track the version of each file. These have not been getting updated. Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display error if error on uploadGunnar Mills2018-04-131-16/+15
| | | | | | | | | | | | | | | We were missing the rejected promise when image upload returned an error. Now with this change and https://gerrit.openbmc-project.xyz/#/c/9594/ image upload now uploads an image and refreshes the page to display the image or displays an error if the upload failed. Resolves openbmc/openbmc#2960 Tested: See an error if a bad image. GUI refreshes if the image was uploaded successfully. Change-Id: I5f4030fb29fc08aa65dd0d36e32368106c31a76b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Wait for 10 seconds before rebootingGunnar Mills2018-04-091-8/+18
| | | | | | | | | | | | | | | | | | After the image is active wait 10 seconds before rebooting if "activate and reboot" was selected. We had an issue, https://github.com/openbmc/openbmc/issues/2764, that a system could brick if the system reboots before the service to set the U-Boot variables is complete. Wait 10 seconds before rebooting to ensure this service is complete. This issue is fixed in newer images, but the user may be updating from an older image that does not that have this fix. Tested: Verified the system waits 10 seconds after the image becomes active before rebooting. Change-Id: I00115680cca14e50814e44c302d6134aca242d3f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display error if TFTP post failsGunnar Mills2018-04-091-31/+13
| | | | | | | | | | | | Display an error if the DownloadViaTFTP returns an error code. This code replaces some unused code. Resolves openbmc/openbmc#3029 Tested: Verified I see this error if the DownloadViaTFTP call returns an error code. Change-Id: I1547689059f45953b29aedda75c0599aec30079d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display error if TFTP field emptyGunnar Mills2018-04-091-0/+6
| | | | | | | | | | | If either TFTP Server IP Address or File Name is empty for the "Download image file from TFTP server" function, return and display an error. Tested: Verified I see this error if either field is empty. Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Activate firmware and reboot buttonGunnar Mills2018-04-051-0/+12
| | | | | | | | | | | | | | | Added a radio button to activate firmware and reboot the BMC. If the "Activate firmware and reboot" option is selected, reboot the BMC after activating the firmware. The user is then logged out. Resolves openbmc/openbmc#3027 Tested: When "Activate firmware and reboot" option is selected, the BMC reboots after activating. When it is not selected, the BMC image just activates. Change-Id: I07293dc8a6ddfac4cf58ba2c1d1352c9afd6fa8d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update the GUI after an image activatedGunnar Mills2018-04-041-16/+55
| | | | | | | | | | | | | | | | | | When activating an image the firmware page does not refresh after the image is activated and show the image as "Active". To get the image to show as "Active", a user must refresh the page. The activating image code now waits until the image is activated and the REST call returns "Active" or "Failed" and then refreshes the page. Resolves openbmc/openbmc#2966 Tested: Activated an image and verfied it refreshed after "Active". Change-Id: Ic68e3c9e6cb5c2ea4f5d66f48fd09252c4807f26 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add server confirm activation modalGunnar Mills2018-03-291-1/+3
| | | | | | | | | | | | | Added text specific to server images that appears in the activation modal when a "server" image is activated. The "server" and "BMC" images use the same modal, but the text and if radio buttons appear differ. Resolves openbmc/openbmc#2967 Tested: Activated both a server and BMC image on a Witherspoon. Change-Id: I83693641ebfef802d403141ade55a950f359ba6e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove "reboot" modalGunnar Mills2018-03-291-5/+0
| | | | | | | | This modal was not used. Tested: Uploaded and activated an image on a Witherspoon. Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move from "Preserve settings" to "Confirm Activation"Gunnar Mills2018-03-291-5/+7
| | | | | | | | | | | | | | | | | The "Preserve settings" popup that showed when a user activated an image was not useful and did not do anything. Saving network settings prior to activation is not needed so moved to a "Confirm Activation" modal. This modal will eventually include an "activate BMC firmware and reboot" selection, openbmc/openbmc#3027, for now it only holds the one selection. The "Preserve settings" and now this "Confirm Activation" modal both appear on "server" and "BMC" images, this is a bug that is fixed in a later commit. Tested: Activated an image on a Witherspoon machine. Change-Id: I7176d5a314ea325e6e94606ef07b32786ede64e9 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Confirm changing priority on all priority changesGunnar Mills2018-03-271-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | Before the confirm priority change modal would only appear if the user is changing the priority from priority "1" to "0" or priority "0" to "1". This doesn't work because if two images existed, a "functional" priority "1" image and an "active" priority "2" image the confirm would not appear on a priority change and it should. I believe this logic came from the belief that the "functional" image is always priority "0" and therefore only display this confirm when the "functional" image is affected by the change. The functional image is not always priority "0" and with only 2 "active" images supported (only "active" images have a priority) (the "functional" image is an "active" image) all priority changes affect the functional image so adding this confirm for all priority changes. Tested: See this confirm on every priority change. Change-Id: Icd113686f15a2e82ead72d04677335ee635cf668 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display the version when confirming "Delete"Gunnar Mills2018-03-051-1/+3
| | | | | | | | | | | When confirming an image delete the GUI now displays "Delete firmware v2.0-165-ge571670?" Resolves openbmc/openbmc#2961 Tested: Confirmed text is correct and delete works Change-Id: Iad23908fbafc9514044be7770d269e723b35cb58 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display Version when confirming changing priorityGunnar Mills2018-03-051-1/+3
| | | | | | | | | | | | | | | | | Before the GUI displayed when changing the priority: "Change firmware e129c45b priority?" It now displays: "Change firmware v2.0-165-ge571670 priority?" This is important since the user never sees the image ID (e.g. e129c45b) and always sees the image version (e.g. v2.0-165-ge571670). Tested: confirmed text is correct and change priority works Change-Id: Ie9403aaade8a307b6de54feef20adc2b04e2b80b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove trailing spaces from filesGunnar Mills2018-03-051-1/+1
| | | | | | Tested: Manually tested GUI for any regressions Change-Id: I8c0922b7bd67b03b07e8880bc4dba3b862220b33 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix the "Upload firmware" buttonGunnar Mills2018-02-231-20/+15
| | | | | | | | | | | | | | | | | The "Upload firmware" button was not calling the uploadImage() function in api-utils.js. The uploadImage() function was not making the correct call to the /upload/image REST API. Removed the confirmUpload function since not needed on a upload since the user has already selected the file they want to upload, pressed "Open", and then pressed the "Upload firmware" button. Resolves openbmc/openbmc#2770 Tested: Uploaded several images to a Witherspoon system. Change-Id: Ia0e0ffba501066f59a4355b8f61595e30aea3f98 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Updating network settingsIftekharul Islam2017-11-021-4/+30
| | | | | | | Adding display network settings info in network settings page Change-Id: I5ab3b399445b8d2d6422f907dc4c5a477bfc794d Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Updating login structureIftekharul Islam2017-11-021-2/+70
| | | | | | | Updated login structure with a field where user can manually add server hostname if it is not populated automatically Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* JS updates for gui functionsMichael Davis2017-10-091-4/+4
| | | | | Change-Id: I115cfedb540ed159284cacbcca30d599465db94a Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Implement firmware upload functionIftekharul Islam2017-09-201-0/+93
| | | | | Change-Id: Ie89793ec9add1fc9e5241b422cfff64784f7b078 Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
* add firmware pageMichael Davis2017-09-201-12/+0
| | | | | Change-Id: I3d9a2ec068e3542a848dada63a6bbebe9869bf2f Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* moved firmware into config sectionMichael Davis2017-09-201-0/+46
Change-Id: I9579c85d7d9d7268d9e35637809fa26d623f0310 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
OpenPOWER on IntegriCloud