| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
Adding a profile settings page so readonly and operator
roles are able to change their own password.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Iee9536255ad47f4df4af8746c1e01da37c407f2b
|
| |
|
|
|
|
|
|
|
| |
Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ie1ef89023a043a70a0126a21be57febb9afae19a
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new toast notification types, warn and info,
and updated visual styling. All toasts will need
to be manually closed by clicking the 'X' close icon,
except a success toast which will be dismissed
automatically after 10 secs.
- Small updates to critical and success/on icon
- Added new colors for toast status background colors
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I9077109042621b2d3346b4121d6344da502b6b26
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding styles to make sure the Bootstrap tooltip
directive works by adding opacity to 'in' class that
is added to the tooltip when triggered. This commit
also includes additional custom styles to override
defaults.
We will need these styles to implement tooltips which
are included in upcoming changes like the firmware
page redesign.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I08e8f1f1762dcc24f8a803b87348a5bff25bd65b
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.
- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes aren't currently implemented on any table.
It will be added to event logs and local user table.
- Create tableCheckbox component to handle custom styles
and indeterminate state which needs to be set with JS
- Update tableComponent layout to allow transition for
toolbar. Updated user-accounts layout and styles to
account for these changes
Tested on Chrome, Safari, Firefox, Edge, IE
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic57a090db1ef66f9d33facfdc425db868ae8d8c6
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will be able to either copy the
code or download the code in a txt file.
Tested: loaded onto Witherspoon and able to view on certificate
management page. Click on generate csr and type in necessary
(or any additional info), then click on generate CSR. The CSR
code is then visible and is able to be copied or downloaded. In
error state in which CSR code is unable to generate, the modal
closes and an error toast message appears. FYI: Sometimes you
have to reboot system in order for csr to successfully generate.y
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d
|
| |
|
|
|
|
|
|
|
| |
This commit will add a new password visibility toggle directive.
The new directive was added to the local user management,
user modal password input fields.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I4e2baf53eec04aaff1bba26948779de6e447e3e7
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit will introduce a reusable data table component.
By creating a reusable component, we can ensure tables in the
GUI will look consistent and common table actions (sort, select row)
are shared.
- Created new components directory to store shared components
- Add password-confirmation directive
- Remove some error handling from API utils so it can be
handled in the UI
TODO:
- Add show/hide toggle to password fields
- Enhance table component with icons
- Manual user unlock
- Batch table actions
- Role table
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I03c95874d2942a2450a5da2f1d2a8bb895aa1746
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds text to indicate the current state of the toggle button to meet
accessibility guidelines
- Update size, color, and focus of toggle component to fix
DAP violations
- Add page, section, and list-pair layout patterns established
on the power usage page to begin a pattern for consistent
page layout
- Add form__field and form__actions to help with form layout
consistency.
Tested: Verified toggle functions in the GUI and tested with screen reader. Passes DAP.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Iaa8646b1179cc307971065c455f4b9448095d1ec
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss. Any usage of CSS color properties should
refer to the mapped color variables in colors.scss.
- Removed tags.scss file since tag components no longer used
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client cert
are implemented in this commit, with the ability to add
more types as needed by adding them to the constants.js
CERTIFICATE_TYPES array.
Also provides the ability to replace a certificate once
it is added.
Resolves openbmc/phosphor-webui#43
Tested: loaded onto a witherspoon and able to view and
replace both the HTTPS certificate and the
LDAP certificate. GUI only allows to upload an
LDAP certificate if one doesn't already exist.
The GUI limits the user to one file per type as
expected at this time and provides the
appropriate validation messages. Alert messages
appear above the table if the certificate is
expired or within 30 days of expiring.
Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Remote logging enables the user to configure a remote
server to stream out local logs. This feature will be
available on the Event Log page. The user can add a
remote server, edit/change an existing server
configuration and remove/disable the remote server.
Resolves openbmc/phosphor-webui#68
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will create more visual consistency between the components
in the GUI since there are elements, such as text fields and
dropdowns that are styled with straight corners.
- Removes border radius from buttons
- Removes some redundant styles
- Adds input types that aren't currently inheriting
defined styles
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding ngAnimation dependency created added animation to pages during
route or location changes. Added transitions to create an elegant
transition.
Tested: I navigated to every page including logging in
and out in Chrome, Firefox and Safari to assure all
browsers handle the transition consistently.
Resolves openbmc/phosphor-webui#86
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I14fa1bd790e80f977b7a0ccceccc3eb20ce33ae6
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds page to manage virtual media devices. User selects file
and pushes 'start' button to establish websocket connection.
nbdServerService added to provide ability for user to navigate
away from the page and return with the ability to see the current
active sessions.
Currently only supports 1 Virtual Media device.
Resolves openbmc/phosphor-webui#40
Tested: uploaded ubuntu image file, started the connection and
mounted virtual media device from host console. Able to see Ubuntu
image file. Also uploaded file and navigated away from the page,
checking that the websocket remained open and was sending /
recieving messages. Finally, tested that when connection
was stopped, 'USB disconnect' log was present in host console.
Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add pattern for no spaces
- Fix character count
- Prepopulate hostname in input field
- Show error for invalid input
- Improve form accessibility
- Correct global disabled primary button style
Resolves openbmc/phosphor-webui#71
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ia0601ac7c52229d0606dc5b13397b468fa81426d
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use background-image strategy to add caret to dropdowns
- Standardize implementation by including mixin to dropdown__button
class and removing styled pseudo element
Resolves ibm-openbmc/dev#478
Tested: Running locally on Chrome only. Ran into network request
errors for newly added svg assets when mounting overlay
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I714c2515282676f368eafb2560177d2935680e23
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Change #3C6DF0 to #2D60E5
- Change #E62325 to #DA1416
Tested: I spot tested the Server Overview, the
Event log and System logs pages to verify color changes and overall
validate the update does not negatively impact the visual integrity
of the app.
Resolves openbmc/phosphor-webui#70
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I2315527a98937176b3e3a2a2118e1798fa4c9e5d
|
| |
|
|
|
|
|
|
|
| |
Changes color of secondary button text to be more readable.
Resolves openbmc/phosphor-webui#66
Change-Id: I3d7622a3556139a8c984590bcc8db5c34cefc73e
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">
Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.
Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bootstrap 4 columns in Safari are not working as expected,
causing issues with the layout on the login and overview
pages. Small CSS change resolves issue, see
https://github.com/twbs/bootstrap/issues/24219
Tested: Layout appears to be fixed using Safari. No pages
are affected visually by the change when using Chrome or
Firefox.
Change-Id: I79bf6ef3734703e4f610ee7f95b75625538761c2
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed pattern to be used moving forward,
as form validation is added to additional pages.
Validation error messages are shown on $touched and on submit.
Unreachable Server and Invalid username and password error messages
remain until input is no longer $pristine after form submission.
In addition, this removes unneeded and unused css styling
Resolves openbmc/phosphor-webui#47
Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
| |
-Changing the hover color to be white as
hover and selected states need to look
different.
Change-Id: I65a201b127408a698e50563f2b555fd5c55935dd
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requires, not hardcoded paths. This was
required to make the packaging work correctly.
3. Add babel config to do translation.
4. Update angularjs directive calls to use the angular 1.6 syntax for
promises intead of success and fail.
https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http
5. As a consequence of using NPM/webpack, the versions of angular and
associated modules that were checked in have been updated.
Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
| |
|
|
|
|
|
| |
Updating images and styles after code merge conflicts
Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ie5bd4342fde5809a9ad793bfedf9079b0758de59
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id4a783d23e18be74048540310523079ec5613e8e
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I9d2895170c50c77b1cbf12fcc069492c9764c88a
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I0b2ee399243f0bc3e5ed44bc578a0d153486ed55
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Id97de89d646bc0c980fd4f0849109047906383e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Idc6930c87f61217f9bf4daab5b82c418606cdf80
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ib2d1caf520302555b3bfb7b49cb69ae68b6bcfa8
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I2dd38d805ace1e7c8d3141a9858072df5c342331
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
| |
- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency
Change-Id: I3f497b2707991f7f628892a05734eea183a0d01d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I1722a4fbd1e9ac07162c9732d68dfea283a28aed
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ibea933c20071cc85201420ba1e31fedf9356f55b
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
|
|
|
|
| |
- changed buttons to spans since not being used in forms
- added aria roles to html elements
- changed low contrast colors
Change-Id: I56e784b226baa7f9b24346446a0a023fcea633d4
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
|
|
|
|
|
| |
- Changed "page last refreshed" label to "Data last refreshed"
- Changed "Configuration" label to "Server Configuration"
- adding flashing of header timestamp on click of "refresh" button
- moved "Server LED" under Server Configuration
Change-Id: I9971fd96da94514a7edc8e4977591c4de85f70c9
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ia64dfd7ae7e1fb3081d0d5de680b9afa3cab669d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If77d9119bc9335b5bd5e94ec1d201f6aa8969d0d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: If46c5dfa5656948747cbf4f2faacab9244f8e40c
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I13bae30e86330a8831d35f1d8a2f7da821324e37
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I9a9aa63802beac60a30e35a130a7ad73a3e80f0f
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Ib932b23aa891a1dd3ad3942dc9c8fbcf94f87f2b
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: Iedcaaf71a2ac48eb885ac92d9efee0623e949289
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I73c423b867dfd5d4fadfe5bc8d2d6f30d1f632e8
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I7d4083be0474f7d537c8b60bb515ee00b91cb24b
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|