| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Adding a profile settings page so readonly and operator
roles are able to change their own password.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Iee9536255ad47f4df4af8746c1e01da37c407f2b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- New navigation provides intuitive structure for showing relationship
between sections and pages
- Menu keeps an open state, which allows easy clicking to sibling pages
- Ability to preview all page sections w/o hover over blocking page content
- Allows user to see where they are within navigation at all times
Tested: Opened each page and confirmed new navigation worked, clicked through
to all pages successfully.
Change-Id: Ie10dc95d8e15ee9bf89a3bec9ff231c0a7065ed9
Signed-off-by: Kathy Pine <kathryn.elainex.pine@intel.com>
|
|
|
|
|
|
|
|
|
| |
Loader was updated with loading icon svg. Added inline style
for loading icon and added loader svg to status-icon directive.
Status icons will be used in file-upload component for firmware page update.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I15e6f9fa39a08fcc8cfe354f8ed4447aab6425a9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With introducing option to add multiple certificates there is a need to give
user a possibility to remove selected certificates, for example when they
expire.
This commit adds implementation of DELETE function to GUI.
A new icon will appear in action section on certificate table.
The delete icon will be enabled only for TrustStore certificates and disabled
for others which does not have support for delete option.
When user clicks on the delete icon then ‘user prompt’ is displayed and after
confirmation, proper redfish action is used to delete the certificate.
Middlewere implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25281
Backend implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-certificate-manager/+/25268
Tested on Chrome and Mozilla.
New icon appears in action section.
The delete option is available only for TrustStore certificates.
User is able to delete selected certificate.
Depends-On: I9781c5c79288ec5d080e80e42c63a55e471ddb77
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I68c5f54767d6982ae3cb00830b3a1b4f5e237bea
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change applies global styles to improve
page layout consistency and modal management
- Adds page and section styles
- Removes unused styles
- Creates individual html files for modals
- Updates certificate modals to bootstrap modal
- Updates global styles for input file field in file-upload.scss
TODO:
- Update certificate table with table component in separate commit
- Update CSR modal to use global form-field styles in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I9b800cb684740da1a9168294433e726efb0f9d0e
|
|
|
|
|
|
|
|
|
|
| |
Added height value of 100% to nav-icon in order to properly align
in IE11.
Tested on Chrome, Firefox, Safari, Edge and IE11.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I66b2d4de1b67f546e0709eab70a780a297efbb7a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a service is enabled, it must be disabled prior
to changing the service type, e.g change from OpenLDAP
to ActiveDirectory.
- Add check to determine if a service is already enabled
- Make two calls if service is already enabled. First to
disable existing service. Second to enable updated
service
- Remove toast message for ssl check and replace with
error message which also keeps submit button disabled
if the regex pattern is not met
Tested:
- Edge
- Safari
- Firefox
- Chrome
- IE 11
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I195eeb7d1cd3621681c18f4dd9aa4414eb079c09
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.
- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clicking the refresh button in the app header on the SoL and
KVM pages would fail to reload because the wrong element reference
is passed to the contructor after the reload. Angular recommends
using directives for any DOM manipulation.
- Use the $element ref availble in serial-console.js directive to
select DOM element to open the terminal
- Switch kvm controller to directive to be able to use element ref
in the link function to select DOM element to pass as target
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia7391e42bf335b8c3558d25df15c052db245ee3d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Fixes accessibility issues for table sort buttons,
fieldset legend, checkboxes and radio buttons
-Fixes tabbing to checkboxes
-Stops tabbing to disabled sort buttons by adding ng-disabled
-Removes aria-hidden from modals
Tested: Verified no violations using DAP tool.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I9ad240d5ed151a362c0000fdab3ebf1f2997b226
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection name to Local User Management
Resolves: openbmc/phosphor-webui#619
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39
Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.
Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Updated filters to use semantic markup (fieldset)
- Added check for input date type support and updated
expected date format to the legend
- Added error message if date format is invalid
- Updated layout to support error message
Tested the changes in the following browsers:
- Safari
- IE 11
- Chrome
- Edge
- Firefox
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: If0b874644b80640dc5bfd8211459c012807ea492
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.
Marta Mazur did a similar file and route move here as part of
supporting multiple Virtual Media endpoints:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218
Tested: Built and loaded on a Witherspoon. The VM route is now:
#/server-control/virtual-media. Was able to use the VM
panel.
Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table
TODO:
- Remove critical icon background image in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2e10bc3f3432331b6dd9354dbcd0e32480894ece
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes filter button screen reader friendly
and accessible.
- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidden and uses an aria-label attribute with
the value set to clear filter
Tested:
- Filter inputs clear on close button click
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ifcbe603c2771156fe7a03359b144e0a0acd5e3f1
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Converted both certificate expiration date and bmc date/time to EPOCH time to fix the bug
Tested: Go to Date and Time settings and change BMC time to be after or 30 days before a certificate expiration date.
Then either a warning or expiration icon and message will be displayed next to the date and message on top of the table.
To remove the expiration or warning date, upload a certificate that has an expiration date greater than 30 days after bmc time
set. The icon and warning message should now disappear.
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I9389fe3cce5a555945adf9c56180897a6be047bf
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds focus to "choose file" button when replacing certificate
- Adds input-file.scss to elements
Tested:
- Passes DAP
- Tabs correctly in all browsers
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I48c61f4176bc3e3fe55425dafc79e8f2edb934b2
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The root cause is that TextEncoder/TextDecoder does not support IE
More detail at https://caniuse.com/#feat=textencoder
One workable solution is to include text-encoder lib,
as this patch did.
Tested:
IE visit BMC and navigate to "#/server-control/remote-console"
SOL page is working well.
Change-Id: I5019c626afcf67916252db4115af7616c7a9759b
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
|
|
|
|
|
|
|
|
| |
Wrapped WebSocket constructor in try/catch block to avoid
compile errors in controller.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I38fbc1e5898b0b70d8a16e3f16a244e04e18347e
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactored button and icon markup on certificate management in order to trigger
click in IE11
Tested:
- Confirmed button functionality in Chrome, IE11, Firefox, Edge and Safari
- Buttons and icons pass DAP
- File upload inaccessible, unable to tab to "choose file" button
Will correct in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I6b0b9a56386a74b25a7a35d0cc03c9b0d32c3478
|
|
|
|
|
|
|
|
|
| |
Creating a separate table actions component to allow
row action customizations like disabling certain
actions and rendering different icons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I85e96045af27701f5ecc4af9bf824e248abccbf5
|
|
|
|
|
|
|
|
| |
This patchset enables CA certificate type to be uploaded
in the GUI.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I52953933f6fd3dbd363c42b887996942b99b358e
|
|
|
|
|
|
|
|
|
|
| |
Add 'connect-src' directive to Content Security Policy to allow
WebSocket connection.
Added additional error handling when Websocket connection
refused.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I83cfaa0b314099aea57ee7f2be75a0658462b2a9
|
|
|
|
|
|
|
|
|
| |
This commit will add a new password visibility toggle directive.
The new directive was added to the local user management,
user modal password input fields.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I4e2baf53eec04aaff1bba26948779de6e447e3e7
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit will introduce a reusable data table component.
By creating a reusable component, we can ensure tables in the
GUI will look consistent and common table actions (sort, select row)
are shared.
- Created new components directory to store shared components
- Add password-confirmation directive
- Remove some error handling from API utils so it can be
handled in the UI
TODO:
- Add show/hide toggle to password fields
- Enhance table component with icons
- Manual user unlock
- Batch table actions
- Role table
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I03c95874d2942a2450a5da2f1d2a8bb895aa1746
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use page, section, list-pair to establish
consistent layout
- Update header and overview page to use new
caret icon
- Reordered Server and BMC information to
accomodate small screen views
- Added chevron icons to create consistency
between header and server overview page
quick links
- Changed edit hostname text to use the
standard icon
- Added OR operator to short circuit the server
model, server serial number, and server manufacturer
to display N/A if the information is not available
Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit introduce two new columns on certificate table.
It should help user to differentiate multiple mTLS certificates.
Date format was changed to 'medium' one to accommodate two new columns.
Small corrections were made to action button paddings to make the icon better centered.
Tested: GUI tests were done on Chromium v74.0.3729 browser. Desktop and mobile version.
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I660b74dd8b50f854ebbdad1890bbf99b3675f4cd
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-exported icon-control.svg and icon-replace.svg to
resolve issues around sizing and overflow. These new icons
will allow us to remove CSS 'hacks' in place to prevent
unexpected focus state overflows and allow icon resizing
by changing the width on the icon class name. Small scss
updates were included to account for this fix.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I07bbe5bb0c82ee653f2342089c0c1373a51cc168
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client cert
are implemented in this commit, with the ability to add
more types as needed by adding them to the constants.js
CERTIFICATE_TYPES array.
Also provides the ability to replace a certificate once
it is added.
Resolves openbmc/phosphor-webui#43
Tested: loaded onto a witherspoon and able to view and
replace both the HTTPS certificate and the
LDAP certificate. GUI only allows to upload an
LDAP certificate if one doesn't already exist.
The GUI limits the user to one file per type as
expected at this time and provides the
appropriate validation messages. Alert messages
appear above the table if the certificate is
expired or within 30 days of expiring.
Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IBM has a need for more granular options for turning panels off
and on. Renamed redfishSupportEnabled, redfishEventLogDisabled.
By default, it continues to be enabled. Redfish is used for
user management already so this setting was a bit of misnomer
(i.e. it did not "turn off" Redfish use).
LDAP and Certificates, both in review, also use Redfish.
Moved to "Disable" so that if not defined in the config.json,
the panel is still visible.
A meta layer has to overwrite the config.json with
"redfishEventLogDisabled" : true to make the panel
not appear on the navigation.
Pushed a patch here to disable the Redfish Event Log page in
the meta-openpower layer:
https://gerrit.openbmc-project.xyz/c/openbmc/meta-openpower/+/22923
Pushed a patch here to remove the redfishSupportEnabled in
Intel's layer:
https://gerrit.openbmc-project.xyz/c/openbmc/meta-intel/+/22870
An improvement would be to not import if disabled.
Tested: Built Witherspoon with 22923.
Did not see "System logs" panel.
Change-Id: I8722f43191ec73d21d6a181223d00256dbcd062f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
The other panels capitalize the first word only.
E.g. Hardware status, Server power operations, and
Manage power usage. Follow this standard.
Change-Id: Icbbc2df25e1a3c9dd5e44db4c1d3f6a9f8252144
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patchset will fix the Unknown Provider error
caused by the toggle-flag directive by declaring the
required $document dependency.
Tested: Navigated to Event Log page and no longer seeing
the error in the browser console.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I446f0a1d120526dfa250862018dfa09b289cae74
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main navigation will follow a natural tabbing order.
When the secondary menu is expanded with the keyboard, the
first item in the secondary menu will be in focus.
Tabbing after the last item in the secondary menu will return
focus to the primary menu.
- Restructures markup so secondary menu is nested in primary
navigation
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I4ecb17ef6721ee443310f81e1554620352c145a4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed errorModalDetails and displayErrorModal from
dataService since they are no longer used.
errors.html was only active when displayErrorModal was true.
displayErrorModal was only true when activateErrorModal was
called.
activateErrorModal was removed in a previous
commit. activateErrorModal's only use was removed here:
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
Tested: Searched the repo. Built an image and loaded onto a
Witherspoon. No regressions observed.
Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds page to manage virtual media devices. User selects file
and pushes 'start' button to establish websocket connection.
nbdServerService added to provide ability for user to navigate
away from the page and return with the ability to see the current
active sessions.
Currently only supports 1 Virtual Media device.
Resolves openbmc/phosphor-webui#40
Tested: uploaded ubuntu image file, started the connection and
mounted virtual media device from host console. Able to see Ubuntu
image file. Also uploaded file and navigated away from the page,
checking that the websocket remained open and was sending /
recieving messages. Finally, tested that when connection
was stopped, 'USB disconnect' log was present in host console.
Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patchset adds the infrastructure to allow KVM sessions
through the webui. A websocket capable VNC/RFB connection
on the BMC is needed for KVM sessions.
To access, navigate to Server control -> KVM.
Tested: Ran obmc-ikvm on the BMC, added a KVM Handler to
Phosphor Rest Server, and was able to establish a
KVM session in the webui on a Witherspoon.
Change-Id: I7dda5bec41d270ae8d0913697714d4df4ec3a257
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upload was not working in some cases because of two separate
issues. Inline onchange is no longer executed in Chrome. This
removes the inline onchange event since it was updating a variable
not being used anyway. This also updates the click-outside
directive as it was missing [ ] brackets that were necessary and
throwing an error in the console when loaded onto a witherspoon.
see https://developer.chrome.com/extensions/contentSecurityPolicy
and
https://stackoverflow.com/questions/35126898/error-after-minifica
tion-of-angular-js-error-injectorunpr-unknown-provider
Resolves openbmc/phosphor-webui#77
Tested: Able to upload image onto Witherspoon. Click-outside directive
worked when GUI was mounted on a Witherspoon
Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding Filter support to system logs page
- Severity filter.
- Date filter with start and end date.
- Filter by Sensort Type.
Tested By:
Loaded System logs page with type selection
'Event' and check all filters.
Change-Id: I41eba4cd59c0f3c2933637bf0e207a3eca3214f1
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit implements the webui logs page
which will show all system logs depends
on user selection( SEL or Event or Oem). This
is based out of redfish systems log services.
- View logs with pagination.
- Search filter for logs view.
- Sort option with Type, Id, Severity, Date.
- Clear logs.
- Export logs.
UnitTest:
- Existing bmcweb send the system logs of EntryType
"Event". So Loaded UI, selected Type "Event" and
validated all the above mentioned operations.
Change-Id: I0384e475f7913ca66b6db5d64831583fb382f8d5
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make EWS SOL Screen size match the real BIOS console, need to
set the screen dynamically. Web page get terminal resolution from
config.json and calculate frame width and height base on the
resolution and fontsize. Web page use this width and height to
change the screen size. If no related configuration in config.json
the SOL Screen will keep the original size before this code change.
Tested By:
Add "customConsoleDisplaySize": {"width": 100, "height": 32} to
config.json, and open EWS Server Serial over LAN console page, the
size of console client can match 100*32 characters. Set console
redirection to 100*32 in BIOS setup page, the page show correctly
in this SOL client in EWS. After enter OS, the linux console can
show correctly in SOL client.
After remove "customConsoleDisplaySize" in config.json, the size
of console client in EWS show the same as the code change in this
patch.
Change-Id: I09bfe4e67db1387abcd57ee3a13b912957cf95b0
Signed-off-by: Yang Cheng <cheng.c.yang@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support VT100+ extensions for SOL on webui, add custom key
into xtermjs to handle key Backspace, DEL, HOME, END, INSERT,
PAGE UP, PAGE DOWN, F1 - F12.
Tested By:
After added item "customKeyEnable": true, "keyType" : "VT100+" into
iconfig.json.
Under EFI SHELL: Backspace, DEL, HOME, END, INSERT, PAGE UP, PAGE DOWN,
F1 - F12 keys can work as local keyboard in Web SOL.
Under linux with $TERM=vt100+: Backspace, DEL, HOME, END, INSERT,
PAGE UP, PAGE DOWN, F1 - F12 keys can work as local keyboard in Web SOL.
If not add "customKeyEnable" or "keyType", into config.json, Backspace,
DEL, HOME, END, INSERT, PAGE UP, PAGE DOWN, F1 - F12 keys can work
correctly in linux OS with $TERM=vt220 in SOL.
Other keys such as a-z can always work in SOL no matter "customKeyEnable"
or "keyType" is inserted into config.json.
Change-Id: Ifb196ec37080781033c0d6a3b0688baa7d0080b5
Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">
Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.
Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
| |
Get rid of "BMC host/IP address" & "server info" text, make the
buttons tighter and make more buttons visible in header so that
the information is more useful to users in tablet view.
Change-Id: I6b4166390b1828fca265e7bb56f51106b4e6f21b
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed pattern to be used moving forward,
as form validation is added to additional pages.
Validation error messages are shown on $touched and on submit.
Unreachable Server and Invalid username and password error messages
remain until input is no longer $pristine after form submission.
In addition, this removes unneeded and unused css styling
Resolves openbmc/phosphor-webui#47
Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logging/entry/<entryId>/attr/Resolved is a boolean as such
send true when resolving.
Before the function was always returning successful, fixed this
and log to the console when it fails.
Tested: Resolved multiple error logs and see the fail in the
console on a fail.
Change-Id: I60496f30f9241ffb6b6b73cf87b7481bea10b24f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added webui user accounts management. This support
both redfish and rest based backend API calls
depending on redfishSupportEnabled flag.
It does following actions:
- View all user list and there properties like
name, privilege, enabled state, Locked etc..
- Create new user account.
- Delete existing user account.
- Update the existing user properties like
password, privilege, enabled state.
Unit Test:
- Viewed all user information is proper or not.
- Created new user and validated.
- Deleted specific user and checked.
- Modified user info and validated the change.
All tests are done by enabling and disabling
redfishSupportEnabled flag using conifg.json.
Change-Id: Ifecf63844dc42c44771509958bf75947a92997ac
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The style tags in the svg inline images will trigger an issue when the
browser attempts to interpret them, and flags them as inline-styles
(which we want to disallow via policy). This commit removes them,
which, given that they shouldn't have been there in the first place,
should have no ill effects.
Tested By:
Launched GUI, observed button behavior did not change
Change-Id: I9b6443051fd30770853e589fcd2a7231f85fd082
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|