summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Changing the text Quiesced to ErrorIftekharul Islam2018-03-273-4/+4
| | | | | | | | | | As per discussion here openbmc/openbmc#2925 Changing the text Quiesced to Error Fixes openbmc/openbmc#2925 Change-Id: Icd360a91335c8dd77cfbde4faa868cce6a286e64 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Show error message received from server sideAlexander Filippov2018-03-273-9/+14
| | | | | | | | | | | | When an error occurs during authorization, display the error message received from server side instead hardcoded message. Partially resolves openbmc/openbmc#2974 Resolves openbmc/openbmc#3024 Tested: Enter invalid username or password and verify error message Change-Id: I91ca29d5a69e12e12ce490ce3206173de7d41f09 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
* Update firmware textGunnar Mills2018-03-231-1/+1
| | | | | | | | | | | | | The software image at the top of the table (i.e. the one with the highest priority) is used the next time the device is booted. Update the text to reflect this. More information on Priority can be found here: github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/RedundancyPriority.interface.yaml Tested: Verified I see the text. Change-Id: I95bc9070f5d18f566dd84d3f57948ea2b41506e6 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Only add ":" when a port is givenGunnar Mills2018-03-231-2/+2
| | | | | | | | | | | | | Before if no port was given, the HOST field would look like "9.41.165.233:". Added a check for a port before adding a ":". Resolves openbmc/openbmc#2995 Tested: Flashed an image with this change on a Witherspoon and verified no ":" when no port was given. Also, verified displayed data and log in looked good. Change-Id: I315c73489d419aacc041218e971e75d21ff6c255 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Sort inventory subcomponentsGunnar Mills2018-03-231-0/+6
| | | | | | | | | | | | Sort the inventory subcomponents by alphanumeric. This sorting produces: "core 0, core 1, core 2,... core 12, core 13" Before the order was "core 0, core 1, core 10, core 11, ... core 2, core 21" Tested: Verified the order Change-Id: I470684d39e5f6c850368b43fde8073b03556dd12 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display error and success textGunnar Mills2018-03-233-8/+42
| | | | | | | | | | | | | | When an error occurs changing the password, display the appropriate error message. On a successful password change also display text. Resolves openbmc/openbmc#2741 Resolves openbmc/openbmc#2969 Tested: Made all these errors show and also changed the password on a Witherspoon. Change-Id: I9808df9888175de988ecb0781023424315a1ec53 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Verify the old PasswordGunnar Mills2018-03-234-15/+47
| | | | | | | | | | | | | Call a special login function, that does not use the current session and ignores the intercept which would log out the user on a bad old password. This special login function, testPassword(), calls /login with the old password, a success verifies the password is correct. Tested: Changed the user password on a Witherspoon and verified an incorrect old password does not change the password. Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Change-Id: I65f6a6aa6dbc5d849e962b6c24a09e3ac0f6cf58
* Remove unused codeGunnar Mills2018-03-232-5/+0
| | | | | | | | This code is not used. Tested: Manually tested few key features of GUI. Change-Id: I8c684b9389fa54c7b9e70b9fced8bb5d764f4891 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Call changePassword() on "Save change" pressGunnar Mills2018-03-232-4/+27
| | | | | | | | | | Call the changePassword() function when a user presses the "Save change" Change password button. Also, validate the password fields. Tested: Changed the password on a Witherspoon. Change-Id: I479929c82c5e405591fa7b1cf01e5491d35079e7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add function to change user passwordGunnar Mills2018-03-231-0/+24
| | | | | | | | | Added changePassword() that changes the given user's password. This function is used in follow-on commits. Tested: Verified this funciton works. Change-Id: I0a5ec12f7ef0beb90eeeb97e3a117d9856d184d0 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Get the userGunnar Mills2018-03-231-0/+4
| | | | | | | | | | | | | | Need a way to get the user so we can use it to change the user's password. The path to change the user's password is /xyz/openbmc_project/user/${user}/action/SetPassword Part of openbmc/openbmc#2969 Tested: Verified I am storing the user. Change-Id: Ibde281ddc729997804c94fff65a6ca757c9dcdd1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fixing the submenu closing issueIftekharul Islam2018-03-141-1/+14
| | | | | | | fixes openbmc/openbmc#2743 Change-Id: I1fc43603dd99e562de6cd053c720b3e4169edb2a Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Remove phantomjsGunnar Mills2018-03-131-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | Removed phantomjs-prebuilt and karma-phantomjs-launcher since karma-phantomjs-launcher depends on phantomjs-prebuilt. We are seeing the following error with phantomjs: | npm ERR! node v4.6.1 | npm ERR! npm v2.15.9 | npm ERR! code ELIFECYCLE | | npm ERR! phantomjs-prebuilt@2.1.16 install: `node install.js` | npm ERR! Exit status 1 | npm ERR! | npm ERR! Failed at the phantomjs-prebuilt@2.1.16 install script 'node install.js' phantomjs was added in bbcf670a1 for use in the test infrastructure. Since we are not using the test infrastructure, remove phantomjs for now. Resolves openbmc/openbmc#2922 Tested: Verified I no longer see the error with this commit. Change-Id: I9d7b5affadde333cf21041cab489177ea92bba5d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display warning icons on non-functional subcomponentsGunnar Mills2018-03-131-1/+1
| | | | | | | | | | | | | | Warning icons are now displayed only in subcomponents that are present and non-functional. Only "present" subcomponents are displayed so only need to check for functional. An example of using this is cores of the cpu. Only display a warning on a present and non-functional core. Resolves openbmc/openbmc#2989 Tested: Only see a warning on a non-functional core. Change-Id: Ic22b7531de4dfcc445bfc5eae7dd23b0089f2cdf Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Only display "present" subcomponentsGunnar Mills2018-03-131-2/+2
| | | | | | | | | | Only display "present" subcomponents of an inventory item. An example of this would be cores of the cpu. Only display present cores. Tested: See only present cores. Change-Id: Ib53d72d24e35f17a047baa15b1eaad0e099576a5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* BMC IP changed to BMC host/IP and corrected the value truncation in webgui.Jayashankar Padath2018-03-093-4/+4
| | | | | | | | | | Resolves openbmc/openbmc#2894 Tested: Running GUI locally and verified the new texts. Also made sure that value truncation is not happening. Change-Id: Ic3947b36ef83fe5cb37190a848c85156cc072afd Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
* Removed bypass login scriptIftekharul Islam2018-03-074-18/+0
| | | | | | | | | We had a script that allowed users to bypass login to see the app interface. We did this for testing purpose. This commit removes that functionality and improves security. Change-Id: I17255f16082d5460015788130f2482f2849ce975 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Add appropriate message during server unreachable stateIftekharul Islam2018-03-071-3/+1
| | | | | | | | | | | | When system state is in Unreachable, there is no option under "Select a power operation. Adding the appropriate message according to the discussion in the fixes link below. fixes openbmc/openbmc#2843 Change-Id: Id0d1d74b2bb7012f1cb085262f5c0d2fece2ea62 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Have the "action" table cell flexGunnar Mills2018-03-052-3/+7
| | | | | | | | | | | Let the action table cell flex to fit 2 buttons, "Activate" and "Delete". This happens on a "Ready" image. Resolves openbmc/openbmc#2964 Tested: See both "Activate" and "Delete" on a "Ready" image. Change-Id: I1a91ed83f2f99983795baea9f59bbc0dd4749c0e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix "Boot priority" down arrowGunnar Mills2018-03-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | The way free priority works is if an image is set to a priority another image has, that other image's priority is increased by 1. Let's say there are 2 images, x and y. x has a priority of 2, and y has a priority of 3. x gets set to priority 3 (this is how the down arrow works, it sets the priority to the current priority + 1) now x has a priority of 3 and y gets increased to a priority of 4. x and y in this case never switched priority order (i.e. x still boots first). To get the down arrow to work currently, set the priority to + 2 on the down arrow. In the case above this would make x and y 4 and 3, respectfully, therefore, changing their priority order (i.e. y boots first now). This change is not needed for the up arrow, can you figure out why? Tested: Down arrow works now. Change-Id: Ia01dba6694b8c3b68f43fab78d8f0ae022ccb82c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove "Ready" image boot priority arrowsGunnar Mills2018-03-051-2/+2
| | | | | | | | | | | | Ready images do not have a priority. Priority is for "Active" images to determine which image to boot from. Only images on the GUI that are "Active" or "Functional" (on the GUI we call "Active" images that have the functional association "Functional") should have a Boot Priority. Tested: Verified no priority on Ready images. Change-Id: I5a527ed4bed9d686a746e3759f50fa9bb8b7988a Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display the version when confirming "Delete"Gunnar Mills2018-03-053-4/+6
| | | | | | | | | | | When confirming an image delete the GUI now displays "Delete firmware v2.0-165-ge571670?" Resolves openbmc/openbmc#2961 Tested: Confirmed text is correct and delete works Change-Id: Iad23908fbafc9514044be7770d269e723b35cb58 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display Version when confirming changing priorityGunnar Mills2018-03-054-7/+9
| | | | | | | | | | | | | | | | | Before the GUI displayed when changing the priority: "Change firmware e129c45b priority?" It now displays: "Change firmware v2.0-165-ge571670 priority?" This is important since the user never sees the image ID (e.g. e129c45b) and always sees the image version (e.g. v2.0-165-ge571670). Tested: confirmed text is correct and change priority works Change-Id: Ie9403aaade8a307b6de54feef20adc2b04e2b80b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove trailing spaces from filesGunnar Mills2018-03-0529-107/+107
| | | | | | Tested: Manually tested GUI for any regressions Change-Id: I8c0922b7bd67b03b07e8880bc4dba3b862220b33 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Determine "Functional" images by associationGunnar Mills2018-03-052-2/+11
| | | | | | | | | | | | | | | | | The functional, or running, images should be determined by looking at the functional association, not by looking at priority 0. An image could be functional but not priority 0, this happens after activating a new image. Get the functional images by looking at the endpoints of /xyz/openbmc_project/software/functional. Resolves openbmc/openbmc#2945 Tested: Verified the correct image is functional after activation and during other times of code updating. Change-Id: Ia5ad172b0874e634c0042576018b376b5260e31e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused codeGunnar Mills2018-02-281-7/+1
| | | | | | | | This code is not used. Having code like this around is confusing. Tested: Uploaded and activated an image. Change-Id: I3c5407e5a5631843f16f1e623cda77ef41a19c09 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add additional "Image States"Gunnar Mills2018-02-282-22/+19
| | | | | | | | | | | | | | | | | | | Added the following Activation States or as they are known on the GUI, "Image States": "NotReady", "Invalid", "Activating", and "Failed". Instead of having a variable for each state, these "Image States" are now tracked under one variable. Also, moved to looking at the value of "Activation", github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/Activation.interface.yaml#L17, so if more states are added in the future they will be picked up. Resolves openbmc/openbmc#2928 Tested: Verified when I activated an image I see the "Activating" state. Change-Id: I1f5e408ebe31f3eb6c3f0417d6605bff06c9ac19 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add "block" to active modalsGunnar Mills2018-02-271-1/+2
| | | | | | | | | | When a modal is active make it blocked so it can be viewed. The modals such as confirming activating an image were not visible. This change makes those modal visible when active. Tested: Activated several images on a Witherspoon system. Change-Id: I6667af017ea397344df6b6ed7e08949ffb4a3c55 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display the "type" of event logGunnar Mills2018-02-232-1/+2
| | | | | | | | | | | | | | | | The GUI before displayed the "Severity" of the event log in the name field. It now displays the type. Type is from the "Message" field in the event log. An example of the type is: "xyz.openbmc_project.Software.Version.Error.ManifestFileFailure". This is much more useful than the "Severity" ( e.g. "xyz.openbmc_project.Logging.Entry.Level.Error"). Severity is still displayed in the event log, above the type. Resolves openbmc/openbmc#2875 Change-Id: I10fdf90f6498f49b11a64e2c1e556b9a1c95f7b4 Tested: Running GUI locally Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move to "xyz" Download via TFTPGunnar Mills2018-02-231-2/+2
| | | | | | | | | Move from the old "org" Download via TFTP to the new "xyz" Download via TFTP interface. Tested: Downloaded several images to a Witherspoon system. Change-Id: Id556a3a56d06bfc3400f905a58e9a76964056d68 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix the "Upload firmware" buttonGunnar Mills2018-02-233-43/+17
| | | | | | | | | | | | | | | | | The "Upload firmware" button was not calling the uploadImage() function in api-utils.js. The uploadImage() function was not making the correct call to the /upload/image REST API. Removed the confirmUpload function since not needed on a upload since the user has already selected the file they want to upload, pressed "Open", and then pressed the "Upload firmware" button. Resolves openbmc/openbmc#2770 Tested: Uploaded several images to a Witherspoon system. Change-Id: Ia0e0ffba501066f59a4355b8f61595e30aea3f98 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Adding user friendly warning message in sensor pageIftekharul Islam2018-02-203-3/+20
| | | | | | | fixes openbmc/openbmc#2748 Change-Id: I4370be0b921e7ba7ecb16afecf59a7246a0a4224 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Move to gulp-sass 3.0.0Gunnar Mills2018-02-121-2/+3
| | | | | | | | | | | | | | | | | I have seen the following error on gulp-sass 2.3.2: npm ERR! code ELIFECYCLE npm ERR! errno 1 npm ERR! node-sass@3.13.1 postinstall: `node scripts/build.js` npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the node-sass@3.13.1 postinstall script. Googling this appears to be a common problem and the recommendation is to move to gulp-sass 3.0.0 Tested: Running GUI locally Change-Id: If8ae76a0184f9abf16c3c7d71446a5bc7bf5e8be Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Scale critical and warning valuesGunnar Mills2018-02-121-1/+4
| | | | | | | | | | | | The scale value should be applied to the CriticalLow, CriticalHigh, WarningLow, and WarningHigh values. Resolves openbmc/openbmc#2874 Tested: Pointed the local GUI to a Witherspoon system and verfied the correct critical and warning values. Change-Id: I5a04009570e47d2b448f505969585d46b5ffca07 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Warm Reboot should call the host reboot objectGunnar Mills2018-02-122-12/+8
| | | | | | | | | | | | | | | | From https://github.com/openbmc/docs/blob/master/host-management.md: To reboot the host: curl -c cjar -b cjar -k -H "Content-Type: application/json" -X PUT -d '{"data": "xyz.openbmc_project.State.Host.Transition.Reboot"}' https://${bmc}/xyz/openbmc_project/state/host0/attr/RequestedHostTransition Resolves openbmc/openbmc#2797 Tested: Pointed the local GUI to a Witherspoon system and verfied the correct rest call was made and the system warm rebooted. Change-Id: If073ef4447b323777603e886668212bd04791eea Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Have Immediate Shutdown call the chassis objectGunnar Mills2018-02-122-5/+12
| | | | | | | | | | | | | | | | | | | | | | | | "Immediate Shutdown" on the GUI should be a hard power off and differ from the "Orderly shutdown". From https://github.com/openbmc/docs/blob/master/host-management.md: To issue a hard power off (accomplished by powering off the chassis): curl -c cjar -b cjar -k -H "Content-Type: application/json" -X PUT \ -d '{"data": "xyz.openbmc_project.State.Chassis.Transition.Off"}' \ https://${bmc}/xyz/openbmc_project/state/chassis0/attr/RequestedPowerTransition There was already an unused "chassisPowerOff" function, reworked it to call the chassis object. Resolves openbmc/openbmc#2890 Tested: Pointed the local GUI to a Witherspoon system and verfied the correct rest call was made and the system hard powered off. Change-Id: Ibdb712656930a62e34603daa17df0d3116c86d92 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fixing the logout issue in webuiIftekharul Islam2018-02-121-1/+1
| | | | | | | | | A manual page refresh is required. Avoid the page refresh. fixes openbmc/openbmc#2737 Change-Id: Iaecb70cd3f9d43b730ca606cf3395f7fdb0640f3 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Turn off the manglerMatt Spinler2018-02-071-1/+4
| | | | | | | | | | | The javascript in this repository isn't currently compatible with the name mangling done by the uglifier plugin (it causes unknown provider errors). This commit can be reverted when it is fixed. Change-Id: I1589e2ba392aec7b321b9816475613215836c47d Signed-off-by: Matt Spinler <spinler@us.ibm.com>
* Add proper favicon handlingEd Tanous2018-02-023-3/+6
| | | | | | | | | | The current repo doesn't seem to produce a favicon, so having the reference to it produces either a 404 error or a 401 error depending on the server. Add a transparent favicon until someone can cobble together a proper one from the openbmc SVG files Change-Id: I5a79be5982e164a8ae0b28a69f673129c0a959ba Signed-off-by: Ed Tanous <ed.tanous@intel.com>
* README: add example usage with OpenBMCLei YU2018-02-011-7/+13
| | | | | | | | | 1. Add nodejs requirement; 2. Remove the out dated content; 3. Add example usage with OpenBMC Change-Id: I66f418ed53ccf28d845416790de8fcca8ff2fe98 Signed-off-by: Lei YU <mine260309@gmail.com>
* Fix to get full BMC IP address / hostnameSivas SRR2018-01-271-2/+2
| | | | | | | Resolves openbmc/openbmc#2648 Change-Id: I5669a3569fff086e30e4c794edfe19f9c17208d8 Signed-off-by: Sivas SRR <sivas.srr@in.ibm.com>
* Remove reference to IBM in phosphor-webuiEd Tanous2017-11-074-23/+6
| | | | | | | | | | | | | | | | As phosphor webui is supposed to be the reference implementation, it should not reference IBM, nor have IBM copywritten logos contained within it. If these are neccesary for IBM platforms, they should be done in a bbappend in the bitbake layer, or in a way that doesn't put copywritten materials on BMCs that may not have permission to use and release it. I'm hoping to generate ddiscussion on how the best way to handle this from a build perspective would be, but for now, references should be to the OpenBmc project, not IBM to avoid copyright issues. Change-Id: I73efda399e967ca4446b8df403e94e14ab24aff8 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
* Modernize web GUI and make it installable on BMCEd Tanous2017-11-0639-254/+622
| | | | | | | | | | | | | | | | | | | 1. Move from gulp server to webpack. This allows the proper compression to allow the webui to be embedded in the BMC. 2. Update js paths to use requires, not hardcoded paths. This was required to make the packaging work correctly. 3. Add babel config to do translation. 4. Update angularjs directive calls to use the angular 1.6 syntax for promises intead of success and fail. https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http 5. As a consequence of using NPM/webpack, the versions of angular and associated modules that were checked in have been updated. Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
* Updating network settingsIftekharul Islam2017-11-025-41/+172
| | | | | | | Adding display network settings info in network settings page Change-Id: I5ab3b399445b8d2d6422f907dc4c5a477bfc794d Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Updating login structureIftekharul Islam2017-11-0212-70/+257
| | | | | | | Updated login structure with a field where user can manually add server hostname if it is not populated automatically Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Updating images and stlesIftekharul Islam2017-11-0237-105/+17395
| | | | | | | Updating images and styles after code merge conflicts Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* added confirmation modalMichael Davis2017-10-091-2/+4
| | | | | Change-Id: If1bdfd21b34cba5944c1acc69e90ca35ea0189c0 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* fixed label for accessibilityMichael Davis2017-10-091-2/+2
| | | | | Change-Id: I00785d4edad7cf45340ccaadd96783bf748d9f16 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* removed Illustrator generated commentsMichael Davis2017-10-0913-26/+0
| | | | | Change-Id: Ia6eff395e1caca899d5a11da97dff5b697cc38fd Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* fixed package infoMichael Davis2017-10-091-3/+8
| | | | | Change-Id: Ibc25222efa4c5cade92fdb2ed8ab46a57f5d685e Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
OpenPOWER on IntegriCloud