diff options
| author | Iftekharul Islam <iffy.ryan@ibm.com> | 2017-11-09 09:51:48 -0600 |
|---|---|---|
| committer | Brad Bishop <bradleyb@fuzziesquirrel.com> | 2018-03-07 17:21:29 +0000 |
| commit | 3c837f45b6149a38e11b35d680ec9e8e64d547da (patch) | |
| tree | afb46835cf32d348d508eabe2c4995dbab3daebd | |
| parent | 0d028015b06bab47ae0752a71fa860548b66c625 (diff) | |
| download | phosphor-webui-3c837f45b6149a38e11b35d680ec9e8e64d547da.tar.gz phosphor-webui-3c837f45b6149a38e11b35d680ec9e8e64d547da.zip | |
Removed bypass login script
We had a script that allowed users to bypass login to see the app
interface. We did this for testing purpose. This commit removes that
functionality and improves security.
Change-Id: I17255f16082d5460015788130f2482f2849ce975
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
| -rw-r--r-- | app/common/services/userModel.js | 3 | ||||
| -rw-r--r-- | app/index.js | 4 | ||||
| -rw-r--r-- | app/login/controllers/login-controller.js | 6 | ||||
| -rw-r--r-- | app/login/index.js | 5 |
4 files changed, 0 insertions, 18 deletions
diff --git a/app/common/services/userModel.js b/app/common/services/userModel.js index 2c9de65..f82c1f1 100644 --- a/app/common/services/userModel.js +++ b/app/common/services/userModel.js @@ -15,9 +15,6 @@ window.angular && (function (angular) { .module('app.common.services') .service('userModel', ['APIUtils',function(APIUtils){ return { - fakeLogin: function(callback){ - sessionStorage.setItem('LOGIN_ID', 'FAKE_ID'); - }, login : function(username, password, callback){ APIUtils.login(username, password, function(response, error){ if(response && diff --git a/app/index.js b/app/index.js index 3f277a9..95d7fa3 100644 --- a/app/index.js +++ b/app/index.js @@ -168,10 +168,6 @@ window.angular && (function (angular) { }); $rootScope.$on('timedout-user', function(){ - if(sessionStorage.getItem('LOGIN_ID') == 'FAKE_ID'){ - return; - } - sessionStorage.removeItem('LOGIN_ID'); $location.path('/login'); }); diff --git a/app/login/controllers/login-controller.js b/app/login/controllers/login-controller.js index 8dc1d1b..c2ed383 100644 --- a/app/login/controllers/login-controller.js +++ b/app/login/controllers/login-controller.js @@ -23,12 +23,6 @@ window.angular && (function (angular) { $scope.dataService = dataService; $scope.host = $scope.dataService.host.replace(/^https?\:\/\//ig, ''); - if($routeParams.fake_login && - $routeParams.fake_login === 'fake_login'){ - userModel.fakeLogin(); - $window.location.hash = '#/overview/server'; - } - $scope.tryLogin = function(host, username, password, event){ if(event.keyCode === 13){ $scope.login(host, username, password); diff --git a/app/login/index.js b/app/login/index.js index b904383..1a33f66 100644 --- a/app/login/index.js +++ b/app/login/index.js @@ -18,11 +18,6 @@ window.angular && (function (angular) { // Route configuration .config(['$routeProvider', function ($routeProvider) { $routeProvider - .when('/login/:fake_login', { - 'template': require('./controllers/login-controller.html'), - 'controller': 'LoginController', - authenticated: false - }) .when('/login', { 'template': require('./controllers/login-controller.html'), 'controller': 'LoginController', |
