summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Display success message after uploading imageCamVan Nguyen2018-05-142-2/+8
| | | | | | | | | | | Fix includes: - Displaying an 'Upload complete' message and clearing the image's file name if the upload succeeds. - Displaying an error pop-up with reason for failure when the upload fails. Change-Id: Id9474b62ed62e1b40ffa018eb273abbf19be26ce Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Gray out the 'Boot priority' down arrow keyCamVan Nguyen2018-05-141-3/+3
| | | | | | | | | | | Gray out (disable) the 'Boot priority' down arrow key for a 'Functional' or 'Active' image if the remaining images are 'Ready' images. Resolves openbmc/openbmc#2965 Change-Id: Id8dad6b5a8d7376fe2c1f167a2043aae87916884 Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Rename to "Serial over LAN console"Gunnar Mills2018-05-132-2/+2
| | | | | | | | | | | We ran several customers through usability testing of the GUI last week. There was some confusion about "Serial over LAN". Adding console should help clear up this confusion. Renamed on both the overview page and the menu. This now matches with the SOL console page title. Change-Id: I73fc6964f4269a5332832af703c7198015be6a49 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Change to "View x High priority events"Gunnar Mills2018-05-131-1/+1
| | | | | | | | | Added the verb "View" to the front. This wording watches with other clickable links in the gray box (e.g. "Turn on server LED", "Edit network settings") Change-Id: I5696f92aedc2d83bcb261ff8f849415d5b66d336 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display ip addresses in 'BMC information' sectionCamVan Nguyen2018-05-133-4/+16
| | | | | | | | | | | BMC Host/IP Address is already displayed in the header. So in the 'BMC information' section, just display the BMC's ip addresses. There could be multiple ip addresses. Resolves openbmc/openbmc#3148 Change-Id: I4efdf4f1df2fc70d32dd659ae57b6bb7ba0fa0f4 Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Refresh the firmware page after downloading imageCamVan Nguyen2018-05-134-11/+70
| | | | | | | | | | | | | | | | | Fix includes - Polling the number of software objects for a new image. During which time the 'Downloading in progress' status bar will be displayed. A 2-minute timeout is used. - Displaying a 'Download complete' message if the download succeeds and refreshing the firmware page to show the new image once it is downloaded. - Displaying an error pop-up with reason for failure when the download fails. Resolves openbmc/openbmc#3054 Change-Id: I79a8b8c661c01474a12cef4af524cafdc2cee1fe Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Move last refresh time format to 'medium'Gunnar Mills2018-05-041-1/+1
| | | | | | | | | | | | | | | | From https://docs.angularjs.org/api/ng/filter/date: "'medium': equivalent to 'MMM d, y h:mm:ss a' for en_US locale (e.g. Sep 3, 2010 12:05:08 PM)" This is a similar format as to what was present on the GUI before for en_US. Letting the browser choose the format, is important. Still displayed in user's timezone. Before: 1:52:11 May 01 2018 After: May 1, 2018 1:52:11 PM Change-Id: Iff2769a22125b1ea4f6f375a6b2b6866438149c5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Get the BMC timeGunnar Mills2018-05-043-1/+21
| | | | | | | | | | | | | | | | | | | Get the BMC time from xyz/openbmc_project/time/bmc. This time is in epoch time so convert. Before the time and date hardcoded. From https://docs.angularjs.org/api/ng/filter/date: "'medium': equivalent to 'MMM d, y h:mm:ss a' for en_US locale (e.g. Sep 3, 2010 12:05:08 PM)" This is a similar format as to what was present on the GUI before for en_US. Letting the browser choose the format, is important. Displayed in user's timezone. Resolves openbmc/openbmc#3116 Tested: Now see correct date and time, "4/19/2018, 20:31:18 UTC" Change-Id: Ie30c65b038b58afc8c4c77ca5b70667e80e76cc6 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display red 'error' icon for Error stateCamVan Nguyen2018-05-043-3/+13
| | | | | | | | | | - Display a red 'error' icon vs a yellow 'warning' icon when the Server Power is in an Error (Quiesced) state. Resolves openbmc/openbmc#3149 Change-Id: I0d23d9406370e5b49d554b979aaedb5754601e3b Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* host console: remove sub-optionsDeepak Kodihalli2018-05-031-4/+0
| | | | | | | | | | Remove the "Open in new tab" and "Export" buttons. These are shown by the webui today, but there's no corresponding implementation. These will be added back when these features are implemented (via https://github.com/openbmc/openbmc/issues/3153). Change-Id: Ib9b4267f2f16d06dfe6a2a11bb8c56beaac6e081 Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
* Get the Serial over LAN console workingDeepak Kodihalli2018-05-031-19/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | This commit hooks up hterm to a websocket that the BMC's REST server exposes as an access to the host serial console. Writes to the terminal are sent over the websocket and reads from the websocket are written to the terminal. The websocket is open only when the console page in the GUI is loaded. Tested: - The host console can be accessed as expected from the GUI page. - The "Open in new tab" is still unimplemented. I'll code that up in a subsequent commit. - One issue that I've noticed is if you have the console open before the host is powered on, and then you power on the host, at the time the petitboot config menu shows, the text in the terminal stops scrolling and starts wrapping. The work-around is to refresh the page. This doesn't happen for example if you access the console after the host has powered on, or at any other time for that matter. I think this is an hterm.js issue. I'm still investigating. - The console looks desirably performant. The REST server's performance to serve other routes is not impacted when the /console websocket is open. Change-Id: I35fa39d7f63094552061b097c46be0fda79ed14f Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
* Fix misspelling of DomainNameGunnar Mills2018-05-021-1/+1
| | | | | | | | | | | The interface object had 2 DomainName properties ("DomainName" and "domainName") Tested: Verified the interface object now only has 1 DomainName properties. Change-Id: Ic14f8e441cde8b83427b8f32f73a8bbb7efc48cc Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Added OpenBMC favicon.icoGunnar Mills2018-04-301-0/+0
| | | | | | | | | | | | | | | | | The favicon.ico before was transparent. Created the favicon.ico using https://www.favicon-generator.org/ and a cropped OpenBMC logo image. The cropped OpenBMC image was only the OpenBMC symbol. The image had the text underneath cropped out. A favicon.ico based on the complete OpenBMC logo looked weird. This change will not be visible if running the GUI locally, this is due to how we display the favicon. The complete OpenBMC logo can be found here: https://en.wikipedia.org/wiki/OpenBMC#/media/File:OpenBMC_logo.png Tested: Built a Witherspoon image and loaded it onto a Witherspoon. Change-Id: I284c75e303ae8a6e005a26e2fdb7362db7e2300f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Change "turn on server LED" textGunnar Mills2018-04-301-1/+1
| | | | | | | | | | | | | | We ran several customers through usability testing of the GUI this week. One area that caused confusion is the "Turn on server indicator". We had a customer think it was a button to power on the server. Other customers were also confused about what it does. After discussing and getting customer feedback, "Turn on server LED" is better understood. This also matches what is on the Server LED page. Change-Id: I1b55a377c85ee6e649e27e2a6923b5e17fd23a30 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Server Overview: Fix capitalization on "Server configuration"Gunnar Mills2018-04-301-1/+1
| | | | | | | | | The other tabs are "Server health", "Server control", and "Server overview". Have "Server configuration" follow the same capitalization convention. Change-Id: If794c36cddc6fd3118b41ca780140c409f11d1f7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Server Overview: Fix capitalization of "Serial over LAN"Gunnar Mills2018-04-301-1/+1
| | | | | | | | | | | It is capitalized as "Serial over LAN" everywhere else on the GUI (the SOL page and in the sub-menu). This also follows with the capitalization of the other items in the gray box: "BMC time", "Turn on server indicator", and "Edit network settings". Change-Id: I9e94f8ef1ebf65d0038b33c7fb1e11576f0a3f61 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Removed @sinceGunnar Mills2018-04-302-2/+0
| | | | | | | | Removed @since because it is no longer needed due to removing @version in previous commit. Change-Id: I04849fe39e5fb4482128a3c6fb7601d25da8a808 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove the version from each fileGunnar Mills2018-04-3042-42/+0
| | | | | | | | Already have a Web UI version, no need to track the version of each file. These have not been getting updated. Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Rename title "OpenBMC"Gunnar Mills2018-04-281-1/+1
| | | | | | | | | | This is the name that appears in the browser tab. Fixed OpenBMC capitalization and removed "app". This conforms to other websites (e.g. the browser tab for riot.im is "Riot". For google.com it is "Google"). Change-Id: Ibd64ccd37d9f4b1fbea42c398e57abfad6efe357 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add fixes for power operationsCamVan Nguyen2018-04-266-52/+150
| | | | | | | | | | | | | | | | | | | | | | | Fixes applies to 'Power on', 'Warm reboot', 'Orderly shutdown', and 'Immediate shutdown' power operations. Fixes include: - Verifying that the chassis and host transition through the expected states for each power operation. During which time a spinner will be displayed. A timeout of 5 minutes for each state transition has been added. - Displaying the current state of the host in the 'Server power' and 'Current status' bar. The state displayed will change as the host transition through different states even as the spinner continues to spin. - Displaying an error pop-up with reason for failure when the power operation fails. Resolves openbmc/openbmc#2758 Resolves openbmc/openbmc#2787 Resolves openbmc/openbmc#2803 Change-Id: I514e030f9df7bd4d8b53634408f0449cd9abada9 Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Display the "type" of event log on overview pageGunnar Mills2018-04-231-1/+1
| | | | | | | | | | | | | | | The overview page before displayed the "Severity" of the event log in the name field. It now displays the type. Type is from the "Message" field in the event log. An example of the type is: "xyz.openbmc_project.Software.Version.Error.ManifestFileFailure". This is much more useful than the "Severity" ( e.g. "xyz.openbmc_project.Logging.Entry.Level.Error"). Severity is still displayed in the event log, above the type. A similar change for the "event logs" page was made here: https://gerrit.openbmc-project.xyz/#/c/8916 Change-Id: Iddf1f99e0ccde5a4f27d709dc280de628eb909ce Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add TODO for issue 3117Gunnar Mills2018-04-231-0/+3
| | | | | | | | | Added a TODO for openbmc/openbmc#3117. This should have been part of https://gerrit.openbmc-project.xyz/#/c/10125/. Change-Id: I5005cad090ee63da962bc6c656bc631f48b62755 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Do not display the 'edit' hostnameGunnar Mills2018-04-201-1/+2
| | | | | | | | | | Editing the hostname does not work. We need a rest call to do this. Comment this 'edit' button out until the code is added to do this. Tested: Don't see this edit button the server overview page. Change-Id: I957a3df99810a206c67e95dd4d53dc5d6833387c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Adding new button 'Normal' in sensors pageIftekharul Islam2018-04-194-5/+14
| | | | | | | | | | | | | - Adding a 3rd option called Normal in addition to Critical and Warning based on the discussion in openbmc/openbmc#2750 Fixes openbmc/openbmc#2750 Tested: Verified the 'Normal' button works. Change-Id: Ied4d37aa9284392f08818f8111ebbcc677234586 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add fixes for cold rebootIftekharul Islam2018-04-1910-69/+199
| | | | | | | | | | | | | | | | This fixes the cold reboot issue with the following steps - It applies the command to shut off the chassis. - Then verify the chassis is off. It checks for every 5 seconds. During this time the spinner displays. A 5min timeout has been added. - Once the chassis is off, it turns on the host. fixes openbmc/openbmc#2795 Change-Id: I119a1c95e57c10ccee27be1512a1fc38cde307fa Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com> Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Move bmc_firmware to displayBMCInfoGunnar Mills2018-04-191-5/+7
| | | | | | | | Before setting the BMC firmware was in displayServerInfo Tested: Verified the BMC firmware still displays correctly. Change-Id: Ic6323bc9eec700ff5956868899ccda398a841274 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Look at correct server informationGunnar Mills2018-04-193-4/+20
| | | | | | | | | | | | Look at /xyz/openbmc_project/inventory/system for the server information. Before the "server overview" page looked at the BMC information for things like Server SerialNumber. Resolves openbmc/openbmc#3095 Tested: Verified I see the correct server information now. Change-Id: I562b28353d79fbf4a84e4c9a01db57d757a102a1 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Revert "Fix refresh for event log page"Andrew Geissler2018-04-161-10/+1
| | | | | | | | | | This reverts commit a4dacb6a365609ec8e602b3b020030fe73da6087. https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all pages so individual refresh functions are no longer needed Change-Id: Icbe38276b53457cc2a0c22b29a58c9fee84e6f25 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Revert "Fix refresh on system & sensors overview pages"Andrew Geissler2018-04-162-21/+3
| | | | | | | | | | This reverts commit 23217dae2bdc8e9bd6b3f20a395d1892382b0682. https://gerrit.openbmc-project.xyz/#/c/10063/ refreshes all pages so individual refresh functions are no longer needed Change-Id: I52151ba0e356f000324538e4b5eac6c9846c2eb3 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Display error if error on uploadGunnar Mills2018-04-132-26/+17
| | | | | | | | | | | | | | | We were missing the rejected promise when image upload returned an error. Now with this change and https://gerrit.openbmc-project.xyz/#/c/9594/ image upload now uploads an image and refreshes the page to display the image or displays an error if the upload failed. Resolves openbmc/openbmc#2960 Tested: See an error if a bad image. GUI refreshes if the image was uploaded successfully. Change-Id: I5f4030fb29fc08aa65dd0d36e32368106c31a76b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Do not display the 'Last power operation' timeCamVan Nguyen2018-04-131-0/+4
| | | | | | | | | | The 'Last power operation' time is incorrect. The time shown is the last refresh time instead of the last time a power operation was performed. We need to implement a REST call and back-end support to get the correct time of the last power operation. Change-Id: Ic81edf22bd3450b2558b66b7f911634122f86da0 Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Do not display the 'BMC last reboot' timeCamVan Nguyen2018-04-131-0/+5
| | | | | | | | | The 'BMC last reboot' time is incorrect. The time shown is the last refresh time instead of the last BMC reboot time. We need to implement a REST call to get the real last reboot time from uptime. Change-Id: I4d0f609f4350563a1809ae119f12727ebd0bf1b1 Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Display correct Power Consumption & Cap valuesCamVan Nguyen2018-04-134-17/+82
| | | | | | | | | | Current values are hard coded to '000 W'. This fix is to do REST calls and display the correct values. Resolves openbmc/openbmc#2735 Change-Id: I2f6766f1685a2bd52da62cda19998794f80270ec Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Refresh current page when refresh hitAndrew Geissler2018-04-121-2/+4
| | | | | | | | | | | | | This will refresh all controller data on the current page. Testing: Verified firmware and network settings were updated when refresh button was hit. Resolves openbmc/openbmc#2927 Change-Id: I1e16c3d4a9cd0947b46bb0c9856062e549e0ba6e Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Spelling fixesGunnar Mills2018-04-091-6/+6
| | | | | | | | | Spelling errors found using github.com/lucasdemarchi/codespell A tool to fix common misspellings. This tool is licensed under GNU General Public License, version 2. Change-Id: Ia35dc209cd7965842d439399768987b47d55a4ef Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* gitignore: Add coverage/Gunnar Mills2018-04-091-1/+2
| | | | | | | Coverage is where PhantomJs outputs the unit test coverage. Change-Id: I381e479d57dc2226a464d117bfd5a917bd5706dd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move login error to common error styleGunnar Mills2018-04-092-11/+2
| | | | | | | | Created a generic error class, have the login error inherit it. Tested: Verified the login error looks the same. Change-Id: Ief373fa37ea655cfcb544861a4e540abbe65f77e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Wait for 10 seconds before rebootingGunnar Mills2018-04-091-8/+18
| | | | | | | | | | | | | | | | | | After the image is active wait 10 seconds before rebooting if "activate and reboot" was selected. We had an issue, https://github.com/openbmc/openbmc/issues/2764, that a system could brick if the system reboots before the service to set the U-Boot variables is complete. Wait 10 seconds before rebooting to ensure this service is complete. This issue is fixed in newer images, but the user may be updating from an older image that does not that have this fix. Tested: Verified the system waits 10 seconds after the image becomes active before rebooting. Change-Id: I00115680cca14e50814e44c302d6134aca242d3f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display error if TFTP post failsGunnar Mills2018-04-092-46/+18
| | | | | | | | | | | | Display an error if the DownloadViaTFTP returns an error code. This code replaces some unused code. Resolves openbmc/openbmc#3029 Tested: Verified I see this error if the DownloadViaTFTP call returns an error code. Change-Id: I1547689059f45953b29aedda75c0599aec30079d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Display error if TFTP field emptyGunnar Mills2018-04-095-0/+26
| | | | | | | | | | | If either TFTP Server IP Address or File Name is empty for the "Download image file from TFTP server" function, return and display an error. Tested: Verified I see this error if either field is empty. Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add Activate firmware and reboot buttonGunnar Mills2018-04-052-3/+20
| | | | | | | | | | | | | | | Added a radio button to activate firmware and reboot the BMC. If the "Activate firmware and reboot" option is selected, reboot the BMC after activating the firmware. The user is then logged out. Resolves openbmc/openbmc#3027 Tested: When "Activate firmware and reboot" option is selected, the BMC reboots after activating. When it is not selected, the BMC image just activates. Change-Id: I07293dc8a6ddfac4cf58ba2c1d1352c9afd6fa8d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update the GUI after an image activatedGunnar Mills2018-04-043-16/+74
| | | | | | | | | | | | | | | | | | When activating an image the firmware page does not refresh after the image is activated and show the image as "Active". To get the image to show as "Active", a user must refresh the page. The activating image code now waits until the image is activated and the REST call returns "Active" or "Failed" and then refreshes the page. Resolves openbmc/openbmc#2966 Tested: Activated an image and verfied it refreshed after "Active". Change-Id: Ic68e3c9e6cb5c2ea4f5d66f48fd09252c4807f26 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Return http promise on testPasswordGunnar Mills2018-04-021-10/+2
| | | | | | | | | | Instead of creating a new promise with q.defer(), just return the http promise. This is much simpler and the recommended solution. Tested: Changed the password and verified the wrong old password returned an error on a Witherspoon. Change-Id: I1b412426da58ec3185f6d83bd53fdc984c7785e8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add MAINTAINERS fileBrad Bishop2018-03-301-0/+2
| | | | | Change-Id: I890f468fc9ca1af7f8eafd09a8c03cb8da096fe3 Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
* Fix refresh for event log pageIftekharul Islam2018-03-292-2/+11
| | | | | | | | | | | | | | Coded the refresh button in log page so that upon clicking on it will run the rest command to get the latest event log data. This sample code can be used to fetch the relevant data for other pages when refresh button is clicked. Fixes openbmc/openbmc#3009 Change-Id: Iefdc3f77895881df44238142148eb298663c3b5a Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Fix refresh on system & sensors overview pagesCamVan Nguyen2018-03-292-4/+22
| | | | | | | Partially resolves openbmc/openbmc#2927 Change-Id: I7f449c41ef645b67253c5d3c2ed6c8b1984f0408 Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>
* Add server confirm activation modalGunnar Mills2018-03-294-7/+13
| | | | | | | | | | | | | Added text specific to server images that appears in the activation modal when a "server" image is activated. The "server" and "BMC" images use the same modal, but the text and if radio buttons appear differ. Resolves openbmc/openbmc#2967 Tested: Activated both a server and BMC image on a Witherspoon. Change-Id: I83693641ebfef802d403141ade55a950f359ba6e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove "reboot" modalGunnar Mills2018-03-292-28/+1
| | | | | | | | This modal was not used. Tested: Uploaded and activated an image on a Witherspoon. Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move from "Preserve settings" to "Confirm Activation"Gunnar Mills2018-03-294-24/+21
| | | | | | | | | | | | | | | | | The "Preserve settings" popup that showed when a user activated an image was not useful and did not do anything. Saving network settings prior to activation is not needed so moved to a "Confirm Activation" modal. This modal will eventually include an "activate BMC firmware and reboot" selection, openbmc/openbmc#3027, for now it only holds the one selection. The "Preserve settings" and now this "Confirm Activation" modal both appear on "server" and "BMC" images, this is a bug that is fixed in a later commit. Tested: Activated an image on a Witherspoon machine. Change-Id: I7176d5a314ea325e6e94606ef07b32786ede64e9 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Confirm changing priority on all priority changesGunnar Mills2018-03-271-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | Before the confirm priority change modal would only appear if the user is changing the priority from priority "1" to "0" or priority "0" to "1". This doesn't work because if two images existed, a "functional" priority "1" image and an "active" priority "2" image the confirm would not appear on a priority change and it should. I believe this logic came from the belief that the "functional" image is always priority "0" and therefore only display this confirm when the "functional" image is affected by the change. The functional image is not always priority "0" and with only 2 "active" images supported (only "active" images have a priority) (the "functional" image is an "active" image) all priority changes affect the functional image so adding this confirm for all priority changes. Tested: See this confirm on every priority change. Change-Id: Icd113686f15a2e82ead72d04677335ee635cf668 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
OpenPOWER on IntegriCloud