Confirm changing priority on all priority changes

Before the confirm priority change modal would only appear if
the user is changing the priority from priority "1" to "0"
or priority "0" to "1".

This doesn't work because if two images existed, a
"functional" priority "1" image and an "active" priority
"2" image the confirm would not appear on a priority change
and it should.

I believe this logic came from the belief that the "functional"
image is always priority "0" and therefore only display
this confirm when the "functional" image is affected by the
change. The functional image is not always priority "0" and
with only 2 "active" images supported (only "active" images have
a priority) (the "functional" image is an "active" image) all
priority changes affect the functional image so adding this
confirm for all priority changes.

Tested: See this confirm on every priority change.
Change-Id: Icd113686f15a2e82ead72d04677335ee635cf668
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

1 files changed, 1 insertions, 6 deletions

diff --git a/app/configuration/controllers/firmware-controller.js b/app/configuration/controllers/firmware-controller.js
index d46b6e4..b686de8 100644
--- a/app/configuration/controllers/firmware-controller.js
+++ b/app/configuration/controllers/firmware-controller.js
@@ -143,12 +143,7 @@ window.angular && (function (angular) {
                         $scope.priority_image_version = imageVersion;
                         $scope.priority_from = from;
                         $scope.priority_to = to;
-
-                        if((from + to) == 1){
-                            $scope.confirm_priority = true;
-                        }else{
-                            $scope.confirmChangePriority();
-                        }
+                        $scope.confirm_priority = true;
                     }
 
                     $scope.confirmChangePriority = function(){