summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix array index out of bounds exceptionGeorge Liu2019-07-221-6/+9
| | | | | | | | | | | | We should be verified string length when the phosphor-webui calls the getFirmwares function to handle the property value of ExtenVersion. because it is risky to get the first address of array when that is empty Tested: Built phosphor-webui and get a effective array of titlePart via console from WEBUI. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Ife08d208eb7fbeb71284ae0700fb5d871343a298
* Clean up color valuesYoshie Muranaka2019-07-0944-641/+426
| | | | | | | | | | | | | This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss. Any usage of CSS color properties should refer to the mapped color variables in colors.scss. - Removed tags.scss file since tag components no longer used Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
* Create certificate management pagebeccabroek2019-07-0915-3/+529
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Displays certificates and the ability to add up to one of each type of certificate (as limited by the backend implementation). HTTPS certificate and LDAP client cert are implemented in this commit, with the ability to add more types as needed by adding them to the constants.js CERTIFICATE_TYPES array. Also provides the ability to replace a certificate once it is added. Resolves openbmc/phosphor-webui#43 Tested: loaded onto a witherspoon and able to view and replace both the HTTPS certificate and the LDAP certificate. GUI only allows to upload an LDAP certificate if one doesn't already exist. The GUI limits the user to one file per type as expected at this time and provides the appropriate validation messages. Alert messages appear above the table if the certificate is expired or within 30 days of expiring. Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240 Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
* Fix the opacity of the loading screenEd Tanous2019-07-021-3/+1
| | | | | | | | | | | | | | | | | Currently the loading screen has a 0.7 opacity, which leads to some strange behaviors at times when changing screens. Old scopes pop under new ones, leading to a page "jump" once the loading is complete. Making the loading page fully opaque and removing the transition effect reduces this behavior, and makes the page transitions feel cleaner. Tested: Loaded webui locally. Observed problem goes away when navigating between pages. Navigated between several pages to verify, including pages with a lot of static data. Signed-off-by: Ed Tanous <ed.tanous@intel.com> Change-Id: I5549d5c49901429f6e9c353524c6f7060725c2ea
* Fix sensors table header and body alignmentDerick Montague2019-06-272-160/+188
| | | | | | | | | | | | | | - Update markup to use semenatic table - Update table to flex based layout to support responsive table design Tested: Small screen and large screen layout in Chrome, Firefox, and Safari. Safari has issues with the sticky header, which is an acceptable trade off and meets cross-browser standards. Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I8ea323e45a2659562f229d4fd6d4e53887664cad
* Move to clang-format-8Gunnar Mills2019-06-271-1/+1
| | | | | | | | Moved to clang-format-8 here: https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-build-scripts/+/23087 Change-Id: I48f4fd4163581e7a8eaec260a52deb7da42b5b05 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Rename option to enable Redfish EventlogGunnar Mills2019-06-272-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IBM has a need for more granular options for turning panels off and on. Renamed redfishSupportEnabled, redfishEventLogDisabled. By default, it continues to be enabled. Redfish is used for user management already so this setting was a bit of misnomer (i.e. it did not "turn off" Redfish use). LDAP and Certificates, both in review, also use Redfish. Moved to "Disable" so that if not defined in the config.json, the panel is still visible. A meta layer has to overwrite the config.json with "redfishEventLogDisabled" : true to make the panel not appear on the navigation. Pushed a patch here to disable the Redfish Event Log page in the meta-openpower layer: https://gerrit.openbmc-project.xyz/c/openbmc/meta-openpower/+/22923 Pushed a patch here to remove the redfishSupportEnabled in Intel's layer: https://gerrit.openbmc-project.xyz/c/openbmc/meta-intel/+/22870 An improvement would be to not import if disabled. Tested: Built Witherspoon with 22923. Did not see "System logs" panel. Change-Id: I8722f43191ec73d21d6a181223d00256dbcd062f Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Capitalize System logs correctlyGunnar Mills2019-06-271-1/+1
| | | | | | | | | The other panels capitalize the first word only. E.g. Hardware status, Server power operations, and Manage power usage. Follow this standard. Change-Id: Icbbc2df25e1a3c9dd5e44db4c1d3f6a9f8252144 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix cold reboot errorYoshie Muranaka2019-06-262-21/+48
| | | | | | | | | | | | Cold reboot will check the host status by referring to the server_state property in the dataService instead of making API requests to check host/chassis status. TODO: Refactor other power control options to follow a similar pattern. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I74b1b78fa39caee514fbaea8492c8a5ad6f8145b
* Consolidate button stylesYoshie Muranaka2019-06-2199-1178/+460
| | | | | | | | | | | | | | | | | | | | | | | | | This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
* Add remote logging serverYoshie Muranaka2019-06-2111-4/+366
| | | | | | | | | | | | | Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote server, edit/change an existing server configuration and remove/disable the remote server. Resolves openbmc/phosphor-webui#68 Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
* Sort sensors alphanumericallyAlexander Filippov2019-06-181-0/+5
| | | | | | | | | Sort the list of sensors in alphanumeric order. Relatives openbmc/openbmc#3386 Change-Id: Ie30f48417038a2cdf8c67de6ac357f078c8aaae7 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
* Fix Unknown Provider errorYoshie Muranaka2019-06-141-22/+24
| | | | | | | | | | | | This patchset will fix the Unknown Provider error caused by the toggle-flag directive by declaring the required $document dependency. Tested: Navigated to Event Log page and no longer seeing the error in the browser console. Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I446f0a1d120526dfa250862018dfa09b289cae74
* Change button styles from rounded to straight cornersYoshie Muranaka2019-05-3114-63/+46
| | | | | | | | | | | | | | This will create more visual consistency between the components in the GUI since there are elements, such as text fields and dropdowns that are styled with straight corners. - Removes border radius from buttons - Removes some redundant styles - Adds input types that aren't currently inheriting defined styles Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2
* Fix tablet alignment issues for event logsYoshie Muranaka2019-05-295-38/+50
| | | | | | | | | | | | | | | | | This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview page always display underneath the 'BMC time' label in a destkop view–currently the date value will wrap to a new line if the string is too long. - Update markup to use Foundation grid layout classes on the server overview event log table Tested: Event log tables on server overview page and event log page Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I7d765ebbe679f954e606d1d25e2182d983a7b3f3
* Fix the tabbing order in the primary and secondary navigationYoshie Muranaka2019-05-292-138/+157
| | | | | | | | | | | | | | The main navigation will follow a natural tabbing order. When the secondary menu is expanded with the keyboard, the first item in the secondary menu will be in focus. Tabbing after the last item in the secondary menu will return focus to the primary menu. - Restructures markup so secondary menu is nested in primary navigation Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I4ecb17ef6721ee443310f81e1554620352c145a4
* Add .ng-leave and .ng-enter rulesets for page transitionDerick Montague2019-05-293-38/+91
| | | | | | | | | | | | | | | Adding ngAnimation dependency created added animation to pages during route or location changes. Added transitions to create an elegant transition. Tested: I navigated to every page including logging in and out in Chrome, Firefox and Safari to assure all browsers handle the transition consistently. Resolves openbmc/phosphor-webui#86 Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I14fa1bd790e80f977b7a0ccceccc3eb20ce33ae6
* Remove unused errors.htmlGunnar Mills2019-05-235-43/+0
| | | | | | | | | | | | | | | | | | | Also removed errorModalDetails and displayErrorModal from dataService since they are no longer used. errors.html was only active when displayErrorModal was true. displayErrorModal was only true when activateErrorModal was called. activateErrorModal was removed in a previous commit. activateErrorModal's only use was removed here: https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8 Tested: Searched the repo. Built an image and loaded onto a Witherspoon. No regressions observed. Change-Id: I96e26dd3817d7b02bbce74b4cc093b75dab669ed Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused chassis_stateGunnar Mills2019-05-231-1/+0
| | | | | | | | | | Only display the server/host state on the GUI. Tested: Searched the repo for 'chassis_state'. Built an image, loaded on a Witherspoon, power on/off, and verified correct host state. Change-Id: Ibdefeef7744e08cd737410741a1402ccb9e69200 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused activateErrorModalGunnar Mills2019-05-232-25/+0
| | | | | | | | | | | | | | | activateErrorModal was unused. Also remove Constants.ERROR_MODAL since activateErrorModal was the only place which used it. https://github.com/openbmc/phosphor-webui/commit/a1d238f3a53db2ec3cc4c2fd52fe78738b37968b#diff-65affd2488457363c5b9e9266258c3b8 added activateErrorModal / deactivateErrorModal. https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8 removed its use. Tested: Searched the repo and when testing the GUI on a a Witherspoon, toasts worked as expected. Change-Id: I98107f397fab039123f8507cd7bbac2ef8e5fb7b Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused server_statusGunnar Mills2019-05-233-7/+0
| | | | | | | | | | | | dataService.server_status is unused. server_status was set to a HOST_STATE constants which are now unused. Removed the HOST_STATE constants also. Tested: Searched the repo for 'server_status' and 'HOST_STATE' Built an image, loaded on a Witherspoon, power on/off, and verified correct host state. Change-Id: I10a915852634277bb5261e113b9706857acf66d6 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Firmware: Remove unused interpolateGunnar Mills2019-05-231-3/+2
| | | | | | | | | | | | | Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/90ae95eb6f5f30e3863f24ad364b111258ea4ee4#diff-44385b1119c2cae41d7331ab4a5cd5fe moved to ngToast (later toastService) and removed the use of interpolate. Tested: Build this and the commits below and loaded onto a Witherspoon system. Uploaded an image and activated it. Change-Id: I161c7860cec006dc434bc00495b25b588f069775 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Virtual media pagebeccabroek2019-05-2310-19/+595
| | | | | | | | | | | | | | | | | | | | | | | | Adds page to manage virtual media devices. User selects file and pushes 'start' button to establish websocket connection. nbdServerService added to provide ability for user to navigate away from the page and return with the ability to see the current active sessions. Currently only supports 1 Virtual Media device. Resolves openbmc/phosphor-webui#40 Tested: uploaded ubuntu image file, started the connection and mounted virtual media device from host console. Able to see Ubuntu image file. Also uploaded file and navigated away from the page, checking that the websocket remained open and was sending / recieving messages. Finally, tested that when connection was stopped, 'USB disconnect' log was present in host console. Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc Signed-off-by: beccabroek <beccabroek@gmail.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com> Signed-off-by: Derick Montague <derick.montague@ibm.com>
* Reviewers: Replace Becca with DerickGunnar Mills2019-05-231-1/+1
| | | | | | | | | | | Becca is no longer working on the OpenBMC project. Derick has been reviewing code and pushing code to the WebUI for some time. Please note the "Reviewer" tag has no official power, it is a reference for who to add as a reviewer and used by tools such as obmc-gerrit to automatically add reviewers. Change-Id: I1d8c2d3626359b2b9f81329f6214d01ea46e13d5 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* NPM update to address TAR vulnerabilityGunnar Mills2019-05-212-710/+867
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This security vulnerability is in the phosphor-webui repo: "We found a potential security vulnerability in one of your dependencies. tar Upgrade tar to version 4.4.2 or later." See https://nvd.nist.gov/vuln/detail/CVE-2018-20834 for more information. Ran "NPM update" && "npm install node-sass@latest --save". Before: bash-4.1$ npm audit .... found 3 high severity vulnerabilities in 12118 scanned packages run `npm audit fix` to fix 3 of them. After: bash-4.1$ npm audit === npm audit security report === found 0 vulnerabilities in 12124 scanned packages Resolves https://github.com/openbmc/phosphor-webui/issues/85 Tested: Built the GUI and loaded it on a Witherspoon. No regressions observed. Change-Id: I67cf4111021d7097a4a0726fecc320853810c6fd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused interpolateGunnar Mills2019-05-201-3/+3
| | | | | | | | | | | Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3 moved to ngToast and removed the use of interpolate. Tested: Build this and the commits below and loaded onto a Witherspoon system. Did a power on, warm reboot, and immediate shutdown. Change-Id: I99c2f3705df413fc744066dd34ba38a383c174fc Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Added comments to help clarify "confirm"Gunnar Mills2019-05-171-0/+3
| | | | | | | For the next person digging in this code. :) Change-Id: Ib6c21da3fb53a4277a90bf2e5cab90ed29496724 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove done TODOGunnar Mills2019-05-171-2/+0
| | | | | | | This TODO is complete, remote it. Change-Id: Ifb775aa932bf54e790ff60352611a716f2d7fb02 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused testStateGunnar Mills2019-05-171-8/+1
| | | | | Change-Id: I9235c146fcd1288add4eeaa209d0f7b12f4d394e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused powerOnConfirm and powerConfirmGunnar Mills2019-05-172-9/+1
| | | | | | | | There is no confirm for Powering on the system. These were unused. Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Rename variables to follow lowerCamelCaseGunnar Mills2019-05-172-22/+22
| | | | | | | | | | OpenBMC follows Google JavaScript Style Guide. https://google.github.io/styleguide/jsguide.html#naming-local-variable-names https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#javascript Change-Id: I0be270d8cb8f219f048626591e6b623c4307eef7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused hostShutdownGunnar Mills2019-05-171-23/+0
| | | | | | | | | | | | | hostShutdown in api-utils is not used. The Orderly shutdown on the power operations page calls APIUtils.hostPowerOff. The immediate shutdown calls APIUtils.chassisPowerOff. Tested: Did not. Searched the code and double checked the firmware panel and power operations panel. Change-Id: I6f0d209c3d2f13539bbe3ed2405221e902aaf590 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Fix activate image and reboot BMCDixsie Wolmers2019-05-133-29/+18
| | | | | | | | | | | | | - Change bmcReboot callback in apiutils.js to HTTP request that returns a promise that is resolved with response object - Remove emitted 'user-logged-in' as it is not needed to reboot BMC on firmware controller and bmc reboot controller - Add toast message for visual confirmation of successful BMC reboot Tested: On Server Configuration > Firmware page uploaded new image to activate and automatically reboot. After 2-3 minutes confirmed image activated and then BMC rebooted after image activation. Tested Server Control > Reboot BMC page by selecting Reboot BMC, confirmed BMC rebooted. Resolves openbmc/phosphor-webui#79 Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ied6809ad1ed6cc3c73ac5c818c7a06607810c396
* Fix system overview edit hostname form validationdixsie2019-05-085-36/+55
| | | | | | | | | | | | | | - Add pattern for no spaces - Fix character count - Prepopulate hostname in input field - Show error for invalid input - Improve form accessibility - Correct global disabled primary button style Resolves openbmc/phosphor-webui#71 Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ia0601ac7c52229d0606dc5b13397b468fa81426d
* Add dropdown caret to time owner dropdown on Date and Time SettingsYoshie Muranaka2019-05-076-26/+26
| | | | | | | | | | | | | | - Use background-image strategy to add caret to dropdowns - Standardize implementation by including mixin to dropdown__button class and removing styled pseudo element Resolves ibm-openbmc/dev#478 Tested: Running locally on Chrome only. Ran into network request errors for newly added svg assets when mounting overlay Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I714c2515282676f368eafb2560177d2935680e23
* NPM update to partially address vulnerabilityGunnar Mills2019-05-032-1738/+1831
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Observed this security vulnerability in the phosphor-webui repo on GitHub: "We found a potential security vulnerability in one of your dependencies. tar Upgrade tar to version 4.4.2 or later." See https://nvd.nist.gov/vuln/detail/CVE-2018-20834 for more information. Ran "NPM update" && "npm install tar@latest --save". Unfortunately, this only addresses one of the packages that uses tar, the other, node-sass, has not published a release to fix this vulnerability. See https://github.com/sass/node-sass/issues/2625 Not a easy fix for node-sass. Opened https://github.com/openbmc/phosphor-webui/issues/85 to track this work. Tested: Built the GUI and loaded it on a Witherspoon. No regressions observed. Change-Id: I9e06d77a03dff4a3d12f472fd18671cc8c41fcd4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Revert "WebUI: Sensors page modifications"Gunnar Mills2019-05-014-232/+267
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c. "/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power) and "/xyz/openbmc_project/sensors/current/" sensors (e.g. p0_vcs_current) are no longer on the GUI Sensors Page. Since all sensors do not map to Thermal or Power, the SensorCollection, /redfish/v1/Chassis/{ChassisId}/Sensors, needs to be implemented before we move the GUI sensors page over to Redfish. The SensorCollection contains all sensors not covered elsewhere in the model. The SensorCollection will contain all sensors under /current and all non-powersupply sensors under /power. IBM is planning on working on the SensorCollection, it will be sometime before the code is in because of this, reverting moving the GUI sensor page over to Redfish. Apologies on not catching this in the review. For more information see: https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis https://redfish.dmtf.org/schemas/SensorCollection.json Tested: The current and power sensors are back on the Sensor page. Change-Id: Ia818fc05b49a8181b71f8756a6066c27e94dc46e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Pull the latest novnc packageJae Hyun Yoo2019-04-192-8/+13
| | | | | | | | | | | | | | | Investigated that IKVM issues on Windows browsers were caused by old novnc package. Currently, webui downloads novnc 1.0.0 from npm but the version was released a year ago so it doesn't have lots of bug fixes. Since novnc team published v1.1.0 recently so this commit updates novnc version to fix the Windows browser issue. Tested: From Windows FireFox or Chrome browser, Navigated to 'Server control -> KVM'. KVM worked stably. Change-Id: Iaf415f57678573fbbb7c2f33234a63da6c50acd9 Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
* Implement KVM in webuiEd tanous2019-04-1610-6/+96
| | | | | | | | | | | | | | | This patchset adds the infrastructure to allow KVM sessions through the webui. A websocket capable VNC/RFB connection on the BMC is needed for KVM sessions. To access, navigate to Server control -> KVM. Tested: Ran obmc-ikvm on the BMC, added a KVM Handler to Phosphor Rest Server, and was able to establish a KVM session in the webui on a Witherspoon. Change-Id: I7dda5bec41d270ae8d0913697714d4df4ec3a257 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Firmware page upload not working in some casesbeccabroek2019-04-113-22/+21
| | | | | | | | | | | | | | | | | | | | | | | | Upload was not working in some cases because of two separate issues. Inline onchange is no longer executed in Chrome. This removes the inline onchange event since it was updating a variable not being used anyway. This also updates the click-outside directive as it was missing [ ] brackets that were necessary and throwing an error in the console when loaded onto a witherspoon. see https://developer.chrome.com/extensions/contentSecurityPolicy and https://stackoverflow.com/questions/35126898/error-after-minifica tion-of-angular-js-error-injectorunpr-unknown-provider Resolves openbmc/phosphor-webui#77 Tested: Able to upload image onto Witherspoon. Click-outside directive worked when GUI was mounted on a Witherspoon Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Resolve accessibility isssuesDerick Montague2019-04-0813-137/+192
| | | | | | | | | | | | | | | | | | - Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes. Resolves openbmc/phosphor-webui#76 Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
* Add form validation and toast messages to user mgmtbeccabroek2019-04-053-73/+69
| | | | | | | | | | | | | | | | | | | | | | Adds form field validation with ng-messages and toast messages with toast service to the User management page. Also adds check that the number of users does not exceed 15 and that the username does not already exist prior to sending call to the backend. Resolves openbmc/phosphor-webui#73 Resolves openbmc/phosphor-webui#74 Tested: Able to add/delete/edit users as before. Page presents appropriate message to user upon creating or updating a user when: 1. A field is missing 2. Passwords don't match 3. Password is longer than max or shorter than min 4. Username already exists when creating new user 5. User tries to create the 16th user Change-Id: I5ae1a7979f7a396b0fb2ea280b875afc805a7f9f Signed-off-by: beccabroek <beccabroek@gmail.com>
* WebUI: Sensors page modificationsAppaRao Puli2019-04-054-267/+232
| | | | | | | | | | | | | | Modified sensors page to use Redfish as backend. Also added threshold sensor values in page view. Tested By: Loaded webui page and tested all operations. - Sensors page load and layout. - Search Filter and Severity filters. - Export functionality. Change-Id: Ic799453ffcd17e9a69e073a12173b4e97a928458 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
* Correct typo on stylesheet commentdixsie2019-04-021-1/+1
| | | | | Signed-off-by: dixsie <dixsiew@gmail.com> Change-Id: I30023fe18310631132c232e94baba5d0445f5f55
* SNMP page visual redesignbeccabroek2019-04-016-84/+243
| | | | | | | | | | | | | | | | | Adds form validation to SNMP page. Also adds new icons to page for edit and delete. Validation messages for inputs appear after input has been touched or if the user attempts to submit the form with validation errors. Tested: Add, remove, and update SNMP was successful and functionality unchanged. Form did not allow invalid or empty values to submitted. Used Chrome, Safari, and Firefox to verify that visual design looked as expected. Resolves openbmc/phosphor-webui#37 Change-Id: I7a97d80724e56d2f22c74ac1251041270bbc35ad Signed-off-by: beccabroek <beccabroek@gmail.com>
* User management: Remove disable redfish supportGunnar Mills2019-03-301-299/+81
| | | | | | | | | | | | | | | | | | | | | | | Removed redfishSupportEnabled = false for the user management page. The default is redfishSupportEnabled = true and no meta layers have redfishSupportEnabled = false so unused upstream. When redfishSupportEnabled = false, the /xyz/openbmc_project/user/<user>/action/SetPassword API is called. Neither bmcweb or phosphor-rest-server have a SetPassword API and so the user management page did not work when redfishSupportEnabled = false. The SetPassword API was removed when the new backend user management code was added, it was removed for security concerns. See https://github.com/openbmc/openbmc/issues/3454 for more info. Tested: On a Witherspoon, added users, updated roles and passwords, and deleted users. Change-Id: I3d9e30c0fc655fb23dee38fa5eeb52239c9faa64 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Update hex values to meet WCAG AA Guidelines for color contrastDerick Montague2019-03-286-12/+12
| | | | | | | | | | | | | | | - Change #3C6DF0 to #2D60E5 - Change #E62325 to #DA1416 Tested: I spot tested the Server Overview, the Event log and System logs pages to verify color changes and overall validate the update does not negatively impact the visual integrity of the app. Resolves openbmc/phosphor-webui#70 Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I2315527a98937176b3e3a2a2118e1798fa4c9e5d
* WebUI: Support for configure failed login attemptsAppaRao Puli2019-03-274-6/+141
| | | | | | | | | | | | | | | | This commit adds the support for failed login attempts configuration. With this user can configure the number of failed login attempts and account lockout duration. This also adds provision to view other user account properties like MaxPassword, MinPassword etc. Tested By: Loaded the Webui and modified values like Failed login Attempts and Account lockout duration. Also tested other account properties view. Change-Id: I6abd5a16771956640ba6b6d81c1c7ad9503067b1 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
* Fix login error messagebeccabroek2019-03-272-3/+3
| | | | | | | | | | | | | | | | Respose for invalid credentials changed and login page was no longer displaying the correct error message to the user when invalid credentials were entered. Resolves openbmc/phosphor-webui#72 Tested: Logged in with incorrect credentials and saw the correct message. Also logged in with an unreachable host and saw that that message was displaying correctly. Change-Id: I65cc6d6a061986568aded09555c5f75bcd59fe56 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Fix always loading issue on IE11Kuiying Wang2019-03-262-0/+20
| | | | | | | | | | | | | In some pages like server view page, always in loading status. Import babel-polyfill to solve cross browser issue on HTML5/CSS3, especially for the older browsers. Tested: launch IE11 visit https://BMC_IP_ADDR Change-Id: Ib8e59e236171fff595ac1e5df3a9111005b39268 Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
OpenPOWER on IntegriCloud