diff options
author | Gunnar Mills <gmills@us.ibm.com> | 2019-05-23 11:38:05 -0500 |
---|---|---|
committer | Gunnar Mills <gmills@us.ibm.com> | 2019-05-23 11:55:05 -0500 |
commit | f75dc93f3a35707a34937bd4186c7c9908892f42 (patch) | |
tree | cd728d0d34a8e48fd51a0e1403e92fc3fb8dd25f | |
parent | 419233f811d1fe1052f710ddde13e2a81c99ec13 (diff) | |
download | phosphor-webui-f75dc93f3a35707a34937bd4186c7c9908892f42.tar.gz phosphor-webui-f75dc93f3a35707a34937bd4186c7c9908892f42.zip |
Remove unused activateErrorModal
activateErrorModal was unused. Also remove Constants.ERROR_MODAL
since activateErrorModal was the only place which used it.
https://github.com/openbmc/phosphor-webui/commit/a1d238f3a53db2ec3cc4c2fd52fe78738b37968b#diff-65affd2488457363c5b9e9266258c3b8
added activateErrorModal / deactivateErrorModal.
https://github.com/openbmc/phosphor-webui/commit/a38a287ccaa97eddc9df7333e33357b14772d4c6#diff-65affd2488457363c5b9e9266258c3b8
removed its use.
Tested: Searched the repo and when testing the GUI on a
a Witherspoon, toasts worked as expected.
Change-Id: I98107f397fab039123f8507cd7bbac2ef8e5fb7b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
-rw-r--r-- | app/common/services/constants.js | 5 | ||||
-rw-r--r-- | app/common/services/dataService.js | 20 |
2 files changed, 0 insertions, 25 deletions
diff --git a/app/common/services/constants.js b/app/common/services/constants.js index 52e9f97..e1839f5 100644 --- a/app/common/services/constants.js +++ b/app/common/services/constants.js @@ -122,11 +122,6 @@ window.angular && (function(angular) { WARNING_NO_SENSOR_DATA: 'There are no sensors in Warning state.', NORMAL_NO_SENSOR_DATA: 'There are no sensors in Normal state.' }, - ERROR_MODAL: { - TITLE: 'Unexpected error', - DESCRIPTION: - 'Oops! An unexpected error occurred. Record specific details of the issue, then contact your company support services.' - }, ERROR_MESSAGE_DESC_TEMPLATE: '{{status}} - {{description}}', }, POWER_CAP_TEXT: {unit: 'W', disabled: 'Not Enabled'}, diff --git a/app/common/services/dataService.js b/app/common/services/dataService.js index 1cb63ee..b0d359c 100644 --- a/app/common/services/dataService.js +++ b/app/common/services/dataService.js @@ -111,26 +111,6 @@ window.angular && (function(angular) { } }; - this.activateErrorModal = function(data) { - if (data && data.hasOwnProperty('title')) { - this.errorModalDetails.title = data.title; - } else { - this.errorModalDetails.title = Constants.MESSAGES.ERROR_MODAL.TITLE; - } - - if (data && data.hasOwnProperty('description')) { - this.errorModalDetails.description = data.description; - } else { - this.errorModalDetails.description = - Constants.MESSAGES.ERROR_MODAL.DESCRIPTION; - } - this.displayErrorModal = true; - }; - - this.deactivateErrorModal = function() { - this.displayErrorModal = false; - }; - this.setSystemName = function(sysName) { this.systemName = sysName; }; |