diff options
| author | Patrick Venture <venture@google.com> | 2019-02-13 07:59:51 -0800 |
|---|---|---|
| committer | Patrick Venture <venture@google.com> | 2019-02-13 08:21:05 -0800 |
| commit | 976764158af29113103a9a6acd8911f4f06c6b27 (patch) | |
| tree | 8b432167e328f6fb2df57bb0979fc593c71bcc77 | |
| parent | 5e350795bfc4f100ea00cab34ab9b14bb3106d82 (diff) | |
| download | phosphor-watchdog-976764158af29113103a9a6acd8911f4f06c6b27.tar.gz phosphor-watchdog-976764158af29113103a9a6acd8911f4f06c6b27.zip | |
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: Ifdc864ea0d821ab4f1cff2be2a270317e25b801f
Signed-off-by: Patrick Venture <venture@google.com>
| -rw-r--r-- | configure.ac | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/configure.ac b/configure.ac index b1e9527..26cf79b 100644 --- a/configure.ac +++ b/configure.ac @@ -19,10 +19,10 @@ AX_APPEND_COMPILE_FLAGS([-Wall -Werror], [CXXFLAGS]) LT_INIT # Check for needed modules -PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging], [], [AC_MSG_ERROR([Could not find phosphor-logging...openbmc/phosphor-logging package required])]) -PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],, [AC_MSG_ERROR([Could not find sdbusplus...openbmc/sdbusplus package required])]) -PKG_CHECK_MODULES([SDEVENTPLUS], [sdeventplus],, [AC_MSG_ERROR([Could not find sdeventplus...openbmc/sdeventplus package required])]) -PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces], [], [AC_MSG_ERROR([Could not find phosphor-dbus-interfaces...openbmc/phosphor-dbus-interfaces package required])]) +PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging]) +PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus]) +PKG_CHECK_MODULES([SDEVENTPLUS], [sdeventplus]) +PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces]) PKG_CHECK_MODULES([GTEST_MAIN], [gtest_main], [], [ AX_PTHREAD([GTEST_MAIN_CFLAGS="-DGTEST_HAS_PTHREAD=1"],[GTEST_MAIN_CFLAGS="-DGTEST_HAS_PTHREAD=0"]) |
